From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web08.6649.1665067141373057130 for ; Thu, 06 Oct 2022 07:39:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t5Itkxph; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6398BB820E5 for ; Thu, 6 Oct 2022 14:38:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15A08C433C1 for ; Thu, 6 Oct 2022 14:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665067137; bh=AADDbY8c2nJGhSc5qVLtWW2yBNhhGl7rdNq5nGThi84=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=t5Itkxphw/IdE4aR/Q26/nDIUlGhTFl5MOblx4yAwnPzAjxbgADucFYpto+KUqD+G st6nwlFID51uhwWffoVG3sIPrFZ/SOf0qdFZUmq0FCJLAgFfIRMHCB7cEGd9cObPL0 NIK0yroBJeKZbcynS4hCMa//U5DSpySzGKqVZgMpAgva97Ww0XPZp+kTrn3ObUSAN3 YwODfWoY8F4kkhuTKMs0NoxGeK+wtC7BJ6xeGj39itLh9UP6t/yGEy0etL1FqOsC9K Y5NQ9lsGYjAnAoCdVLuAOUQvxfyKn2SvYy1bsItotmhoc3zuMLVzmIelLjFu4vSQhQ G8zLs7xxk4MIA== Received: by mail-lf1-f52.google.com with SMTP id d6so2992331lfs.10 for ; Thu, 06 Oct 2022 07:38:56 -0700 (PDT) X-Gm-Message-State: ACrzQf09JfyVYBaj4BYeun4ZFVCd/BgmNGQUIk/oGK8B/0VjG3yAeh6h D0v3vjd6FJWf2xp/miPd07Eqzo9l3YjiUoroVJY= X-Google-Smtp-Source: AMsMyM5QMTQem3WgEojHpb3lifoDAzzJzDPG5Foy2Mk45X9krwdCC8R3LScPxGv3kQQzeno5nWHp8ssH4t2KFnCpq80= X-Received: by 2002:a05:6512:150e:b0:492:d9fd:9bdf with SMTP id bq14-20020a056512150e00b00492d9fd9bdfmr87057lfb.583.1665067135104; Thu, 06 Oct 2022 07:38:55 -0700 (PDT) MIME-Version: 1.0 References: <9c52d44c283b1c42de20ee373be1d4994c4daf35.1655229046.git.jbrasen@nvidia.com> <001001d89b10$fc9254a0$f5b6fde0$@byosoft.com.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 6 Oct 2022 16:38:43 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs To: devel@edk2.groups.io, jbrasen@nvidia.com Cc: gaoliming , "jian.j.wang@intel.com" , "zhichao.gao@intel.com" , "ray.ni@intel.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 6 Oct 2022 at 16:23, Jeff Brasen via groups.io wrote: > > Any additional thoughts on this patch? > If you resend it using a mail client that doesn't corrupt all the whitespace, I can merge it for you (with Zhichao's ack). > > -----Original Message----- > > From: Jeff Brasen > > Sent: Tuesday, July 19, 2022 9:14 AM > > To: gaoliming ; devel@edk2.groups.io > > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: > > Add Disk Info support for Ufs > > > > Yes, Universal Flash Storage is based on the SCSI architectural model a= nd > > installs gEfiExtScsiPassThruProtocolGuid to function. > > > > Thanks, > > Jeff > > > > > -----Original Message----- > > > From: gaoliming > > > Sent: Monday, July 18, 2022 7:44 PM > > > To: devel@edk2.groups.io; Jeff Brasen > > > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com > > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH] > > MdeModulePkg/UefiBootManagerLib: > > > Add Disk Info support for Ufs > > > > > > External email: Use caution opening links or attachments > > > > > > > > > Jeff: > > > I want to confirm why UFS apply the same rule to SCSI. Does UFS > > > follows SCSI spec? > > > > > > Thanks > > > Liming > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Jeff > > Brasen > > > via > > > > groups.io > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=8815=E6= =97=A5 1:54 > > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > > =E6=8A=84=E9=80=81: jian.j.wang@intel.com; gaoliming@byosoft.com.cn= ; > > > > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen > > > > > > > > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManag= erLib: Add > > > Disk > > > > Info support for Ufs > > > > > > > > Add support for getting disk info from UFS devices. > > > > > > > > Signed-off-by: Jeff Brasen > > > > --- > > > > MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3 > > > > ++- > > > > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | > > 1 > > > + > > > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git > > > > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > > > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > > > > index fac33b9ee9..87b82f299f 100644 > > > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > > > > +++ > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > > > > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo ( > > > > > > > > > > > > BmEliminateExtraSpaces (Description); > > > > > > > > } > > > > > > > > - } else if (CompareGuid (&DiskInfo->Interface, > > > > &gEfiDiskInfoScsiInterfaceGuid)) { > > > > > > > > + } else if (CompareGuid (&DiskInfo->Interface, > > > > &gEfiDiskInfoScsiInterfaceGuid) || > > > > > > > > + CompareGuid (&DiskInfo->Interface, > > > > &gEfiDiskInfoUfsInterfaceGuid)) { > > > > > > > > BufferSize =3D sizeof (EFI_SCSI_INQUIRY_DATA); > > > > > > > > Status =3D DiskInfo->Inquiry ( > > > > > > > > DiskInfo, > > > > > > > > diff --git > > > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > > > index fe05d5f1cc..2fc0a80a4e 100644 > > > > --- > > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > > > +++ > > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > > > @@ -85,6 +85,7 @@ > > > > gEfiDiskInfoIdeInterfaceGuid ## > > > > SOMETIMES_CONSUMES ## GUID > > > > > > > > gEfiDiskInfoScsiInterfaceGuid ## > > > > SOMETIMES_CONSUMES ## GUID > > > > > > > > gEfiDiskInfoSdMmcInterfaceGuid ## > > > > SOMETIMES_CONSUMES ## GUID > > > > > > > > + gEfiDiskInfoUfsInterfaceGuid ## > > > > SOMETIMES_CONSUMES ## GUID > > > > > > > > > > > > > > > > [Protocols] > > > > > > > > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES > > > > > > > > -- > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > >