Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

["Ard Biesheuvel" <ardb@kernel.org>]

On Mon, 14 Aug 2023 at 10:15, Corvin Köhne <corvink@freebsd.org> wrote:
>
> On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote:
> > I'm not sure why test results are not being reported that may be a
> > larger issue.
> >
> > I pulled the branch locally, run uncrustify, and it automatically
> > fixed
> > the code to pass.
> >
> > The issue is the following function call:
> >
> >    BuildPlatformInfoHob();
> >
> > Should be:
> >
> >    BuildPlatformInfoHob ();
> >
>
> I already run uncrustify locally but it doesn't complain about it.
> Thank you!
>
> Should I resend an updated patch?
> Can this change make it into edk-stable202308? Otherwise, fwcfg won't
> be usable by bhyve in this version.
>

It is up to Liming to decide but given that

- it is low risk as it only touches bhyve platform code
- i would have merged it already if bugs in the CI wouldn't have
prevented me from doing so

I would be in favour of including this change


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107761): https://edk2.groups.io/g/devel/message/107761
Mute This Topic: https://groups.io/mt/100327419/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-