From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4BC357803CC for ; Tue, 15 Aug 2023 08:10:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fmFZWs4ZvsZ9p0GPOtwUYE7IFlgGUmDz1mz6SSd/fQg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692087023; v=1; b=hXjE7oDK5nGUoDK3oKV0Bjb1mB8VlzlnRv+jEG49B0ypdd4ppbCwLftPQEJFtSOq/357LRMU eCtsJKyIrZH28EpDEfs5N7rEov5pdh6lP9dqmFPrSjnSVcda2Isj5dT3p1ZlVORotwFeKUSttCE 6OtkxArHBb/Q3YTMbaCziwGI= X-Received: by 127.0.0.2 with SMTP id UZYxYY7687511xJbxWif1Et5; Tue, 15 Aug 2023 01:10:23 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.129880.1692087022287074836 for ; Tue, 15 Aug 2023 01:10:22 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF73463464 for ; Tue, 15 Aug 2023 08:10:21 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0331AC433C8 for ; Tue, 15 Aug 2023 08:10:20 +0000 (UTC) X-Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2b9ab1725bbso77004811fa.0 for ; Tue, 15 Aug 2023 01:10:20 -0700 (PDT) X-Gm-Message-State: 9DTrVf4m3GmybSdchPvefRD3x7686176AA= X-Google-Smtp-Source: AGHT+IGZ3/wsCPCLVG0NJfk+5uiXi4rkynKVdiwIubltrFKi/VDzw9NrWbn5JfF9t6VKaiVKKnt+jPIZpGKsE0duR0A= X-Received: by 2002:a19:710b:0:b0:4fd:d470:203b with SMTP id m11-20020a19710b000000b004fdd470203bmr7287673lfc.69.1692087019058; Tue, 15 Aug 2023 01:10:19 -0700 (PDT) MIME-Version: 1.0 References: <20230724130006.427522-1-corvink@FreeBSD.org> <20230724130006.427522-2-corvink@FreeBSD.org> <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> <47a7e3eb-2049-bbc3-3e74-0c115f00702e@linux.microsoft.com> <35b68f61774b96e6b68e72c6ca056a10d2601087.camel@FreeBSD.org> In-Reply-To: <35b68f61774b96e6b68e72c6ca056a10d2601087.camel@FreeBSD.org> From: "Ard Biesheuvel" Date: Tue, 15 Aug 2023 10:10:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB To: devel@edk2.groups.io, corvink@freebsd.org, "Liming Gao (Byosoft address)" Cc: mikuback@linux.microsoft.com, Rebecca Cran , Michael Kinney , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hXjE7oDK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, 14 Aug 2023 at 10:15, Corvin K=C3=B6hne wrote= : > > On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote: > > I'm not sure why test results are not being reported that may be a > > larger issue. > > > > I pulled the branch locally, run uncrustify, and it automatically > > fixed > > the code to pass. > > > > The issue is the following function call: > > > > BuildPlatformInfoHob(); > > > > Should be: > > > > BuildPlatformInfoHob (); > > > > I already run uncrustify locally but it doesn't complain about it. > Thank you! > > Should I resend an updated patch? > Can this change make it into edk-stable202308? Otherwise, fwcfg won't > be usable by bhyve in this version. > It is up to Liming to decide but given that - it is low risk as it only touches bhyve platform code - i would have merged it already if bugs in the CI wouldn't have prevented me from doing so I would be in favour of including this change -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107761): https://edk2.groups.io/g/devel/message/107761 Mute This Topic: https://groups.io/mt/100327419/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-