From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0411F74005F for ; Tue, 19 Sep 2023 14:46:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZIiSVHfGigh9EjBDmdQiD26r0zEmLeadKMovrMVMS2A=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1695134781; v=1; b=Lpfciy4Pyq0Dec0WWSumhMvVR9GLZZzr3gxmQtqb9d1KhMbXrO3RSp9KFq3OryYY/eSHue2k ZpB+d/FWrB0X8c0eWEjg3e0xsgb6dkFXOwoWozVen6qXv9kwd5uN2nSE41dxztAJ/cuE1gYJokv ZTdenlShTc8fB0BakRfnTm0c= X-Received: by 127.0.0.2 with SMTP id GhqYYY7687511x9tBx6OUnJS; Tue, 19 Sep 2023 07:46:21 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.10905.1695134781148869721 for ; Tue, 19 Sep 2023 07:46:21 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B15F61701 for ; Tue, 19 Sep 2023 14:46:20 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7D12C433CB for ; Tue, 19 Sep 2023 14:46:19 +0000 (UTC) X-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2bfea381255so54754031fa.3 for ; Tue, 19 Sep 2023 07:46:19 -0700 (PDT) X-Gm-Message-State: NjNEchMizUckv8Vg2WmyZfZ0x7686176AA= X-Google-Smtp-Source: AGHT+IHTap0IMmiXlz1ZItyoDxZI0C9+DBTPbFkYikQmZ3iKlZ5J7pEt4tnPessAHJtP4nJxBNAEvgfgRndHc8RPZYQ= X-Received: by 2002:a2e:9297:0:b0:2bc:fc2e:7671 with SMTP id d23-20020a2e9297000000b002bcfc2e7671mr9559939ljh.13.1695134778038; Tue, 19 Sep 2023 07:46:18 -0700 (PDT) MIME-Version: 1.0 References: <20230913170617.429-1-mikuback@linux.microsoft.com> <20230913170617.429-5-mikuback@linux.microsoft.com> <0c073095-9f42-c740-72d4-a74a8c1b4ccc@linux.microsoft.com> In-Reply-To: <0c073095-9f42-c740-72d4-a74a8c1b4ccc@linux.microsoft.com> From: "Ard Biesheuvel" Date: Tue, 19 Sep 2023 14:46:06 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception To: Michael Kubacki , Michael Kinney , Andrew Fish Cc: devel@edk2.groups.io, Leif Lindholm , Sami Mujawar , Gerd Hoffmann Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Lpfciy4P; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, 18 Sept 2023 at 22:35, Michael Kubacki wrote: > > Thanks Ard. I still need a Reviewed-by on this patch to complete the series. > Actually, you don't but I suppose there is some difference of interpretation here. In the Linux community (where these tags originated), an ack from a maintainer means 'no objections, feel free to apply this to code that I maintain'. In this case, I am not 100% sure what the change means, so I am not comfortable claiming that I reviewed it, but given that this is your area of expertise rather than mine, I trust that you know what you are doing. Hence the acked-by. In other cases, I may rely on another person's expertise and their reviewed-by to decide whether or not to merge something, rather than review it myself. In this case, the acked-by is implied by the fact that I decided to merge the PR (and therefore somewhat redundant). But it comes down to the same thing. If there is a Tianocore rule that says every patch needs a reviewed-by from a maintainer, we should probably fix that. It is *not* the job of a maintainer to review everything (and this wouldn't scale to begin with) - rather, it is their job to ensure that everything that gets merged has been reviewed sufficiently, either by themselves or by other people they have confidence in. > On 9/13/2023 1:10 PM, Ard Biesheuvel wrote: > > On Wed, 13 Sept 2023 at 19:07, wrote: > >> > >> From: Michael Kubacki > >> > >> Adds a CI YAML entry to acknowledge a case where a macro is expanded > >> that contains a print specifier. > >> > >> Cc: Ard Biesheuvel > >> Cc: Leif Lindholm > >> Cc: Sami Mujawar > >> Cc: Gerd Hoffmann > >> Signed-off-by: Michael Kubacki > > > > Acked-by: Ard Biesheuvel > > > >> --- > >> ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml > >> index 1e799dc4e194..506b0e72f0bb 100644 > >> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml > >> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml > >> @@ -125,5 +125,13 @@ > >> ], # words to extend to the dictionary for this package > >> "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore > >> "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported) > >> + }, > >> + > >> + "DebugMacroCheck": { > >> + "StringSubstitutions": { > >> + # DynamicTablesPkg/Include/ConfigurationManagerObject.h > >> + # Reason: Expansion of macro that contains a print specifier. > >> + "FMT_CM_OBJECT_ID": "0x%lx" > >> + } > >> } > >> } > >> -- > >> 2.42.0.windows.2 > >> > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108845): https://edk2.groups.io/g/devel/message/108845 Mute This Topic: https://groups.io/mt/101341655/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-