From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 91B5D7803E3 for ; Wed, 23 Aug 2023 14:59:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=L4oeK+pwt+uE/wNwcanC1DXs2iI20SRIJw98f0SYDhs=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692802787; v=1; b=wHp5rKoqX5dyTe1pWX4KOmdDMZuey2AWtfPQjHCMggtEOOoDA3olaDNFfri363KcMOa0uCAV 00hdmupFT01lJ+KlOZQBQhHfi2WRtm9YVKmMgUzt2QShD8/QAFy3l4NToAdlqg2Rw3rDzDAMvi+ C4VsKDyC1/QMO60SXkon2eWs= X-Received: by 127.0.0.2 with SMTP id WYm3YY7687511xyUJWZvyAXP; Wed, 23 Aug 2023 07:59:47 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.13788.1692802786512070162 for ; Wed, 23 Aug 2023 07:59:46 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C25F664547 for ; Wed, 23 Aug 2023 14:59:45 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE075C433C9 for ; Wed, 23 Aug 2023 14:59:44 +0000 (UTC) X-Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2bcda0aaf47so10567691fa.1 for ; Wed, 23 Aug 2023 07:59:44 -0700 (PDT) X-Gm-Message-State: e6xdwKoVvB941MPuX3pvSGcOx7686176AA= X-Google-Smtp-Source: AGHT+IHn1porQyA3bykWHI2IlJRZWPOWoVEiK43UCcChJOSBG3rB034QYsm7LEj0rYF3oFkglphqfASploiZ7r4xwNA= X-Received: by 2002:a19:520b:0:b0:4fe:7e3d:de7 with SMTP id m11-20020a19520b000000b004fe7e3d0de7mr4253196lfb.29.1692802782841; Wed, 23 Aug 2023 07:59:42 -0700 (PDT) MIME-Version: 1.0 References: <20230524140600.1432056-1-kraxel@redhat.com> <20230524140600.1432056-3-kraxel@redhat.com> <9dcb608a-d78b-0eee-9d74-4aaa4759b39c@quicinc.com> In-Reply-To: <9dcb608a-d78b-0eee-9d74-4aaa4759b39c@quicinc.com> From: "Ard Biesheuvel" Date: Wed, 23 Aug 2023 16:59:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v6 02/11] BaseTools: add -fdirect-access-external-data to clang pie builds To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: Gerd Hoffmann Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wHp5rKoq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 23 Aug 2023 at 13:09, Leif Lindholm wrote: > > Since I didn't find any previous record of the fact, I'm replying here > to say that this change breaks the build with clang11 as packaged in > Debian "bullseye" (old stable). > > If anyone could reply with which version of clang this flag was added > in, that would be ideal. > Added here https://reviews.llvm.org/D92633 Present in branches main, release/12.x, release/13.x, release/14.x, release/15.x, release/16.x, release/17.x > Since no one else reported it, I don't see a need to change anything. > OK. > On 2023-05-24 15:05, Gerd Hoffmann wrote: > > Tell clang to not use external (via got) references for data access. > > > > Signed-off-by: Gerd Hoffmann > > Reviewed-by: Ard Biesheuvel > > --- > > BaseTools/Conf/tools_def.template | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > > index 503a6687c1f0..92421e3d0118 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -1921,15 +1921,15 @@ NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS = DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 - > > *_CLANGDWARF_X64_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWARF_X64_TARGET) > > *_CLANGDWARF_X64_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWARF_X64_TARGET) > > > > -DEBUG_CLANGDWARF_X64_CC_FLAGS = DEF(CLANGDWARF_ALL_CC_FLAGS) -m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -fpie -Oz -flto DEF(CLANGDWARF_X64_TARGET) -g > > +DEBUG_CLANGDWARF_X64_CC_FLAGS = DEF(CLANGDWARF_ALL_CC_FLAGS) -m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -fpie -fdirect-access-external-data -Oz -flto DEF(CLANGDWARF_X64_TARGET) -g > > DEBUG_CLANGDWARF_X64_DLINK_FLAGS = DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_x86_64 -Wl,--oformat,elf64-x86-64 -Wl,-pie -mcmodel=small -Wl,--apply-dynamic-relocs > > DEBUG_CLANGDWARF_X64_DLINK2_FLAGS = DEF(CLANGDWARF_X64_DLINK2_FLAGS) -O3 -fuse-ld=lld > > > > -RELEASE_CLANGDWARF_X64_CC_FLAGS = DEF(CLANGDWARF_ALL_CC_FLAGS) -m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -fpie -Oz -flto DEF(CLANGDWARF_X64_TARGET) > > +RELEASE_CLANGDWARF_X64_CC_FLAGS = DEF(CLANGDWARF_ALL_CC_FLAGS) -m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -fpie -fdirect-access-external-data -Oz -flto DEF(CLANGDWARF_X64_TARGET) > > RELEASE_CLANGDWARF_X64_DLINK_FLAGS = DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_x86_64 -Wl,--oformat,elf64-x86-64 -Wl,-pie -mcmodel=small -Wl,--apply-dynamic-relocs > > RELEASE_CLANGDWARF_X64_DLINK2_FLAGS = DEF(CLANGDWARF_X64_DLINK2_FLAGS) -O3 -fuse-ld=lld > > > > -NOOPT_CLANGDWARF_X64_CC_FLAGS = DEF(CLANGDWARF_ALL_CC_FLAGS) -m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -fpie -O0 DEF(CLANGDWARF_X64_TARGET) -g > > +NOOPT_CLANGDWARF_X64_CC_FLAGS = DEF(CLANGDWARF_ALL_CC_FLAGS) -m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -fpie -fdirect-access-external-data -O0 DEF(CLANGDWARF_X64_TARGET) -g > > NOOPT_CLANGDWARF_X64_DLINK_FLAGS = DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_x86_64 -Wl,--oformat,elf64-x86-64 -Wl,-pie -mcmodel=small -Wl,--apply-dynamic-relocs > > NOOPT_CLANGDWARF_X64_DLINK2_FLAGS = DEF(CLANGDWARF_X64_DLINK2_FLAGS) -O0 -fuse-ld=lld > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107979): https://edk2.groups.io/g/devel/message/107979 Mute This Topic: https://groups.io/mt/99109300/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-