From: "Ard Biesheuvel" <ardb@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io,
Michael Kubacki <michael.kubacki@microsoft.com>,
Oliver Steffen <osteffen@redhat.com>
Subject: Re: [PATCH 2/3] ArmVirtPkg: CI: Perform build and boot test of ArmVirtQemuKernel
Date: Mon, 23 Jan 2023 17:07:08 +0100 [thread overview]
Message-ID: <CAMj1kXFXPLsROxNqHEMpbEWYB-kmB=HmXKZRTwfTNL_M1Uq0tg@mail.gmail.com> (raw)
In-Reply-To: <20230119091449.ccj5dhrhwhtdrs33@sirius.home.kraxel.org>
On Thu, 19 Jan 2023 at 10:14, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> > diff --git a/ArmVirtPkg/PlatformCI/QemuKernelBuild.py b/ArmVirtPkg/PlatformCI/QemuKernelBuild.py
> > new file mode 100644
> > index 000000000000..1c652478cb41
> > --- /dev/null
> > +++ b/ArmVirtPkg/PlatformCI/QemuKernelBuild.py
>
> In OvmfPkg I've moved common code over to PlatformBuildLib.py which is
> used by the individual *Build.py files (which can be small then).
>
Many of the methods are subtly different, and I'm not sure if it makes
sense to parameterize this with variables
E.g., ArmVirtQemuKernel is booted with -kernel not -bios, and needs
highmem=off for the 32-bit ARM boot test.
next prev parent reply other threads:[~2023-01-23 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 8:21 [PATCH 0/3] ArmVirtPkg: Increase PlatformCI coverage Ard Biesheuvel
2023-01-19 8:21 ` [PATCH 1/3] ArmVirtPkg/PrePi: Ensure timely execution of library constructors Ard Biesheuvel
2023-01-19 8:21 ` [PATCH 2/3] ArmVirtPkg: CI: Perform build and boot test of ArmVirtQemuKernel Ard Biesheuvel
2023-01-19 9:14 ` Gerd Hoffmann
2023-01-23 16:07 ` Ard Biesheuvel [this message]
2023-01-19 8:21 ` [PATCH 3/3] ArmVirtPkg: CI: Perform build test of ArmVirtKvmTool Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXFXPLsROxNqHEMpbEWYB-kmB=HmXKZRTwfTNL_M1Uq0tg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox