From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.46036.1674490045597681373 for ; Mon, 23 Jan 2023 08:07:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dkSmdY3Y; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 530E1B80DCC for ; Mon, 23 Jan 2023 16:07:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B3AFC433D2 for ; Mon, 23 Jan 2023 16:07:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674490042; bh=OZ7imxTKTRnc2mB4Zg1B3OI2wEKI8qj4jGGySRJOVGw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dkSmdY3YvWXwoAiXL8TK9k64Xc3q7VYRCXPd9Y5xwZQCfZ+9/OFY/DuvAQl527SkC iobGzeWKKYe6n6PrRAlA1CxOdPmf2B0S5EItCULW+d7v4ZJ5UV9EbRGkOCgmaiXCF8 6e6p+aFiwygoKwOaVU1iC4pAikQk6LL1dWVSzrqT9kFXF+UjNdxifIDo0BvI1RnZ7X vvXmdLJdxdIMMhB4cDdhqe2sYKrCL5hSDTNiYXo31YVh+NciKrvJORQiBTWsNyVifc KDKXoYJT1GCkB3aYQ4eWj2gZZaOZhInA1nZtjd+w002TTgXpydh2UH7ws4XFseuMFr ROXwbw/Z8ihFw== Received: by mail-lf1-f47.google.com with SMTP id a11so19036776lfg.0 for ; Mon, 23 Jan 2023 08:07:21 -0800 (PST) X-Gm-Message-State: AFqh2kpqhenXQ/8daCUhx2cMBqew0Bp0XGIjkPaN/RqllyRvYH/UsxuU MsD36ygvP++QhaQINKp+uXb7wabmnL9wwa3oRho= X-Google-Smtp-Source: AMrXdXu0BWIyxtQOBk+y4hhGbKQNA587cs5TAuVsm1QFuVkRaToLHIfZRq2r6TIwLfjLEdqz0zeEY/4k9ha8cgRnwRQ= X-Received: by 2002:a05:6512:3086:b0:4bc:bdf5:f163 with SMTP id z6-20020a056512308600b004bcbdf5f163mr1318837lfd.583.1674490040045; Mon, 23 Jan 2023 08:07:20 -0800 (PST) MIME-Version: 1.0 References: <20230119082153.1520196-1-ardb@kernel.org> <20230119082153.1520196-3-ardb@kernel.org> <20230119091449.ccj5dhrhwhtdrs33@sirius.home.kraxel.org> In-Reply-To: <20230119091449.ccj5dhrhwhtdrs33@sirius.home.kraxel.org> From: "Ard Biesheuvel" Date: Mon, 23 Jan 2023 17:07:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] ArmVirtPkg: CI: Perform build and boot test of ArmVirtQemuKernel To: Gerd Hoffmann Cc: devel@edk2.groups.io, Michael Kubacki , Oliver Steffen Content-Type: text/plain; charset="UTF-8" On Thu, 19 Jan 2023 at 10:14, Gerd Hoffmann wrote: > > > diff --git a/ArmVirtPkg/PlatformCI/QemuKernelBuild.py b/ArmVirtPkg/PlatformCI/QemuKernelBuild.py > > new file mode 100644 > > index 000000000000..1c652478cb41 > > --- /dev/null > > +++ b/ArmVirtPkg/PlatformCI/QemuKernelBuild.py > > In OvmfPkg I've moved common code over to PlatformBuildLib.py which is > used by the individual *Build.py files (which can be small then). > Many of the methods are subtly different, and I'm not sure if it makes sense to parameterize this with variables E.g., ArmVirtQemuKernel is booted with -kernel not -bios, and needs highmem=off for the 32-bit ARM boot test.