From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.6019.1613033607982013636 for ; Thu, 11 Feb 2021 00:53:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ihZdXy2/; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6FB3964E8B for ; Thu, 11 Feb 2021 08:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613033607; bh=oWo1121Ue1Y/AHJ5ghPWu1QeoehmgiLrAtvGyUuc/wQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ihZdXy2//5NqS++cfOK4ZuukzL/rr5Yv/o+iE5ZaF/jM7jyEXz58aDSMOtLcLZHwP GPU2LfZUrA3/icsCJJLdRNPF8DxRx4DH0CFLe+ZJxC6/HbN77/FDPoEz/LaLqsRQ4p gxtt79WpZnr88Me0nE2/3XECax3nGuQ5OPIENGg8/jLdZbKzDC8nJzL6BqTYOugMfn udlg960ezs9tLiOWUvjcpAm3QF6g0HgAse3WCyjufIxhFRZvmW7VKOoWPnSu7q8lIB A1B2iP0SRP5Yl1UiYdJgnVyi1KuhLxHcrsC0GEXPbX/swx0vbLwC78ArS0LwoIol4T ZOLN0+j7TxUuQ== Received: by mail-oi1-f169.google.com with SMTP id i3so5300877oif.1 for ; Thu, 11 Feb 2021 00:53:27 -0800 (PST) X-Gm-Message-State: AOAM533LMefR3W115VZ/1E1kAn3MTe9ZjkQonC4Ufn1Sb4Sc19FK6tLq 7fw47D8klfvXp0jgegk7MxIG56ZXrQCnQhgusOo= X-Google-Smtp-Source: ABdhPJz92LRuF5CFtjYC1nXFqPdU2x+j/k/HFMlKgnQQp18ab31NslvUdR//b443EYEUCNyd4+1MFGiEsfGzW7fSH8s= X-Received: by 2002:aca:4bd1:: with SMTP id y200mr2075590oia.33.1613033606856; Thu, 11 Feb 2021 00:53:26 -0800 (PST) MIME-Version: 1.0 References: <20210211010115.1512-1-mikuback@linux.microsoft.com> In-Reply-To: <20210211010115.1512-1-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Thu, 11 Feb 2021 09:53:15 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] StandaloneMmPkg: Add X64 build support To: Michael Kubacki Cc: devel@edk2.groups.io, Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh Content-Type: text/plain; charset="UTF-8" On Thu, 11 Feb 2021 at 02:02, wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3202 > > Several libraries have been added to the package to support X64 but > the package itself does not support X64. This modifies the DSC to > enable X64 build. > > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Signed-off-by: Michael Kubacki > Acked-by: Sami Mujawar Merged, thanks. > --- > > Notes: > V2 changes: Update Ard's email address > > StandaloneMmPkg/StandaloneMmPkg.dsc | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc > index a566724c88ab..73f3f0f6b1cd 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > @@ -3,6 +3,7 @@ > # > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> # Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
> +# Copyright (C) Microsoft Corporation
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -19,7 +20,7 @@ [Defines] > PLATFORM_VERSION = 1.0 > DSC_SPECIFICATION = 0x00010011 > OUTPUT_DIRECTORY = Build/StandaloneMm > - SUPPORTED_ARCHITECTURES = AARCH64 > + SUPPORTED_ARCHITECTURES = AARCH64|X64 > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > > @@ -37,6 +38,7 @@ [LibraryClasses] > # > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > + CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf > @@ -47,7 +49,7 @@ [LibraryClasses] > MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf > MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > - PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > + PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf > @@ -60,6 +62,7 @@ [LibraryClasses.AARCH64] > StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf > CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf > + PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > @@ -110,11 +113,11 @@ [Components.common] > StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf > StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf > StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf > - StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf > > [Components.AARCH64] > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > + StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > > ################################################################################################### > # > @@ -128,3 +131,7 @@ [Components.AARCH64] > [BuildOptions.AARCH64] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp -mstrict-align > GCC:*_*_*_CC_FLAGS = -mstrict-align > + > +[BuildOptions.X64] > + MSFT:*_*_*_DLINK_FLAGS = /ALIGN:4096 > + GCC:*_GCC*_*_DLINK_FLAGS = -z common-page-size=0x1000 > -- > 2.28.0.windows.1 >