From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, hao.a.wu@intel.com
Cc: Giri Mudusuru <girim@apple.com>, "Ni, Ray" <ray.ni@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
Andrew Fish <afish@apple.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect
Date: Wed, 17 May 2023 13:45:53 +0200 [thread overview]
Message-ID: <CAMj1kXFZeg7Xm90hOZ+MLx9aUexDC21mUYWD3_5jJ-A1asc7YQ@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB40256D32AC737B9E8A48192FCA7E9@DM6PR11MB4025.namprd11.prod.outlook.com>
On Wed, 17 May 2023 at 06:19, Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> Thanks for the patch, inline comment below:
>
>
> > -----Original Message-----
> > From: Giri Mudusuru <girim@apple.com>
> > Sent: Friday, May 12, 2023 5:55 PM
> > To: devel@edk2.groups.io
> > Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni,
> > Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>
> > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug
> > print is incorrect
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394
> >
> > Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit
> > pointer
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Andrew Fish <afish@apple.com>
> > Signed-off-by: Giri Mudusuru <girim@apple.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > index aab6815328..2e7497a89d 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > @@ -30,7 +30,7 @@ DumpCapabilityReg (
> > //
> >
> > // Dump Capability Data
> >
> > //
> >
> > - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot,
> > Capability));
> >
> > + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", Slot,
> > *(UINT64 *)Capability));
>
>
> Please help to use %p for printing pointers.
>
Why? The point of this patch is that we are not interested in the
pointer, only in the value that it points to.
next prev parent reply other threads:[~2023-05-17 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 9:54 [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect Giri Mudusuru
2023-05-17 4:19 ` Wu, Hao A
2023-05-17 11:45 ` Ard Biesheuvel [this message]
2023-05-17 13:16 ` [edk2-devel] " Wu, Hao A
2023-05-17 18:00 ` Giri Mudusuru
2023-05-29 4:53 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXFZeg7Xm90hOZ+MLx9aUexDC21mUYWD3_5jJ-A1asc7YQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox