From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web10.47175.1684323968454268288
 for <devel@edk2.groups.io>;
 Wed, 17 May 2023 04:46:08 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZYVhZEjx;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id E66A46184A
	for <devel@edk2.groups.io>; Wed, 17 May 2023 11:46:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C2B8C4339E
	for <devel@edk2.groups.io>; Wed, 17 May 2023 11:46:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1684323967;
	bh=NbasMlGjsoQj5eSDtilxzguz2lBGjyyHiYABOLukc60=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=ZYVhZEjxablovfPHt3FsnWHGBfWshEFN5TsTl+FkoSrIpHJ7YZPZJdlRQqwY2LEUR
	 UXRvCvP3ljJk+JlzKSBK3GJ0Yvrq7461M9/b6TybCxfmQE8pGJzZjiCSEecV1+plPN
	 oJb2/SStu6Meeizz1Lyuc8bnZUeAZZVhAJCfaHIClCrYGKNQqMWWbi2yYRgA5y3O6d
	 6UTEAU6KEv5LUQj3I2X4F9mqDB9AzZBct6rlYIz6tQMWJHIJUzyxZdgoF+9usVefS1
	 N9SZ4D+j6D0yMIp4mQl1QN+aOpeHp2O+5hVeL76MVSclFThoPNfd4+N+GWwb3mPCgN
	 ZVcE9UOuTgVmA==
Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2ac831bb762so5952441fa.3
        for <devel@edk2.groups.io>; Wed, 17 May 2023 04:46:07 -0700 (PDT)
X-Gm-Message-State: AC+VfDxcJvSOQhibwMbgFqz5PQ6tweV+E+bXl1acwrmA1fkkIkWKFy+o
	ygE2Pr/1G0Np0736HkSM1y/jP0rT4H6HybpeQ28=
X-Google-Smtp-Source: ACHHUZ6RjEcRqU1HAWls92v77b0tD2HzJSQRsHy/fEKP+5GPge4Q0npLCwPl4YmAbOY9iYJsfcBeLidsofVpKUZLBRg=
X-Received: by 2002:a2e:b709:0:b0:2ad:f8d:dea with SMTP id j9-20020a2eb709000000b002ad0f8d0deamr10400139ljo.11.1684323965427;
 Wed, 17 May 2023 04:46:05 -0700 (PDT)
MIME-Version: 1.0
References: <7ba00d73bd53c401b9fcd6fd4a3a79f9e43d9662.1683885276.git.girim@apple.com>
 <DM6PR11MB40256D32AC737B9E8A48192FCA7E9@DM6PR11MB4025.namprd11.prod.outlook.com>
In-Reply-To: <DM6PR11MB40256D32AC737B9E8A48192FCA7E9@DM6PR11MB4025.namprd11.prod.outlook.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 17 May 2023 13:45:53 +0200
X-Gmail-Original-Message-ID: <CAMj1kXFZeg7Xm90hOZ+MLx9aUexDC21mUYWD3_5jJ-A1asc7YQ@mail.gmail.com>
Message-ID: <CAMj1kXFZeg7Xm90hOZ+MLx9aUexDC21mUYWD3_5jJ-A1asc7YQ@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect
To: devel@edk2.groups.io, hao.a.wu@intel.com
Cc: Giri Mudusuru <girim@apple.com>, "Ni, Ray" <ray.ni@intel.com>, 
	"Wang, Jian J" <jian.j.wang@intel.com>, "Gao, Liming" <gaoliming@byosoft.com.cn>, 
	Andrew Fish <afish@apple.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 17 May 2023 at 06:19, Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> Thanks for the patch, inline comment below:
>
>
> > -----Original Message-----
> > From: Giri Mudusuru <girim@apple.com>
> > Sent: Friday, May 12, 2023 5:55 PM
> > To: devel@edk2.groups.io
> > Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni,
> > Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>
> > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug
> > print is incorrect
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394
> >
> > Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit
> > pointer
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Andrew Fish <afish@apple.com>
> > Signed-off-by: Giri Mudusuru <girim@apple.com>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

> > ---
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > index aab6815328..2e7497a89d 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > @@ -30,7 +30,7 @@ DumpCapabilityReg (
> >    //
> >
> >    // Dump Capability Data
> >
> >    //
> >
> > -  DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot,
> > Capability));
> >
> > +  DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", Slot,
> > *(UINT64 *)Capability));
>
>
> Please help to use %p for printing pointers.
>

Why? The point of this patch is that we are not interested in the
pointer, only in the value that it points to.