From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.11786.1685710139507720430 for ; Fri, 02 Jun 2023 05:48:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=adNyElc8; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0BC165016 for ; Fri, 2 Jun 2023 12:48:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23D11C4339B for ; Fri, 2 Jun 2023 12:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685710138; bh=QkpMwP5Sukt+IHpQuU+XkHhu0Kw+adrwUNrs1BogTzE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=adNyElc8fw06Cn6D3vqBMyFUZWL1H9rpAphR4o1XFc7Gvj8Y1YOnyArWUyL80L6k0 L6yRnQPqUooafe4F5fwVes5MkrmtxoBlEpqkDUCpVqFzH31wsmdg6NZMhdaaly8mDX hvOnrV9I4I/zs6ouuPsaOrUnAFqDH6jbJxL10BH/8kQq+ghL7M8cHy+4zfvsyLLKxQ 7iAt//oDli8EzjBiEofh7wmEgiOn7TQFpV7dcIGh4AxwykxZNyfLnV9GdIlEsOcz0f Y0fnk12kYQTSStC/V5SOZISDPnhAn1Egw6LOM/S645KPmamAcS4VxCHoRmK1ZPPSAs lLcuQUEv1eTXQ== Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2af318fa2b8so26867511fa.0 for ; Fri, 02 Jun 2023 05:48:58 -0700 (PDT) X-Gm-Message-State: AC+VfDyrc2LRY5tCDHfVGO6TRj2hr3PrRI9dgyFLbhBMsBQ6ZA7BlmkR 0bMRby7MpRy6ZKvekq+TaXWwoiBr89C4Lrbz5UQ= X-Google-Smtp-Source: ACHHUZ58za38mw6/I0bhwbbFH3meslIJu762ZNHDxhnIRQuooRyIyyMjlC1oQsCaS92Xv+aKbyzfPIMp7ePvoPb8Xyc= X-Received: by 2002:a05:651c:cb:b0:2a8:eae2:d563 with SMTP id 11-20020a05651c00cb00b002a8eae2d563mr1389655ljr.53.1685710136164; Fri, 02 Jun 2023 05:48:56 -0700 (PDT) MIME-Version: 1.0 References: <20230524004037.39269-1-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230524004037.39269-1-minhnguyen1@os.amperecomputing.com> From: "Ard Biesheuvel" Date: Fri, 2 Jun 2023 14:48:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms][PATCH 0/4] Add support new SMBIOS Tables and refactor to adapt with ArmPkg/SMBIOS To: Minh Nguyen Cc: devel@edk2.groups.io, patches@amperecomputing.com, quic_llindhol@quicinc.com, nhi@os.amperecomputing.com Content-Type: text/plain; charset="UTF-8" On Wed, 24 May 2023 at 02:41, Minh Nguyen wrote: > > These patches helps to add new SMBIOS Tables (Type 16, 17, 19) and refactor SmbiosPlatformDxe. > > Minh Nguyen (4): > JadePkg: Correct PCD names for SMBIOS Type 0 > JadePkg: Leverage ArmPkg/Smbios (Type 0, 1, 2, 3, 13, 32) > JadePkg: Refactor SmbiosPlatformDxe > JadePkg: Add support SMBIOS Table Type 16, 17, 19 > Pushed as 38170a4175a6..6fe5a2309118 I tried to do a build test of Jade.dsc but I got an error related to PcdValueInit. Any idea what is going on here? > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 14 +- > Platform/Ampere/JadePkg/Jade.dsc | 7 +- > Platform/Ampere/JadePkg/Jade.fdf | 1 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 43 +- > Platform/Ampere/JadePkg/Library/OemMiscLib/OemMiscLib.inf | 15 +- > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 201 +++ > Silicon/Ampere/AmpereAltraPkg/Include/Library/AmpereCpuLib.h | 46 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 1553 ++++++-------------- > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxeDataTable.c | 96 ++ > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type08/PlatformPortConnectorData.c | 142 ++ > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type08/PlatformPortConnectorFunction.c | 57 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type09/PlatformSystemSlotData.c | 268 ++++ > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type09/PlatformSystemSlotFunction.c | 58 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type11/PlatformOemStringData.c | 42 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type11/PlatformOemStringFunction.c | 57 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type16/PlatformPhysicalMemoryArrayData.c | 48 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type16/PlatformPhysicalMemoryArrayFunction.c | 44 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type17/PlatformMemoryDeviceData.c | 63 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type17/PlatformMemoryDeviceFunction.c | 475 ++++++ > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type19/PlatformMemoryArrayMappedAddressData.c | 47 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type19/PlatformMemoryArrayMappedAddressFunction.c | 150 ++ > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type24/PlatformHardwareSecurityData.c | 42 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type24/PlatformHardwareSecurityFunction.c | 57 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type38/PlatformIpmiDeviceData.c | 46 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type38/PlatformIpmiDeviceFunction.c | 39 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type41/PlatformOnboardDevicesExtendedData.c | 47 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type41/PlatformOnboardDevicesExtendedFunction.c | 57 + > Platform/Ampere/JadePkg/Library/OemMiscLib/OemMiscLib.c | 246 +++- > Silicon/Ampere/AmpereAltraPkg/Library/AmpereCpuLib/AmpereCpuLibCommon.c | 84 ++ > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxeStrings.uni | 22 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type08/PlatformPortConnector.uni | 22 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type09/PlatformSystemSlot.uni | 20 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type11/PlatformOemString.uni | 11 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type17/PlatformMemoryDevice.uni | 16 + > Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type41/PlatformOnboardDevicesExtended.uni | 10 + > 35 files changed, 3005 insertions(+), 1141 deletions(-) > mode change 100644 => 100755 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxeDataTable.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type08/PlatformPortConnectorData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type08/PlatformPortConnectorFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type09/PlatformSystemSlotData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type09/PlatformSystemSlotFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type11/PlatformOemStringData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type11/PlatformOemStringFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type16/PlatformPhysicalMemoryArrayData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type16/PlatformPhysicalMemoryArrayFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type17/PlatformMemoryDeviceData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type17/PlatformMemoryDeviceFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type19/PlatformMemoryArrayMappedAddressData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type19/PlatformMemoryArrayMappedAddressFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type24/PlatformHardwareSecurityData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type24/PlatformHardwareSecurityFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type38/PlatformIpmiDeviceData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type38/PlatformIpmiDeviceFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type41/PlatformOnboardDevicesExtendedData.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type41/PlatformOnboardDevicesExtendedFunction.c > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxeStrings.uni > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type08/PlatformPortConnector.uni > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type09/PlatformSystemSlot.uni > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type11/PlatformOemString.uni > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type17/PlatformMemoryDevice.uni > create mode 100644 Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/Type41/PlatformOnboardDevicesExtended.uni > > -- > 2.39.0 >