Re: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

["Ard Biesheuvel" <ardb@kernel.org>]

Note that the value in the INF_VERSION field cannot be chosen
arbitrarily - it should be the latest version of the INF spec, so 1.29
(you don't need to put a hex value here, just "1.29" is fine)

On Tue, 17 Jan 2023 at 23:40, Isaac Oram <isaac.w.oram@intel.com> wrote:
>
> Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
>
> Note that you do not need a cover letter for single commit reviews.  It is needed for multi-commit reviews so that you can describe the whole patch series.
>
> -----Original Message-----
> From: Tommy Huang <tommy_huang@aspeedtech.com>
> Sent: Tuesday, January 10, 2023 10:08 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Ryan <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
> Subject: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver
>
> 1. Add ASpeedAst2600GopDxe.inf.
> 2. Add ASpeedAst2600Gop file for AArch64.
> 3. Update the others Gop UEFI binaries into the recently version. The version will be v1.13.02.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> Cc: BMC-SW <BMC-SW@aspeedtech.com>
>
> Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
> ---
>  .../AArch64/ASpeedAst2500Gop.efi              | Bin 42880 -> 45056 bytes
>  .../AArch64/ASpeedAst2600Gop.efi              | Bin 0 -> 45056 bytes
>  .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf   |   4 ++--
>  .../ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf   |  22 ++++++++++++++++++
>  .../ASpeedGopBinPkg/X64/ASpeedAst2500Gop.efi  | Bin 36928 -> 33600 bytes
>  .../ASpeedGopBinPkg/X64/ASpeedAst2600Gop.efi  | Bin 32544 -> 29952 bytes
>  6 files changed, 24 insertions(+), 2 deletions(-)
>  create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2600Gop.efi
>  create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
>