From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.2271.1673997395923009651 for ; Tue, 17 Jan 2023 15:16:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Cz73EFmi; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 316A2B8164A for ; Tue, 17 Jan 2023 23:16:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD6D7C433F1 for ; Tue, 17 Jan 2023 23:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673997392; bh=UfPKod9UMD0F4vOMz+KdZQLRmkuM6nFod0i8+u/QP6Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Cz73EFmiXFoE73gclVavfnZ+p/1tMPZxQgYwiW6sEmpjJMsuEcov2TmoodPxiO7Gk LsmFBdRfn2OdnUAJefgOlZXEEa4XgGocEWW2GrjmfennVSA8BatSmEirKsMHq3ulhu PzH6IpxkfX/Uirsw4Yf0f6jxip0dDPX58JZVC/BYVYmWKrmUJHYZlwmAQLk0HMxJPB q1flXSU7NVvIiqjYMyvbe0G0oUJKjQAimW1x8xQJ9JJ9g+uEr5uqQmJe5wCBVtVH0I Hl48Atzi5GiC4ynAW+es2PkWjdsTUOH3l09lYS/0oaZr6aOsYeFO71AMdpyztP7V3E m3VAuLyEeTIvA== Received: by mail-lf1-f52.google.com with SMTP id bf43so49281276lfb.6 for ; Tue, 17 Jan 2023 15:16:32 -0800 (PST) X-Gm-Message-State: AFqh2kpvAqZs+ODxCfqJlv+W3LH8oHjSoaE9rVXVLrKHaUIyjyC7+ln5 susX+Gf6fwyv6hPqbIM+/nnVXGpZsDlA2pqwmHE= X-Google-Smtp-Source: AMrXdXsjHSZMpmnRdtxXMXktEVgmFgq2gwqUE9by3Pe+B1VM/auXra7lb1qpdotCACaUS7YYIWDePA6ATgoj+FUKe/o= X-Received: by 2002:a05:6512:118a:b0:4cc:9d69:4703 with SMTP id g10-20020a056512118a00b004cc9d694703mr476569lfr.110.1673997390891; Tue, 17 Jan 2023 15:16:30 -0800 (PST) MIME-Version: 1.0 References: <20230111060749.3684623-1-tommy_huang@aspeedtech.com> <20230111060749.3684623-2-tommy_huang@aspeedtech.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 18 Jan 2023 00:16:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver To: devel@edk2.groups.io, isaac.w.oram@intel.com Cc: Tommy Huang , "Desimone, Nathaniel L" , "quic_llindhol@quicinc.com" , "Kinney, Michael D" , "Chen, Ryan" , "BMC-SW@aspeedtech.com" Content-Type: text/plain; charset="UTF-8" Note that the value in the INF_VERSION field cannot be chosen arbitrarily - it should be the latest version of the INF spec, so 1.29 (you don't need to put a hex value here, just "1.29" is fine) On Tue, 17 Jan 2023 at 23:40, Isaac Oram wrote: > > Reviewed-by: Isaac Oram > > Note that you do not need a cover letter for single commit reviews. It is needed for multi-commit reviews so that you can describe the whole patch series. > > -----Original Message----- > From: Tommy Huang > Sent: Tuesday, January 10, 2023 10:08 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Oram, Isaac W ; quic_llindhol@quicinc.com; Kinney, Michael D ; Chen, Ryan ; BMC-SW@aspeedtech.com > Subject: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver > > 1. Add ASpeedAst2600GopDxe.inf. > 2. Add ASpeedAst2600Gop file for AArch64. > 3. Update the others Gop UEFI binaries into the recently version. The version will be v1.13.02. > > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ryan Chen > Cc: BMC-SW > > Signed-off-by: Tommy Huang > --- > .../AArch64/ASpeedAst2500Gop.efi | Bin 42880 -> 45056 bytes > .../AArch64/ASpeedAst2600Gop.efi | Bin 0 -> 45056 bytes > .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++-- > .../ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 22 ++++++++++++++++++ > .../ASpeedGopBinPkg/X64/ASpeedAst2500Gop.efi | Bin 36928 -> 33600 bytes > .../ASpeedGopBinPkg/X64/ASpeedAst2600Gop.efi | Bin 32544 -> 29952 bytes > 6 files changed, 24 insertions(+), 2 deletions(-) > create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2600Gop.efi > create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf >