From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 39D94740046 for ; Wed, 23 Aug 2023 15:12:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=auxLu51dbSa5V7GvwLjAeiexUMdVKMicsu1qkXZmT6E=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692803524; v=1; b=W88GyGzz6xTyJmfmcf3OOkEfFY0XHmg80Myv/t7CRY7a/PVTGNtDaQR3AJzFuF9p+blSwhJF jzZsctB3GqZk1LkANSlfYCFmedpZWdxvpkWCyGkyAiJYLnRjf/0ab29a8Ve9DgnMvRq9M/krArR A3uoPAUYRvNLojY/e3Dj2cnU= X-Received: by 127.0.0.2 with SMTP id M3LEYY7687511xR09msmvmnh; Wed, 23 Aug 2023 08:12:04 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.14133.1692803524342622843 for ; Wed, 23 Aug 2023 08:12:04 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AED6F644B6 for ; Wed, 23 Aug 2023 15:12:03 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAC38C433C8 for ; Wed, 23 Aug 2023 15:12:02 +0000 (UTC) X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-4fe2d152f62so9027196e87.0 for ; Wed, 23 Aug 2023 08:12:02 -0700 (PDT) X-Gm-Message-State: RC74MI9yki5YaBRJlPZTGvq3x7686176AA= X-Google-Smtp-Source: AGHT+IGLRNzm2ojPsm8PT/msSd+MqRIi2Pk3xNPlbmZgZb+Q0GVBX1v78P1aj70XxO5B/OrVeaOPS74Xi2fP+Wxin34= X-Received: by 2002:ac2:4d90:0:b0:4fb:2c1e:4e03 with SMTP id g16-20020ac24d90000000b004fb2c1e4e03mr7807744lfe.32.1692803520843; Wed, 23 Aug 2023 08:12:00 -0700 (PDT) MIME-Version: 1.0 References: <20230720134557.3903923-1-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 23 Aug 2023 17:11:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy To: devel@edk2.groups.io, kraxel@redhat.com Cc: Jiewen Yao , Michael Brown Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=W88GyGzz; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote: > > On Tue, Aug 22, 2023 at 09:57:12AM +0200, Ard Biesheuvel wrote: > > On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote: > > > > > > Looks good to me. > > > > > > What is the status? Merged? Or waiting for testing still? If so I can > > > create a test build with the patch and ask our QE department to check > > > it. > > > > > > > Still waiting for testing, so yes, please test. > > Hmm, QE reports back it slows down the boot alot. No boot hangs yet > with 12 test runs so far, which isn't that much for a reproduce rate > below 20% ... > > https://bugzilla.redhat.com//show_bug.cgi?id=2211060#c28 > > So I guess we go with the TPL version for the coming stable tag and > leave any improvements for later ... > Yeah, this was not going to make the stable tag in any case. The boot speed regression seems odd, though - this is effectively UP code so there shouldn't be any contention, the only thing this patch does is ensure that the critical section is restarted if it was interrupted Are we comparing apples with apples here? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107980): https://edk2.groups.io/g/devel/message/107980 Mute This Topic: https://groups.io/mt/100256049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-