From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B9097941DEB for ; Mon, 18 Dec 2023 21:55:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oz/IatccbSdFY+ZpYAnv5Vn5WLhAZbf+1jILQxdMduM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702936536; v=1; b=dbVknI07qytJQniK/tkyyr9hMn/iJuT9YfStu495OskfHQVjuOCfZQnDgbid9ELLEkc20XfK fMQkDKGUY32SCfom/7YhiP15FPPA8lxIymMBGGYx7/1MWur4WkstPFAeGIgjgw6b1HGJR55x3dd Zjr3UMeOTnkuc0ocUbTfCxWE= X-Received: by 127.0.0.2 with SMTP id S89jYY7687511xhKAjVJdfCs; Mon, 18 Dec 2023 13:55:36 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.3488.1702936535710429241 for ; Mon, 18 Dec 2023 13:55:35 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 37B1B611A3 for ; Mon, 18 Dec 2023 21:55:35 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD3A5C433CC for ; Mon, 18 Dec 2023 21:55:34 +0000 (UTC) X-Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-50e3c6f1c10so1832876e87.1 for ; Mon, 18 Dec 2023 13:55:34 -0800 (PST) X-Gm-Message-State: 3RXpP0q1tuEGfLYVjhBEzW82x7686176AA= X-Google-Smtp-Source: AGHT+IGu8bMIEZd3hxAgbAXQu4TgH2DJRiHsAFzG1204FVWUc8r/4+CtyK4sL6FkCYQahf4+8yS36aRrbQWXe2A2m/M= X-Received: by 2002:a05:6512:792:b0:50e:3822:6d0d with SMTP id x18-20020a056512079200b0050e38226d0dmr517439lfr.93.1702936533001; Mon, 18 Dec 2023 13:55:33 -0800 (PST) MIME-Version: 1.0 References: <20231031173700.647004-1-ngompa@fedoraproject.org> <58ec87dc-ce03-6ad8-681a-d815bc5c39f9@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 18 Dec 2023 22:55:21 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery To: devel@edk2.groups.io, ngompa13@gmail.com, "Liming Gao (Byosoft address)" , Michael Kinney , Leif Lindholm Cc: Laszlo Ersek , Jeremy Linton , Pete Batard , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Gerd Hoffmann , Samer El-Haj-Mahmoud Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dbVknI07; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello all, Same question again. Could we please make some progress on this? Full thread here: https://openfw.io/edk2-devel/20231031173700.647004-1-ngompa@fedoraproject.o= rg/ If nobody objects, I will assume that the change is acceptable and merge it by the end of the week. Thanks, Ard. On Tue, 12 Dec 2023 at 09:11, Ard Biesheuvel wrote: > > (cc Mike, Leif) > > On Thu, 7 Dec 2023 at 08:40, Ard Biesheuvel wrote: > > > > (cc Liming) > > > > On Thu, 7 Dec 2023 at 05:48, Neal Gompa wrote: > > > > > > On Fri, Nov 24, 2023 at 6:36=E2=80=AFPM Neal Gompa wrote: > > > > > > > > On Thu, Nov 2, 2023 at 6:35=E2=80=AFAM Laszlo Ersek wrote: > > > > > > > > > > On 10/31/23 23:27, Jeremy Linton wrote: > > > > > > On 10/31/23 12:37, Neal Gompa via groups.io wrote: > > > > > >> From: Neal Gompa > > > > > >> > > > > > >> Currently, the ReadyToBoot event is only signaled when a forma= l Boot > > > > > >> Manager option is executed (in BmBoot.c -> EfiBootManagerBoot = ()). > > > > > >> > > > > > >> However, the introduction of Platform Recovery in UEFI 2.5 mak= es it > > > > > >> necessary to signal ReadyToBoot when a Platform Recovery boot = loader > > > > > >> runs because otherwise it may lead to the execution of a boot = loader > > > > > >> that has similar requirements to a regular one that is not lau= nched > > > > > >> as a Boot Manager option. > > > > > >> > > > > > >> This is especially critical to ensuring that the graphical con= sole > > > > > >> is actually usable during platform recovery, as some platforms= do > > > > > >> rely on the ConsolePrefDxe driver, which only performs console > > > > > >> initialization after ReadyToBoot is triggered. > > > > > >> > > > > > >> This patch fixes that behavior by calling EfiSignalEventReadyT= oBoot () > > > > > >> in EfiBootManagerProcessLoadOption () when invoking platform r= ecovery, > > > > > >> which is the function that sets up the platform recovery boot = process. > > > > > >> > > > > > >> The expected behavior has been clarified in the UEFI 2.10 spec= ification > > > > > >> to explicitly indicate this behavior is required for correct o= peration. > > > > > >> > > > > > >> This is a rebased version of the patch originally written by P= ete Batard. > > > > > > > > > > > > Took me a bit to swap in that whole conversation again, and rec= heck the > > > > > > spec's and code paths, but this all looks fine to me and should= allow > > > > > > the PFTF build to drop the similar patch from Pete that has bee= n carried > > > > > > downstream for the past couple years. > > > > > > > > > > > > As for testing the previous patch has been in the field for a c= ouple > > > > > > years now and i'm not aware of it causing any issues. The addit= ional > > > > > > restriction of limiting it to platform recovery logically makes= sense, > > > > > > and as far as I can see shouldn't cause any problems. > > > > > > > > > > > > So, > > > > > > > > > > > > Reviewed-by: Jeremy Linton > > > > > > > > > > > > > > > > > > As a PS: I also went to check the ready to boot behavior for Os= Recovery > > > > > > and realized that apparently none of that support was ever merg= ed? > > > > > > > > > > What else is there, outside of this patch, in need of upstreaming= ? > > > > > > > > > > > That seems a bit of an oversight since its been in the spec for= a few years now. > > > > > > > > > > "ready-to-boot for OsRecovery" is new in UEFI 2.10 (according to = the > > > > > commit message), which is quite recent ("Aug 29, 2022"). > > > > > > > > > > I couldn't find the Mantis ticket in the Revision History (for 2.= 10) though. > > > > > > > > > > > > > Is there anything else holding up committing this patch? Jeremy and > > > > you reviewed it earlier in the month... > > > > > > > > > > Friendly ping again? It's been a month now... > > > > > > > Apologies for the delay - Liming, can we progress with this? > > Can we please make some progress with this? This has been in limbo for > far too long. > > Thanks, -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112653): https://edk2.groups.io/g/devel/message/112653 Mute This Topic: https://groups.io/mt/102302654/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-