From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 44CF2941328 for ; Fri, 19 Jan 2024 07:53:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UMC7cQNEHj9j3DOCXaaJd/Xo2KPyZMChqMSkxyO+hsQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705650787; v=1; b=p9XUJgHkxar0tDvnVOvovacJVcP/NpGXcIIHCoEnTgCBdy9bnDSBptQa/cd7fMBrGris2Mjx q2V77dax3cGej44JzM1VlBl9mUPdHK4XyolgGO9UYUGISlZdiTefmbyuJK5HwWQiRR3xj+p0CGW 86KIQ+der7x/Ae1t/kVK0mC0= X-Received: by 127.0.0.2 with SMTP id cyByYY7687511xLM6hyd4MyW; Thu, 18 Jan 2024 23:53:07 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.17013.1705650787053447391 for ; Thu, 18 Jan 2024 23:53:07 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8F0AE61901 for ; Fri, 19 Jan 2024 07:53:06 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CF82C433F1 for ; Fri, 19 Jan 2024 07:53:06 +0000 (UTC) X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50eaa8b447bso549723e87.1 for ; Thu, 18 Jan 2024 23:53:06 -0800 (PST) X-Gm-Message-State: gjFXtaOYWZd7LjDIr6KKueiyx7686176AA= X-Google-Smtp-Source: AGHT+IGiN77cf6/sPr6JTV/U2mr9nKjajREpy2tg0Q8GyDlmfwlD2zRCuthBn2fpW1pPXriCtADJd3xQsnyL0gUtUYA= X-Received: by 2002:a19:8c05:0:b0:50e:abbc:3b25 with SMTP id o5-20020a198c05000000b0050eabbc3b25mr222093lfd.247.1705650784339; Thu, 18 Jan 2024 23:53:04 -0800 (PST) MIME-Version: 1.0 References: <20240116171105.37831-1-kraxel@redhat.com> <0e75f505-063f-171a-676e-59c6fcc56c6c@redhat.com> In-Reply-To: <0e75f505-063f-171a-676e-59c6fcc56c6c@redhat.com> From: "Ard Biesheuvel" Date: Fri, 19 Jan 2024 08:52:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 0/6] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements To: devel@edk2.groups.io, lersek@redhat.com Cc: kraxel@redhat.com, oliver@redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=p9XUJgHk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 18 Jan 2024 at 21:28, Laszlo Ersek wrote: > > On 1/16/24 18:10, Gerd Hoffmann wrote: > > This is a little series containing the flash corruption fix sent > > yesterday with an slightly improved commit message and some small > > improvements on top of this. > > > > v3: > > - fix diagram > > - fix DoErase control flow > > - pick up reviewed-by tags > > v2: > > - drop broken bugfix, fix the bug when introducing Start+End variables > > instead. > > - add patch with UINTN and UINT32 casts. > > - add patch splitting the DoErase code path into a new function. > > - add the diagram sent by Laszlo. > > > > Gerd Hoffmann (6): > > OvmfPkg/VirtNorFlashDxe: add casts to UINTN and UINT32 > > OvmfPkg/VirtNorFlashDxe: clarify block write logic & fix shadowbuffer > > reads > > OvmfPkg/VirtNorFlashDxe: add a loop for NorFlashWriteBuffer calls. > > OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase > > OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too > > OvmfPkg/VirtNorFlashDxe: move DoErase code block into new function > > > > OvmfPkg/VirtNorFlashDxe/VirtNorFlash.h | 2 +- > > OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 145 ++++++++++++++-------- > > OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c | 5 + > > 3 files changed, 101 insertions(+), 51 deletions(-) > > > > Merged as commit range 59f024c76ee5..b481b00f593e, via > . > Much appreciated! Thanks to the both of you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114029): https://edk2.groups.io/g/devel/message/114029 Mute This Topic: https://groups.io/mt/103766773/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-