From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EF548941589 for ; Wed, 18 Oct 2023 08:57:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=y+VCo71HW+P3G+Nv3X/Xc3E7XKDzn5Zzj/oXe6AJ5eU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1697619473; v=1; b=I0URSDu2uaNSmwJGkiYoQ281DSReKE5jn6U86AQ8CcLLJyJ5w+vIVMAPrzNZvdWQVoPDUdhk Bm+j8CyP6d+Q30U7dpdSfRH2hJ87geBy0EGaCdADu38TchzZDkm1tOMSJJseMw2iMAywxxcTRqX JEY3TEipleH07NtCXin2oXj8= X-Received: by 127.0.0.2 with SMTP id rxyVYY7687511xfbQeGRXdZ3; Wed, 18 Oct 2023 01:57:53 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web10.277570.1697619472232305079 for ; Wed, 18 Oct 2023 01:57:52 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6012FCE23F5 for ; Wed, 18 Oct 2023 08:57:49 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54D1EC433D9 for ; Wed, 18 Oct 2023 08:57:48 +0000 (UTC) X-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2b9338e4695so88285791fa.2 for ; Wed, 18 Oct 2023 01:57:48 -0700 (PDT) X-Gm-Message-State: xDv0vPHQ5T817PfMUJvzslnFx7686176AA= X-Google-Smtp-Source: AGHT+IHMi45T/DP9aWN+1kIKzeo5WU4BtJZ8tQUT4a11lLs/qJ41P8mYeNEeE08MUmzERoWnJVFBmRrzWO/aiIuP1I8= X-Received: by 2002:a2e:a7ca:0:b0:2c5:1ea4:4e99 with SMTP id x10-20020a2ea7ca000000b002c51ea44e99mr4310071ljp.48.1697619466560; Wed, 18 Oct 2023 01:57:46 -0700 (PDT) MIME-Version: 1.0 References: <20230929020222.2010-1-yuinyee.chew@starfivetech.com> <4487065a-ac8f-4a73-a3e5-b7069df9e7d3@canonical.com> <7844b7331b5f42019dfdf3fc706671c0@EXMBX073.cuchost.com> <82caabf5e259418487d56236a817de42@EXMBX073.cuchost.com> In-Reply-To: <82caabf5e259418487d56236a817de42@EXMBX073.cuchost.com> From: "Ard Biesheuvel" Date: Wed, 18 Oct 2023 10:57:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list To: YuinYee Chew Cc: "devel@edk2.groups.io" , Sunil V L , Li Yong , Heinrich Schuchardt , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I0URSDu2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 18 Oct 2023 at 10:49, YuinYee Chew wrote: > > Dear Maintainers, > > Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help. > Thanks for the reminder. I don't have time to review this myself but I'm happy to merge it if someone else reviews it > > -----Original Message----- > From: YuinYee Chew > Sent: Friday, September 29, 2023 9:35 PM > To: 'Heinrich Schuchardt' > Cc: Sunil V L ; Li Yong ; Leif Lindholm ; Ard Biesheuvel ; Abner Chang ; Daniel Schaefer ; devel@edk2.groups.io > Subject: RE: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list > > Hi Heinrich, > > Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}" > gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128d.html > gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128e > So, I'm thinking to put it as "gd25lq128" to represent both "d" and "e". > If sync with Linux, gd25lq128d will be better. > > Do you have any suggestion on this? > Or anyone have any opinion? > > Thanks again for the feedback! =) > > -----Original Message----- > From: Heinrich Schuchardt > Sent: Friday, September 29, 2023 4:55 PM > To: YuinYee Chew > Cc: Sunil V L ; Li Yong ; Leif Lindholm ; Ard Biesheuvel ; Abner Chang ; Daniel Schaefer ; devel@edk2.groups.io > Subject: Re: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list > > On 9/29/23 04:02, John Chew wrote: > > Update Gigadevice norflash list: > > gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256 > > > > Add Silicon Kaiser norflash list: > > sk25lp128 > > > > Cc: Sunil V L > > Cc: Li Yong > > Cc: Heinrich Schuchardt > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Abner Chang > > Cc: Daniel Schaefer > > Signed-off-by: John Chew > > --- > > EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > > b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > > index e16c1c6a14..422fdac851 100644 > > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c > > @@ -1,6 +1,7 @@ > > /** @file > > * > > * Copyright (c) 2017 Marvell International Ltd. > > +* Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights > > +reserved.
> > * > > * SPDX-License-Identifier: BSD-2-Clause-Patent > > * > > @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] = { > > { L"en25q128b", { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024, 256, 0 }, > > { L"en25s64", { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024, 128, 0 }, > > /* GIGADEVICE */ > > - { L"gd25q64b", { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024, 128, NOR_FLASH_ERASE_4K }, > > + { L"gd25q16", { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024, 32, NOR_FLASH_ERASE_4K }, > > + { L"gd25q32", { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024, 64, NOR_FLASH_ERASE_4K }, > > { L"gd25lq32", { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024, 64, NOR_FLASH_ERASE_4K }, > > + { L"gd25q64b", { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024, 128, NOR_FLASH_ERASE_4K }, > > Linux calls this gd25q64 but probably we don't want to change the displayed name. > > > + { L"gd25lq64c", { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024, 128, NOR_FLASH_ERASE_4K }, > > + { L"gd25q128", { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024, 256, NOR_FLASH_ERASE_4K }, > > + { L"gd25lq128", { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024, 256, NOR_FLASH_ERASE_4K }, > > Linux calls this gd25lq128d. > > > + { L"gd25q256", { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024, 512, NOR_FLASH_ERASE_4K }, > > Except for the two labels the changes match drivers/mtd/spi-nor/gigadevice.c in Linux. > > > /* ISSI */ > > { L"is25lp032", { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024, 64, 0 }, > > { L"is25lp064", { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024, 128, 0 }, > > { L"is25lp128", { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024, 256, 0 }, > > + /* XINKAI / SILICON KAISER */ > > + { L"sk25lp128", { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024, 256, NOR_FLASH_ERASE_4K }, > > This matches > https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/ > > Acked-by: Heinrich Schuchardt > > > > /* MACRONIX */ > > { L"mx25l2006e", { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024, 4, 0 }, > > { L"mx25l4005", { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024, 8, 0 }, > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109717): https://edk2.groups.io/g/devel/message/109717 Mute This Topic: https://groups.io/mt/101660590/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-