From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web12.8121.1628080007339985871 for ; Wed, 04 Aug 2021 05:26:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t7K7lkvO; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id D7C2460F22 for ; Wed, 4 Aug 2021 12:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628080006; bh=Paifcv3SXzhaRJNd0lCk3mjhoe06+clNIlzlJKY5vmE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=t7K7lkvOhDGkWImS6lGtxu9odm5XQKTNzonkVePHk9ttp7adcEG1sX4gA/pydrJy6 Zn7aa/R4C4m3YdYQ7DNXxYVj3puFlYvG+aMUdr6U1HSkQ3n/v123GTiI6R9j2c6w7E zKxBytEX2BIlBzMU/Jt1YHFM3L/StHVM9jbhtoHKg4dtFZ9OiHMeBcPtZVpQJx6vDk 6P3HbOqs1AYP7i/J2XC5qLofyVKSjzBw4/Oh4L/vyqbcRRmOKKBNZQY1Zf7LAi8Z09 133LSWO1bcbwQ2kIlDpm0O2r02WnEMfcVLZHanwiwqblfMCsFAaqhOyRmipVwkOh/f 45huPUo5RKAxA== Received: by mail-ot1-f54.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so1443108oth.7 for ; Wed, 04 Aug 2021 05:26:46 -0700 (PDT) X-Gm-Message-State: AOAM530AppMpOjMW8TWM+bGrnwPe+YzFnABYRVaaETbFU9fVdoWg8LbE PFkI4dfHCcES8uZHy5m+wsRTf/lW1Rrvb+DnhqQ= X-Google-Smtp-Source: ABdhPJwBCweB3yquSTMA0ZfDL2qvN8Bgr85eq57MMbIWUjSqE7gKbyePk2QX4P1IMOesPk1BLh0pzfQdTTDahNT7LYg= X-Received: by 2002:a05:6830:34a6:: with SMTP id c38mr18416325otu.108.1628080006268; Wed, 04 Aug 2021 05:26:46 -0700 (PDT) MIME-Version: 1.0 References: <20210720220646.659-1-christopher.zurcher@outlook.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 4 Aug 2021 14:26:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list To: "Yao, Jiewen" Cc: "devel@edk2.groups.io" , "christopher.zurcher@outlook.com" , "Feng, Bob C" , Liming Gao Content-Type: text/plain; charset="UTF-8" On Wed, 21 Jul 2021 at 13:44, Yao, Jiewen wrote: > > Acked-by: Jiewen Yao > I don't think this is a good idea tbh. We have already identified that EDK2 code often fails to use the STATIC keyword when possible for global variables, and that unrelated variables that happen to have the same name will be collapsed into the same storage unit in the program image. (see commit 214a3b79417f64bf2faae74af42c1b9d23f50dc8 for details) Was this considered? Is this no longer an issue? > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Christopher > > Zurcher > > Sent: Wednesday, July 21, 2021 6:07 AM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel ; Feng, Bob C ; > > Liming Gao > > Subject: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section > > from the GCC discard list > > > > From: Christopher Zurcher > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 > > > > The COMMON section is used by OpenSSL assembly-optimized crypto > > functions. OpenSSL assembly code is auto-generated from the submodule > > and cannot be modified to remove dependence on the COMMON section. > > The default -fno-common compiler flag should still prevent variable from > > being emitted into the COMMON section. > > > > Cc: Ard Biesheuvel > > Cc: Bob Feng > > Cc: Liming Gao > > Signed-off-by: Christopher Zurcher > > --- > > BaseTools/Scripts/GccBase.lds | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/BaseTools/Scripts/GccBase.lds b/BaseTools/Scripts/GccBase.lds > > index a9dd2138d4..83cebd29d5 100644 > > --- a/BaseTools/Scripts/GccBase.lds > > +++ b/BaseTools/Scripts/GccBase.lds > > @@ -74,6 +74,5 @@ SECTIONS { > > *(.dynamic) > > *(.hash .gnu.hash) > > *(.comment) > > - *(COMMON) > > } > > } > > -- > > 2.32.0.windows.1 > > > > > > > > > > >