From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web09.18972.1613904639334677518
 for <devel@edk2.groups.io>;
 Sun, 21 Feb 2021 02:50:39 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l0ecov3w;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B0D8961606
	for <devel@edk2.groups.io>; Sun, 21 Feb 2021 10:50:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1613904638;
	bh=pEsVAwZUDYWOLJ9IXg3EbQRuiOPnUJaKvVBX2Ergd1o=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=l0ecov3wLtyVQ2sXPi4+QJP9INJ4TuPyl7V1p/FthOwjC+vgE1TZR89AUlghxKgam
	 cVWm65srXVbAMpiWO8sQ9vRGK6+mvQvxd4W8l1e5g5Ah7hHk5qtu42GCiyLsB/PaSc
	 1azZ8mdwUX8Ifrma9IAO5aZyXfxJOCTc0U4Cs5gBB/O40rIVX6HS/B5GpBbE3O6n6P
	 Xgb0Hh3kOf6pQCI7kKXKJMF+J7LhUBrcKWpK1tpseowh+fSIf5ziZsVfKXJ/XG+CW/
	 bTnS6tXhYbVGDJhSjSTaOyyb2fx+uNuZbvRIMbqsi78Wt+/ucDOdm5QVIIAphRkD/t
	 +vDbsUnVJy9Bg==
Received: by mail-oo1-f45.google.com with SMTP id z36so2320341ooi.6
        for <devel@edk2.groups.io>; Sun, 21 Feb 2021 02:50:38 -0800 (PST)
X-Gm-Message-State: AOAM530GyMYRoaVcHY7DDQPJDqEP+oODDL3FYw9Ut6K82xGPfkIoMdnV
	CKfQ+JDzJiAzkwwtiD1pSkTj4oNsdWwV3oAJ4Y8=
X-Google-Smtp-Source: ABdhPJzniEDwQbdumfnfUHcIweuLVsl5Yf38BgnXEQ8hiQeKI2JGOyPHqu5zUbqOR0iLeXZJZKn1AfRFyohwB40fdp0=
X-Received: by 2002:a4a:e0d3:: with SMTP id e19mr12807732oot.45.1613904638073;
 Sun, 21 Feb 2021 02:50:38 -0800 (PST)
MIME-Version: 1.0
References: <20210220164133.21746-1-Samer.El-Haj-Mahmoud@arm.com>
 <CAMj1kXFxhke1zxt8VPyxCCFerf658y08W3yuj_2WcYHRBe3WrA@mail.gmail.com> <20210220214614.GL1664@vanye>
In-Reply-To: <20210220214614.GL1664@vanye>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Sun, 21 Feb 2021 11:50:27 +0100
X-Gmail-Original-Message-ID: <CAMj1kXFi3nTVsP-kB+pivS9J7o_GmfKFqMe=fGdx6ufnVvrT3w@mail.gmail.com>
Message-ID: <CAMj1kXFi3nTVsP-kB+pivS9J7o_GmfKFqMe=fGdx6ufnVvrT3w@mail.gmail.com>
Subject: Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
To: Leif Lindholm <leif@nuviainc.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, devel@edk2.groups.io, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Pete Batard <pete@akeo.ie>
Content-Type: text/plain; charset="UTF-8"

On Sat, 20 Feb 2021 at 22:46, Leif Lindholm <leif@nuviainc.com> wrote:
>
> *How* annoying was this?
>
> This is kind of useful information, well at the "would be good to see
> in a regular DEBUG build" level.
>
> This change will have suddenly effectively hidden a message that was
> already present in many platforms, where they were not (very) annoyingly
> repetitive during a normal boot.
>
> It feels the test suite is not the thing that we need to optimise
> debug output for.
>
> Is there some alternative way we can rate limit this?
>

Given that the sole purpose of this library is to paper over the fact
that the platform violates the spec, and lacks the ability to tell
time, I think it makes little sense to obsess over how wrong the value
is that it returns.