From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.33676.1620661792257115227 for ; Mon, 10 May 2021 08:49:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u8Kka3PL; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5D3F261409 for ; Mon, 10 May 2021 15:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620661791; bh=l/ECndSAMwzmwMgDOan/cAl0IOcjsorVew05WtpER/0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u8Kka3PL4OTju5mU4BXfUmDblQMo1ZfNxcYVIhLPnj5H4wFJ2LY5TZypoQ0aVyXgm 2e+L/Yen4zDytZoUwSZEd18ZifIh326rYmG2fwDX+LRJ5AtTAxxQ0fEBVpQC6OkMsS LpL9Rwm+iEbIJCa4n4xWCUE64IKuk0G/pxhgFBp1DPSKfIYp1ehdayF/lG/zepysFr 82VGIXsBid9yKB3bsy7u1Fk8yPNvfBVl6P8yDVyT95s90UacTWNR+x8Gjj+XSjiBGY yhhI+J8AuRLEn+jCmBGZDFcyUoj7RGhPqjBgP1Rubwn6lMSK7uqjvdU9XehqcE+9Oj gYYnUmtUUbyWg== Received: by mail-ot1-f41.google.com with SMTP id u25-20020a0568302319b02902ac3d54c25eso14861036ote.1 for ; Mon, 10 May 2021 08:49:51 -0700 (PDT) X-Gm-Message-State: AOAM531Ccy/1pxSU7KHaLhoqLsUIPQep7ZGccDMjvJG0yH9XAABhixAA kFdvQ0b07IKyFeRJlM9lruMWr+fdZ9mXj4zEm04= X-Google-Smtp-Source: ABdhPJyf5CqoRJoByMFqZLVwJntuymQv+Xc9wf6j60mqnX4cox9ryKFbsQ0xQAprGi/GAmbtLHMRkqJ8ncdEmCf3VX4= X-Received: by 2002:a9d:7cd8:: with SMTP id r24mr9902969otn.90.1620661790656; Mon, 10 May 2021 08:49:50 -0700 (PDT) MIME-Version: 1.0 References: <20210510082616.21372-1-Pierre.Gondois@arm.com> <0ED7020F-D451-4632-9DFE-175CE8D70A0B@arm.com> In-Reply-To: <0ED7020F-D451-4632-9DFE-175CE8D70A0B@arm.com> From: "Ard Biesheuvel" Date: Mon, 10 May 2021 17:49:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RESEND v1 1/1] ArmPkg: Update SCMI Base Protocol version to 0x20000 To: Sami Mujawar Cc: Pierre Gondois , "devel@edk2.groups.io" , "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Nicola Mazzucato Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 10 May 2021 at 10:51, Sami Mujawar wrote: > > Hi All, > > I have tested this patch on Juno R2. > > Tested-by: Sami Mujawar > Reviewed-by: Sami Mujawar > Merged as #1630 Thanks all. > > =EF=BB=BFOn 10/05/2021, 09:26, "Pierre.Gondois@arm.com" wrote: > > From: Nicola Mazzucato > > The SCP-firmware has moved to full support for SCMIv2 which means tha= t > the base protocol can be either compliant with SCMI v1 or v2. > > Allow any version between SCMI v1.0 and SCMI v2.0 to be compatible > with the current implementation. > > Signed-off-by: Nicola Mazzucato > Signed-off-by: Pierre Gondois > --- > The changes can be seen at: https://github.com/PierreARM/edk2/tree/17= 32_Update_SCMI_version_v1 > > ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 10 ++++++---- > ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h | 10 +++++----- > 2 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c b/ArmPkg/Drivers/Arm= ScmiDxe/ScmiDxe.c > index d5890a7633a2..fb4e79aa3610 100644 > --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c > +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c > @@ -4,9 +4,9 @@ > > SPDX-License-Identifier: BSD-2-Clause-Patent > > - System Control and Management Interface V1.0 > - http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/ > - DEN0056A_System_Control_and_Management_Interface.pdf > + @par Specification Reference: > + - Arm System Control and Management Interface - Platform Design Do= cument > + (https://developer.arm.com/documentation/den0056/) > **/ > > #include > @@ -86,7 +86,9 @@ ArmScmiDxeEntryPoint ( > return Status; > } > > - if (Version !=3D BASE_PROTOCOL_VERSION) { > + // Accept any version between SCMI v1.0 and SCMI v2.0 > + if ((Version < BASE_PROTOCOL_VERSION_V1) || > + (Version > BASE_PROTOCOL_VERSION_V2)) { > ASSERT (FALSE); > return EFI_UNSUPPORTED; > } > diff --git a/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h b/ArmPkg/I= nclude/Protocol/ArmScmiBaseProtocol.h > index 73ad3e32a2f5..c4b81c0f56d3 100644 > --- a/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h > +++ b/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h > @@ -4,9 +4,9 @@ > > SPDX-License-Identifier: BSD-2-Clause-Patent > > - System Control and Management Interface V1.0 > - http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/ > - DEN0056A_System_Control_and_Management_Interface.pdf > + @par Specification Reference: > + - Arm System Control and Management Interface - Platform Design Do= cument > + (https://developer.arm.com/documentation/den0056/) > **/ > > #ifndef ARM_SCMI_BASE_PROTOCOL_H_ > @@ -14,7 +14,8 @@ > > #include > > -#define BASE_PROTOCOL_VERSION 0x10000 > +#define BASE_PROTOCOL_VERSION_V1 0x10000 > +#define BASE_PROTOCOL_VERSION_V2 0x20000 > > #define NUM_PROTOCOL_MASK 0xFFU > #define NUM_AGENT_MASK 0xFFU > @@ -165,4 +166,3 @@ typedef enum { > } SCMI_MESSAGE_ID_BASE; > > #endif /* ARM_SCMI_BASE_PROTOCOL_H_ */ > - > -- > 2.17.1 > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you.