From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.45987.1674489924247355817 for ; Mon, 23 Jan 2023 08:05:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PptuORMn; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B0B260F89 for ; Mon, 23 Jan 2023 16:05:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2171DC433D2 for ; Mon, 23 Jan 2023 16:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674489923; bh=DT0vQ592QLvXo06eXRQOASWRMrkAuJgCb++MVP3pQkg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PptuORMnG+axSh3005sSGHwtsMCAguZY2KYSLaSQI3e1+gBm4kMcM/PHu79CdiFBg 8mPNQkoEOc6j/9ajVL1HtIhXE/rH/MlOnn/Pu+bLbOPgfQpNygZ/Corrvazw9TofPW 64r81TDndCaiyUzh980LRiUeEexmsyWKBxYMyS2CdcnVeWsj8t3pfjPG2OplhJNONq dey5bMz4ZXa13MGjtEahmKvgQhiDk3kfZNQOsbSJCCCRBZXyxGCeaAB77scOqmj2hQ Y3xiOW1WUcknHqjrlEuD6Mv/mLYhTxks0uPHrjJyYefRODfWD6n2jgf5Ry0zJEsMzk Pqk8OgcyZipIg== Received: by mail-lf1-f41.google.com with SMTP id d30so18889057lfv.8 for ; Mon, 23 Jan 2023 08:05:22 -0800 (PST) X-Gm-Message-State: AFqh2koqGEprzoiRVMRMK+kr0KjI4wijuyC9TVWP7Vz8p5gJU2dY9w4f I4JxX+shZg9AAoKE6Wjl2MPCjlhnuucixlsMLlU= X-Google-Smtp-Source: AMrXdXv1phoOuncTMZJaqxKJoNGZ+o/Ir0dZ7v8IkknKdvA1M4+7GCG9hNHtCCYtBCMa1wvfH1NzbKHFk/WA7Fywb9k= X-Received: by 2002:a19:c501:0:b0:4b8:9001:a694 with SMTP id w1-20020a19c501000000b004b89001a694mr1197818lfe.426.1674489921054; Mon, 23 Jan 2023 08:05:21 -0800 (PST) MIME-Version: 1.0 References: <173AEF7243293292.25137@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 23 Jan 2023 17:05:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size To: "Milosek, Damian" Cc: "devel@edk2.groups.io" , "sami.mujawar@arm.com" , "Yao, Jiewen" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 23 Jan 2023 at 16:51, Milosek, Damian wr= ote: > > > > > > From: devel@edk2.groups.io On Behalf Of Milosek, D= amian > Sent: Monday, January 16, 2023 2:51 PM > To: devel@edk2.groups.io > Cc: Milosek, Damian > Subject: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update = AARCH64 address size > > > > Enable StandaloneMmMemLib to use longer physical addresses than 36 bits. > What is the purpose of this change? > According to ARM "Learn the architecture - AArch64 memory management" > > since Armv8.2-A physical address size was extended to 52 bits. > > https://developer.arm.com/documentation/101811/0102/Address-spaces > This is an optional extension. Which hardware are you using that implements this extension? > > > Signed-off-by: Damian Milosek > > --- > > .../StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMe= mLibInternal.c b/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMm= MemLibInternal.c > > index 297cfae916..dff3e0145f 100644 > > --- a/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInt= ernal.c > > +++ b/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInt= ernal.c > > @@ -6,7 +6,7 @@ > > all MMRAM range via MM_ACCESS_PROTOCOL, including the range for firmwa= re (like MM Core > > and MM driver) and/or specific dedicated hardware. > > > > - Copyright (c) 2015, Intel Corporation. All rights reserved.
> > + Copyright (c) 2015 - 2023, Intel Corporation. All rights reserved.
> > Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -21,7 +21,7 @@ > > extern EFI_PHYSICAL_ADDRESS mMmMemLibInternalMaximumSupportAddress; > > > > #ifdef MDE_CPU_AARCH64 > > -#define ARM_PHYSICAL_ADDRESS_BITS 36 > > +#define ARM_PHYSICAL_ADDRESS_BITS 52 > > #endif > > #ifdef MDE_CPU_ARM > > #define ARM_PHYSICAL_ADDRESS_BITS 32 > > -- > > 2.37.2.windows.2 > > ________________________________ > > Intel Technology Poland sp. z o.o. > ul. S=C5=82owackiego 173 | 80-298 Gda=C5=84sk | S=C4=85d Rejonowy Gda=C5= =84sk P=C3=B3=C5=82noc | VII Wydzia=C5=82 Gospodarczy Krajowego Rejestru S= =C4=85dowego - KRS 101882 | NIP 957-07-52-316 | Kapita=C5=82 zak=C5=82adowy= 200.000 PLN. > Sp=C3=B3=C5=82ka o=C5=9Bwiadcza, =C5=BCe posiada status du=C5=BCego przed= si=C4=99biorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzia=C5= =82aniu nadmiernym op=C3=B3=C5=BAnieniom w transakcjach handlowych. > > Ta wiadomo=C5=9B=C4=87 wraz z za=C5=82=C4=85cznikami jest przeznaczona dl= a okre=C5=9Blonego adresata i mo=C5=BCe zawiera=C4=87 informacje poufne. W = razie przypadkowego otrzymania tej wiadomo=C5=9Bci, prosimy o powiadomienie= nadawcy oraz trwa=C5=82e jej usuni=C4=99cie; jakiekolwiek przegl=C4=85dani= e lub rozpowszechnianie jest zabronione. > This e-mail and any attachments may contain confidential material for the= sole use of the intended recipient(s). If you are not the intended recipie= nt, please contact the sender and delete all copies; any review or distribu= tion by others is strictly prohibited. > > > >=20 > > ________________________________ > Intel Technology Poland sp. z o.o. > ul. S=C5=82owackiego 173 | 80-298 Gda=C5=84sk | S=C4=85d Rejonowy Gda=C5= =84sk P=C3=B3=C5=82noc | VII Wydzia=C5=82 Gospodarczy Krajowego Rejestru S= =C4=85dowego - KRS 101882 | NIP 957-07-52-316 | Kapita=C5=82 zak=C5=82adowy= 200.000 PLN. > Sp=C3=B3=C5=82ka o=C5=9Bwiadcza, =C5=BCe posiada status du=C5=BCego przed= si=C4=99biorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzia=C5= =82aniu nadmiernym op=C3=B3=C5=BAnieniom w transakcjach handlowych. > > Ta wiadomo=C5=9B=C4=87 wraz z za=C5=82=C4=85cznikami jest przeznaczona dl= a okre=C5=9Blonego adresata i mo=C5=BCe zawiera=C4=87 informacje poufne. W = razie przypadkowego otrzymania tej wiadomo=C5=9Bci, prosimy o powiadomienie= nadawcy oraz trwa=C5=82e jej usuni=C4=99cie; jakiekolwiek przegl=C4=85dani= e lub rozpowszechnianie jest zabronione. > This e-mail and any attachments may contain confidential material for the= sole use of the intended recipient(s). If you are not the intended recipie= nt, please contact the sender and delete all copies; any review or distribu= tion by others is strictly prohibited.