From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.3463.1631951715375999839 for ; Sat, 18 Sep 2021 00:55:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kz+V7rdX; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 96C2D61260 for ; Sat, 18 Sep 2021 07:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631951714; bh=jxyC4Qo7FtEQgI+gyHnNgXFC8iO6bef+cQGzIaAtAgw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kz+V7rdX1sSf/pQcQar1Z9k8U1SnDCOUdBKvChh1iytoVpdAshB6egY/XGIvIs8X2 2ORmbhUvDUyXHQRQrTFvTStWjh+NMHTM/pY1fzfYm34QB2JcM9Y/LLgU17IglryN/Z l26yG7DIkKAubp1Jdb/Y7K/MgZBlmDpNX8cvlypqLaRIFRZAHeC8WHiS7/aDo/1p7d el9yPehwGXFJZJOsX9UmEJQ8dZJ6U2DnbElYkeCmdFL03xuMsObqxzoc/GbCEik25V 8Iqp6/ZPatiwBLan7R8p8D7tLdRYpjaPAdJ9cJf5SvIkRaiffu37Zet5EN6EHLeI1B 5s90q4r1dOlbQ== Received: by mail-ot1-f46.google.com with SMTP id 77-20020a9d0ed3000000b00546e10e6699so5004693otj.2 for ; Sat, 18 Sep 2021 00:55:14 -0700 (PDT) X-Gm-Message-State: AOAM533O8QsTigVmhJbDcaA8PU0aPAvah/aMPdRL91OiD5cYSGIfZEIG yFYHfd8Q5Ai4EfvcDhlAVe/u3qzWgLIN4u+eeHs= X-Google-Smtp-Source: ABdhPJxE4pfUgB+Fd0COfWjyjhH98D8jTGgzXi/NkTRR54zKucglTIv+VSRJsuqB5/W6Zkwwhs5PZHzo1Ku/CQqnp/E= X-Received: by 2002:a9d:200b:: with SMTP id n11mr12830101ota.30.1631951713894; Sat, 18 Sep 2021 00:55:13 -0700 (PDT) MIME-Version: 1.0 References: <20210916211752.2714332-1-stefanb@linux.ibm.com> <20210916211752.2714332-2-stefanb@linux.ibm.com> In-Reply-To: <20210916211752.2714332-2-stefanb@linux.ibm.com> From: "Ard Biesheuvel" Date: Sat, 18 Sep 2021 09:55:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC PATCH 1/3] ArmVirtPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib To: edk2-devel-groups-io , Stefan Berger Cc: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Gerd Hoffmann , Jiewen Yao , Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Stefan Berger Content-Type: text/plain; charset="UTF-8" On Thu, 16 Sept 2021 at 23:18, Stefan Berger wrote: > > From: Stefan Berger > > Add a NULL implementation of the library class TpmPlatformHierarchyLib. > This patch introduces both the library class and the NULL implementation, right? > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Signed-off-by: Stefan Berger > --- > ArmVirtPkg/ArmVirtPkg.dec | 1 + > .../Include/Library/TpmPlatformHierarchyLib.h | 27 +++++++++++++++++ > .../PeiDxeTpmPlatformHierarchyLib.c | 22 ++++++++++++++ > .../PeiDxeTpmPlatformHierarchyLib.inf | 30 +++++++++++++++++++ > 4 files changed, 80 insertions(+) > create mode 100644 ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h > create mode 100644 ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c > create mode 100644 ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf > > diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec > index 4e4d758015..f3bdca118b 100644 > --- a/ArmVirtPkg/ArmVirtPkg.dec > +++ b/ArmVirtPkg/ArmVirtPkg.dec > @@ -27,6 +27,7 @@ > > [LibraryClasses] > ArmVirtMemInfoLib|Include/Library/ArmVirtMemInfoLib.h > + TpmPlatformHierarchyLib|Include/Library/TpmPlatformHierarchyLib.h > > [Guids.common] > gArmVirtTokenSpaceGuid = { 0x0B6F5CA7, 0x4F53, 0x445A, { 0xB7, 0x6E, 0x2E, 0x36, 0x5B, 0x80, 0x63, 0x66 } } > diff --git a/ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h b/ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h > new file mode 100644 > index 0000000000..8d61a4867b > --- /dev/null > +++ b/ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h > @@ -0,0 +1,27 @@ > +/** @file > + TPM Platform Hierarchy configuration library. > + > + This library provides functions for customizing the TPM's Platform Hierarchy > + Authorization Value (platformAuth) and Platform Hierarchy Authorization > + Policy (platformPolicy) can be defined through this function. > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +Copyright (c) Microsoft Corporation.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef TPM_PLATFORM_HIERARCHY_LIB_H_ > +#define TPM_PLATFORM_HIERARCHY_LIB_H_ > + > +/** > + This service will perform the TPM Platform Hierarchy configuration at the SmmReadyToLock event. > + > +**/ > +VOID > +EFIAPI > +ConfigureTpmPlatformHierarchy ( > + VOID > + ); > + > +#endif > diff --git a/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c b/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c > new file mode 100644 > index 0000000000..bac1efda63 > --- /dev/null > +++ b/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c > @@ -0,0 +1,22 @@ > +/** @file > + Null TPM Platform Hierarchy configuration library. > + > + This library provides stub functions for customizing the TPM's Platform Hierarchy. > + > + Copyright (c) 2021, IBM Corporation. > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > + > +/** > + A NULL implementation of ConfigureTpmPlatformHierarchy. > +**/ > +VOID > +EFIAPI > +ConfigureTpmPlatformHierarchy ( VOID > + ) > +{ > + /* no nothing */ double negative :-) > +} > diff --git a/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf b/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf > new file mode 100644 > index 0000000000..4f02818bbc > --- /dev/null > +++ b/ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf > @@ -0,0 +1,30 @@ > +### @file > +# NULL TPM Platform Hierarchy configuration library. > +# > +# This library provides functions for customizing the TPM's Platform Hierarchy > +# Authorization Value (platformAuth) and Platform Hierarchy Authorization > +# Policy (platformPolicy) can be defined through this function. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) Microsoft Corporation.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +### > + > +[Defines] > + INF_VERSION = 0x00010005 1.27 > + BASE_NAME = PeiDxeTpmPlatformHierarchyLibNull Make this BasePlatform.... > + FILE_GUID = 8947A3F2-BfB4-45EF-968D-5C40C1CE6A58 > + MODULE_TYPE = PEIM BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = TpmPlatformHierarchyLib|PEIM DXE_DRIVER > + > +[LibraryClasses] > + BaseLib > + > +[Packages] > + MdePkg/MdePkg.dec > + > +[Sources] > + PeiDxeTpmPlatformHierarchyLib.c > -- > 2.31.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#80830): https://edk2.groups.io/g/devel/message/80830 > Mute This Topic: https://groups.io/mt/85662429/5717338 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org] > ------------ > >