From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.5681.1632309652359312820 for ; Wed, 22 Sep 2021 04:20:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FdN4k8En; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 52C93611C0 for ; Wed, 22 Sep 2021 11:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632309650; bh=72Y0cIydHr8wJ6lpsq1zIp9rkyTKkHIAT1Qu/GqEAXM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FdN4k8EnTB1tkojbycEJr2FjSB/Lo5ml1jXtH+TMR+ceYRt6OvHNj3DVtsa5dbA5R DjZVvHr89jUyLy9hYRKWzHdFfkHXA4bF+AIR3gbgr8FWSGc9nTGdYoRi9APCwm7M56 Vkt7PG1FXw9n7/7U2JTosxHQ5fTs5U427ps9D0eThvX8AJbfwetJRHj+2Ilj0+9ZCp LEb3G0jvoR6VekCxbGYplXOh74FDdpKKyYriwrDGoVQ92zqnehdNV3wv32bKAYaKco E8vOleiomeJZs2LDmSgxvGAsMIT43RqcOEq4ZRGGdQeZsB/UbPLPv4Uam5woymwjMH lA+56mHGGxAWQ== Received: by mail-oi1-f177.google.com with SMTP id w19so3853256oik.10 for ; Wed, 22 Sep 2021 04:20:50 -0700 (PDT) X-Gm-Message-State: AOAM532WvTQYgYq1DTBoy/nz/AMd9sOuUluZItaUE8ZC2Ib9/G5za5/U y6nGrv/stXn+lWt5VH6ncpZ3GUoHeEqf4rFjpB4= X-Google-Smtp-Source: ABdhPJxSpdG5K7vZZHL/znAT8oqa/DI4ZaC7JUlT4Nmxv8qf170mDVQX7SMyvvmtjc+JZVfsdOixro5H20BehmsOKNA= X-Received: by 2002:a05:6808:1148:: with SMTP id u8mr5522613oiu.33.1632309649686; Wed, 22 Sep 2021 04:20:49 -0700 (PDT) MIME-Version: 1.0 References: <20210911025714.26263-1-rebecca@bsdio.com> <20210911025714.26263-2-rebecca@bsdio.com> <20210914143903.ors7du74byx2zirx@leviathan> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 22 Sep 2021 13:20:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms PATCH 1/4] BeagleBoardPkg: Remove the configuration and image headers from flash To: Leif Lindholm Cc: Rebecca Cran , Ard Biesheuvel , edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" On Wed, 22 Sept 2021 at 13:20, Ard Biesheuvel wrote: > > On Tue, 14 Sept 2021 at 16:39, Leif Lindholm wrote: > > > > Ard, I think you were the one who converted the old crazy header stuff > > to what we have now. Do you remember how this all fits together? > > > > I had to page it in (edk2:a1123292a80608a69df89b6dd264c4656b618aec) > but given that I never used a BeagleBoard in my life, I'm sure this > was a theoretical exercise mostly, and I just compared the resulting > images before and after. > > So this looks fine to me - if don't have a use for the configuration > header we should just remove it. > ... which you can take as a Reviewed-by: Ard Biesheuvel for the series. > > For the *other* 3 patches, but not this one: > > Reviewed-by: Leif Lindholm > > > > > > On Fri, Sep 10, 2021 at 20:57:11 -0600, Rebecca Cran wrote: > > > Remove the configuration and image headers from the flash image. > > > This was likely intended for the UEFI firmware to be loaded by the ROM > > > code, but the BeagleBoard only has 64KB SRAM and so EDK2 needs to be > > > executed as a second stage loader. > > > > > > Signed-off-by: Rebecca Cran > > > --- > > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf | 13 ++----------- > > > 1 file changed, 2 insertions(+), 11 deletions(-) > > > > > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > > > index a2cfeb3bc27b..dbae015ff382 100644 > > > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > > > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > > > @@ -23,7 +23,7 @@ > > > > > > > > > [FD.BeagleBoard_EFI] > > > -BaseAddress = 0x80007DF8|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the FLASH Device. > > > +BaseAddress = 0x80008000|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the FLASH Device. > > > Size = 0x000B0000|gArmTokenSpaceGuid.PcdFdSize #The size in bytes of the FLASH Device > > > ErasePolarity = 1 > > > BlockSize = 0x1 > > > @@ -44,16 +44,7 @@ NumBlocks = 0xB0000 > > > # RegionType > > > # > > > ################################################################################ > > > -0x00000000|0x00000200 > > > -FILE = Platform/BeagleBoard/BeagleBoardPkg/ConfigurationHeader.bin > > > - > > > -0x00000200|0x00000008 > > > -DATA = { > > > - 0xF8, 0xFD, 0x0A, 0x00, # image size: 0xB0000 - 0x208 == 0xAFDF8 > > > - 0x00, 0x80, 0x00, 0x80 # entry point: 0x80008000 > > > -} > > > - > > > -0x00000208|0x000AFDF8 > > > +0x00000000|0x000B0000 > > > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > > FV = FVMAIN_COMPACT > > > > > > -- > > > 2.31.1 > > > > > >