From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D7801D8114C for ; Tue, 28 Nov 2023 09:52:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lIxGkQKxJS3OXqYZt8bbsI1kkTZOr7rnuF3DNbotABE=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1701165126; v=1; b=R3lBp86DKA3PhM+Xyz5gDacMkej+VGQSJA4rgb1KGYDJ1eH0JvauX2Ds7TC/TrlvKlNOzx7S iyIaSE73XiemLhnRNKQIgotL1NzVssn0DqBNKWfCce76OJtRZsYDgJT0tB1ZV8FNg1IAWPn/zoV 24z8hohxEozMmdWgW8Tjhn4c= X-Received: by 127.0.0.2 with SMTP id QluIYY7687511xfQqY2f6XkR; Tue, 28 Nov 2023 01:52:06 -0800 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.29230.1701165125718799970 for ; Tue, 28 Nov 2023 01:52:06 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id BBBC6B811C4 for ; Tue, 28 Nov 2023 09:52:03 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21112C433C7 for ; Tue, 28 Nov 2023 09:52:03 +0000 (UTC) X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2c9b88cf626so1444211fa.3 for ; Tue, 28 Nov 2023 01:52:03 -0800 (PST) X-Gm-Message-State: 5WVovrdmSMokWp0AlLASvpSLx7686176AA= X-Google-Smtp-Source: AGHT+IH1H3dzu5qrdMftDcTaOGkRPE5nVOarbZeyQrzr0+pIzgYHreewIaIs3iCHuYfL+vXl2UyAUJZutCOCVUwj1EE= X-Received: by 2002:a2e:a58d:0:b0:2c9:99ca:1317 with SMTP id m13-20020a2ea58d000000b002c999ca1317mr5764608ljp.24.1701165121308; Tue, 28 Nov 2023 01:52:01 -0800 (PST) MIME-Version: 1.0 References: <20231128001500.1107-1-mikuback@linux.microsoft.com> In-Reply-To: <20231128001500.1107-1-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Tue, 28 Nov 2023 10:51:50 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 0/2] ArmPkg/CpuDxe: Use upper and lower attributes To: mikuback@linux.microsoft.com Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=R3lBp86D; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Tue, 28 Nov 2023 at 01:15, wrote: > > From: Michael Kubacki > > This series contains two changes: > > 1. To fix a compiler warning with the current state of code. > 2. To update the code to pass the integer width needed for a > comparison to set EFI_MEMORY_XP in the GCD attribute returned > for a given page attribute. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > > Michael Kubacki (2): > ArmPkg/Drivers/CpuDxe: Explicitly cast table entry > ArmPkg/Drivers/CpuDxe: Use lower and upper attributes > Thanks for the fixes. This code is in a rather poor state, unfortunately. I don't quite get the motivation for fixing this using two different patches: the implicit UINT32 cast obviously loses some attributes (the ones in the 12 upper bits, notably UXN and PXN), so making it explicit removes the warning but preserves the bug. (If GCC had better diagnostics, we'd spotted this problem years ago) Maybe it is sufficient to simply squash the two patches together? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111803): https://edk2.groups.io/g/devel/message/111803 Mute This Topic: https://groups.io/mt/102841999/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-