From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web11.5067.1654245061161110117
 for <devel@edk2.groups.io>;
 Fri, 03 Jun 2022 01:31:01 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yd/6wmIb;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 03B9D6195D
	for <devel@edk2.groups.io>; Fri,  3 Jun 2022 08:31:00 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 664D5C34115
	for <devel@edk2.groups.io>; Fri,  3 Jun 2022 08:30:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1654245059;
	bh=JRUpxKkoyIBYq7/LC7faVm2kh1d1SxShlk/LBmKhcMI=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=Yd/6wmIb4Lk2FilTE+woqSIl48WZdIERPthzmRoj9fAUkrgSg3qJJl4ejcUVZcw4O
	 6NtLw2LJcqydKR8lfVyYerrV2L176JvXQ9QWePbAv6Cb7/BRy2VzYh4rx15qo4mIR9
	 aGTmxdgv0mjiLg6p0qNycq6h4cFpEqZtxyRmSIIk3exyYZLLiSDccOn4n9OBr1Ah2r
	 Pl4h7j4/6CRTUE/Agxvpxmgy5VHqoNHThavSyf0OQLCapvhQGa7QGIXJpjFfeQLNv9
	 YwiwQC7ZMHCi+5TLjEfqqiyNhpUkMIt2hdb0OtnqZ5LG0brl9HEHOawhSBgQ1Z6ReI
	 9eMgSLma88fqA==
Received: by mail-oi1-f175.google.com with SMTP id k11so9533457oia.12
        for <devel@edk2.groups.io>; Fri, 03 Jun 2022 01:30:59 -0700 (PDT)
X-Gm-Message-State: AOAM5301eZ1U9+FLMRvODOsFHyGVs7RHEqkMPid1wVcbdIfVrvkm7qaZ
	oDiDSFNZnwvCZ9leasKoMS8QG2oAATevvK9sGts=
X-Google-Smtp-Source: ABdhPJz9JaGKUn7azDD8AXo/GjGp2ZgWN0jyUp8LwmGpjjV2dM/V+0iXOIE/0U+WABofCUs8PIWnRvjFzrAVf5VKcPg=
X-Received: by 2002:a05:6808:300e:b0:32c:425e:df34 with SMTP id
 ay14-20020a056808300e00b0032c425edf34mr4798735oib.126.1654245058612; Fri, 03
 Jun 2022 01:30:58 -0700 (PDT)
MIME-Version: 1.0
References: <20220602084216.159028-1-kraxel@redhat.com> <20220602084216.159028-2-kraxel@redhat.com>
 <MWHPR11MB16311F77B41CF02A3D6A2BBD8CDE9@MWHPR11MB1631.namprd11.prod.outlook.com>
 <CAMj1kXHNh2B0+SH7U9kcCO7gAeYVaBBDdgRdZXP0PQBfhGmiqg@mail.gmail.com>
 <20220602131457.75zndaiipdosgiid@sirius.home.kraxel.org> <CAMj1kXEOp_Z+UyQb220hLyCrKzOuTwpDfiYw1s+emR4PQP+TDw@mail.gmail.com>
 <20220603082931.vaivi4vwetwrldnt@sirius.home.kraxel.org>
In-Reply-To: <20220603082931.vaivi4vwetwrldnt@sirius.home.kraxel.org>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Fri, 3 Jun 2022 10:30:47 +0200
X-Gmail-Original-Message-ID: <CAMj1kXFm2_JiMhiyC+D9Hxhjc7hXYVzmCv=dN1JfGbfGz25fSg@mail.gmail.com>
Message-ID: <CAMj1kXFm2_JiMhiyC+D9Hxhjc7hXYVzmCv=dN1JfGbfGz25fSg@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, "Ni, Ray" <ray.ni@intel.com>, 
	"Wu, Hao A" <hao.a.wu@intel.com>, Pawel Polawski <ppolawsk@redhat.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, "Albecki, Mateusz" <mateusz.albecki@intel.com>, 
	"Chang, Abner" <abner.chang@hpe.com>, Leif Lindholm <quic_llindhol@quicinc.com>, 
	"Yao, Jiewen" <jiewen.yao@intel.com>, Oliver Steffen <osteffen@redhat.com>, 
	"Gao, Liming" <gaoliming@byosoft.com.cn>, "Wang, Jian J" <jian.j.wang@intel.com>, 
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 3 Jun 2022 at 10:29, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
>   Hi,
>
> > This seems to be related to the padding logic, i.e., we are trying to
> > preserve some extra I/O space for the root port in case we hotplug
> > something that might need it.
>
> > --- a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
> > +++ b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
> > @@ -733,7 +733,7 @@ GetResourcePadding (
> >      }
> >    }
> >
> > -  if (DefaultIo) {
> > +  if (DefaultIo && FALSE) {
> >      //
> >      // Request defaults.
> >      //
>
> Oh, *there* it comes from.  Given this is configurable already we can
> fix that one in qemu with a microvm tweak:
>
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index 4b3b1dd262f1..f01d972f5d28 100644
> --- a/hw/i386/microvm.c
> +++ b/hw/i386/microvm.c
> @@ -757,6 +757,12 @@ static void microvm_class_init(ObjectClass *oc, void *data)
>          "Set off to disable adding virtio-mmio devices to the kernel cmdline");
>
>      machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE);
> +
> +    /*
> +     * pcie host bridge (gpex) on microvm has no io address window,
> +     * so reserving io space is not going to work.  Turn it off.
> +     */
> +    object_register_sugar_prop("pcie-root-port", "io-reserve", "0", true);
>  }
>
>  static const TypeInfo microvm_machine_info = {
>
> So, I think we can drop patch #1.  Want me respin the series, or can you
> simply drop the patch on merge?
>

I've already queued it up.