From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0F331D800F6 for ; Thu, 14 Mar 2024 16:32:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TvOyaIAR9Hok4efGMEOxxPigcy/Fr1F+ruzI0dBr1oI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710433924; v=1; b=gKpVZbN1uTVxKJslbMNlFc9D5iTuoe642GlmNDPOwPKpDLHbT7qDgj2vUBZB8FliSrdg3OWe knn9vCfQEWgSp27+TZxg+NHewk7qkxjb272dECspWT1u94X6X3768Zr+TFyBFiEJ6eBQR5k2+2g Rfd8IK+OorIQOZzoRX6P6mzw3LP2SEnBgEN4zIRA+wsOpevVgPQi+01BbaUSwVUs3zm5Nsks5zC 6SSnUyZRmOAUwLdDIAkm/KXesKKEwPnNhacTH4jxmKnWDL7zyTa8vSQgLRWN3aytU6hoQkEDKEH DLC3l9KZcuYYwfZivgOCvDlduMy6MZ6qyo0IaGQPRznsg== X-Received: by 127.0.0.2 with SMTP id 7g47YY7687511xf9DaWsVfoG; Thu, 14 Mar 2024 09:32:04 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.754.1710433923833454078 for ; Thu, 14 Mar 2024 09:32:03 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 47E9961505 for ; Thu, 14 Mar 2024 16:32:03 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BB9CC43394 for ; Thu, 14 Mar 2024 16:32:02 +0000 (UTC) X-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2d21cdbc85bso14407621fa.2 for ; Thu, 14 Mar 2024 09:32:02 -0700 (PDT) X-Gm-Message-State: GHDvBys3gn8ToLsslu5O3nv1x7686176AA= X-Google-Smtp-Source: AGHT+IEHzW3zxdjIob1neeu2ViXpiJIeC04ZkwTMClVfaCMBIbaZs4NAFl14MUWt0CfG5AjXfS2knxB/TGXxG9pOrRA= X-Received: by 2002:a05:6512:479:b0:513:c996:84c3 with SMTP id x25-20020a056512047900b00513c99684c3mr528115lfd.53.1710433920774; Thu, 14 Mar 2024 09:32:00 -0700 (PDT) MIME-Version: 1.0 References: <20240309190559.28677-1-osde@linux.microsoft.com> <034701da761f$41052190$c30f64b0$@byosoft.com.cn> In-Reply-To: <034701da761f$41052190$c30f64b0$@byosoft.com.cn> From: "Ard Biesheuvel" Date: Thu, 14 Mar 2024 17:31:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: Oliver Smith-Denny , Leif Lindholm , Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 14 Mar 2024 09:32:04 -0700 Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=gKpVZbN1; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Thu, 14 Mar 2024 at 15:52, gaoliming via groups.io wrote: > > For this patch set, I have no comments. Reviewed-by: Liming Gao > Merged as #5471 > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Oliver Smith-Denny > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B43=E6=9C=8810=E6=97= =A5 3:06 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E6=8A=84=E9=80=81: Leif Lindholm ; Ard Bies= heuvel > > ; Sami Mujawar ; > > Liming Gao > > =E4=B8=BB=E9=A2=98: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity = Issues > > > > This patch series is the third version of > > MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocation= s. > > The subject line has been updated because this went from a one commit > > patch with no cover letter to a multi-commit patch. > > > > The commit messages cover the vast amount of detail here, but this > > patchset fixes three issues: > > - a UEFI spec violation for which memory types require runtime page > > allocation granularity alignment > > - An incompatibility of the heap guard system to guard these regions > > that require runtime page allocation granularities greater than > > the EFI_PAGE_SIZE. > > - A CodeQL error that fails CI when updating the Page.c code > > > > v3: > > - edit comments for readability > > > > v2: > > - Add commit to fix UEFI spec violation > > - Add commit to fix newly flagged CodeQL error > > - Update guard commit message, comments, and static assert to use > > the correct types > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sami Mujawar > > Cc: Liming Gao > > > > Oliver Smith-Denny (3): > > MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages > > MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type > > MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types > > > > MdeModulePkg/MdeModulePkg.dec | 10 +++++++++ > > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14 > > +++++++++++++ > > MdeModulePkg/Core/Dxe/Mem/Page.c | 22 > > +++++++++++++++++--- > > MdeModulePkg/Core/Dxe/Mem/Pool.c | 15 > > +++++++++++-- > > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++-- > > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- > > 6 files changed, 59 insertions(+), 8 deletions(-) > > > > -- > > 2.40.1 > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116772): https://edk2.groups.io/g/devel/message/116772 Mute This Topic: https://groups.io/mt/104930045/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-