From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id CF8509415CC for ; Sun, 30 Jun 2024 12:37:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9IDSp2XJqM/dBzNBl+Dyc5Xks6BiRODFTatimtqvmmA=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1719751064; v=1; b=gU2cqpuJ92QgxjwqCCaTslhPVUvBYj/QPqEF7csYdcfbDU8X/d6vxttvWxszI5DbM+IHRlv6 guSJqAp50jdpGPNWBG1qZ97GbLVnD1yC2uvDnpke4fY2BzU8A/VAKZ/aKl+rJyj8xWTq8kAL4zW OXe6bNlmDTKIOoSq1TmdTcVGgk0ldJknud8I73YIoDT3oXb7FIqGDHFDewScxXqfKLxT+GE/Kau bzqYEngma21uL+A5kz9wAPY7RXz1Hxji40QVwHIq5ym3I6gY+tRE/aleGU/rDPqQdJ9rtSyCJyg q2N0xAFqg47ssIQR1hx5x+u68KmEtgAH6eGq6wK4U0t8w== X-Received: by 127.0.0.2 with SMTP id w3wpYY7687511xRJ6lVaKqRQ; Sun, 30 Jun 2024 05:37:43 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.24686.1719751062499862177 for ; Sun, 30 Jun 2024 05:37:42 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id ECBCE60DB4 for ; Sun, 30 Jun 2024 12:37:41 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id A40E1C32786 for ; Sun, 30 Jun 2024 12:37:41 +0000 (UTC) X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2ec002caf3eso33129811fa.1 for ; Sun, 30 Jun 2024 05:37:41 -0700 (PDT) X-Gm-Message-State: lwsSVnLoW9doAQbOFQ6WXtHcx7686176AA= X-Google-Smtp-Source: AGHT+IHojIan8nzOPDvF22Fyiur8xBVeZ8J0oMCWUQ7aEMJbeC5q8LwJ+wE/IkkLhwLsBHqhj2CM269yWNFJ7fTQlXk= X-Received: by 2002:a2e:bc88:0:b0:2ee:4c6c:5874 with SMTP id 38308e7fff4ca-2ee5e37ff02mr35109431fa.10.1719751059958; Sun, 30 Jun 2024 05:37:39 -0700 (PDT) MIME-Version: 1.0 References: <20240627142212.408917-1-marcin.juszkiewicz@linaro.org> <20240627142212.408917-2-marcin.juszkiewicz@linaro.org> In-Reply-To: <20240627142212.408917-2-marcin.juszkiewicz@linaro.org> From: "Ard Biesheuvel" Date: Sun, 30 Jun 2024 14:37:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org Cc: Leif Lindholm Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 30 Jun 2024 05:37:42 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=gU2cqpuJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 27 Jun 2024 at 16:22, Marcin Juszkiewicz wrote: > > By default we have Neoverse-N2 cpu which supports FEAT_RNG feature. > > Commit 5de5e230a80bed083360da95ba16a2c4a001620d (in EDK2) enabled that for > ArmVirt platform. > > RNDR is implemented by both Neoverse-N2 and 'max' cpu implemented by QEMU. > Other cpu models lack it which prevents the RngDxe driver from running, > resulting in the same situation as before. > > TRNG is not implemented in TCG mode but is required by RngDxe to run. > > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Ard Biesheuvel > --- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 +++++- > Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 1 + > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > index 9306986bf7c0..3463e5c7a635 100644 > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > @@ -148,7 +148,9 @@ [LibraryClasses.common] > # > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > - RngLib|MdeModulePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > + RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf > + ArmTrngLib|ArmPkg/Library/ArmTrngLib/ArmTrngLib.inf > + ArmMonitorLib|ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > # > @@ -660,6 +662,8 @@ [Components.common] > OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.inf > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuHighMemDxe/SbsaQemuHighMemDxe.inf > + SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > + > > # > # FAT filesystem + GPT/MBR partitioning > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > index b35f42e11aa4..51a1ef8519f9 100644 > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > @@ -192,6 +192,7 @@ [FV.FvMain] > INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf > INF OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.inf > INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > + INF SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > > # > # FAT filesystem + GPT/MBR partitioning + UDF filesystem > -- > 2.45.2 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#119724): https://edk2.groups.io/g/devel/message/119724 > Mute This Topic: https://groups.io/mt/106909459/1131722 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > ------------ > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119731): https://edk2.groups.io/g/devel/message/119731 Mute This Topic: https://groups.io/mt/106909459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-