[edk2-devel] another broken PR

[edk2-devel] another broken PR

[Ard Biesheuvel]

Could someone please explain what went wrong this time? Many of the
tests are failing, and i don't see a 're-run failed tests' button.

https://github.com/tianocore/edk2/pull/4893


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109367): https://edk2.groups.io/g/devel/message/109367
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] another broken PR

[Michael Kubacki]

I think this is related to the fact that the latest VM images switched 
over to Python 3.12 and the minor version is not fixed to 11.

   C:\hostedtoolcache\windows\Python\3.12.0

I can send a patch to fix the minor version to 3.11 and then the 
transition to 3.12 can take place with more time to evaluate the changes 
needed.

Thanks,
Michael

On 10/6/2023 6:50 PM, Ard Biesheuvel wrote:
> Could someone please explain what went wrong this time? Many of the
> tests are failing, and i don't see a 're-run failed tests' button.
> 
> https://github.com/tianocore/edk2/pull/4893


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109368): https://edk2.groups.io/g/devel/message/109368
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] another broken PR

[Taylor Beebe]

Did you not create a circle of salt before starting the CI pipelines?

That's probably it... or something else :)

-Taylor

On 10/6/2023 3:50 PM, Ard Biesheuvel wrote:
> Could someone please explain what went wrong this time? Many of the
> tests are failing, and i don't see a 're-run failed tests' button.
>
> https://github.com/tianocore/edk2/pull/4893
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109369): https://edk2.groups.io/g/devel/message/109369
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] another broken PR

[Michael Kubacki]

https://edk2.groups.io/g/devel/message/109370

On 10/6/2023 6:54 PM, Michael Kubacki wrote:
> I think this is related to the fact that the latest VM images switched 
> over to Python 3.12 and the minor version is not fixed to 11.
> 
>    C:\hostedtoolcache\windows\Python\3.12.0
> 
> I can send a patch to fix the minor version to 3.11 and then the 
> transition to 3.12 can take place with more time to evaluate the changes 
> needed.
> 
> Thanks,
> Michael
> 
> On 10/6/2023 6:50 PM, Ard Biesheuvel wrote:
>> Could someone please explain what went wrong this time? Many of the
>> tests are failing, and i don't see a 're-run failed tests' button.
>>
>> https://github.com/tianocore/edk2/pull/4893
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109373): https://edk2.groups.io/g/devel/message/109373
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] another broken PR

[Michael Kubacki]

On 10/6/2023 7:17 PM, Michael Kubacki wrote:
> https://edk2.groups.io/g/devel/message/109370
> 
I am planning to quickly merge that series (with its R-b) when PR checks 
are completed to unblock CI.

> On 10/6/2023 6:54 PM, Michael Kubacki wrote:
>> I think this is related to the fact that the latest VM images switched 
>> over to Python 3.12 and the minor version is not fixed to 11.
>>
>>    C:\hostedtoolcache\windows\Python\3.12.0
>>
>> I can send a patch to fix the minor version to 3.11 and then the 
>> transition to 3.12 can take place with more time to evaluate the 
>> changes needed.
>>
>> Thanks,
>> Michael
>>
>> On 10/6/2023 6:50 PM, Ard Biesheuvel wrote:
>>> Could someone please explain what went wrong this time? Many of the
>>> tests are failing, and i don't see a 're-run failed tests' button.
>>>
>>> https://github.com/tianocore/edk2/pull/4893
>>
>>
>> 
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109375): https://edk2.groups.io/g/devel/message/109375
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] another broken PR

[Michael Kubacki]

On 10/6/2023 8:18 PM, Michael Kubacki wrote:
> On 10/6/2023 7:17 PM, Michael Kubacki wrote:
>> https://edk2.groups.io/g/devel/message/109370
>>
> I am planning to quickly merge that series (with its R-b) when PR checks 
> are completed to unblock CI.

Merged to master in commits 6439c73 and 82191f8.
> 
>> On 10/6/2023 6:54 PM, Michael Kubacki wrote:
>>> I think this is related to the fact that the latest VM images 
>>> switched over to Python 3.12 and the minor version is not fixed to 11.
>>>
>>>    C:\hostedtoolcache\windows\Python\3.12.0
>>>
>>> I can send a patch to fix the minor version to 3.11 and then the 
>>> transition to 3.12 can take place with more time to evaluate the 
>>> changes needed.
>>>
>>> Thanks,
>>> Michael
>>>
>>> On 10/6/2023 6:50 PM, Ard Biesheuvel wrote:
>>>> Could someone please explain what went wrong this time? Many of the
>>>> tests are failing, and i don't see a 're-run failed tests' button.
>>>>
>>>> https://github.com/tianocore/edk2/pull/4893
>>>
>>>
>>> 
>>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109376): https://edk2.groups.io/g/devel/message/109376
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] another broken PR

[Ard Biesheuvel]

On Sat, 7 Oct 2023 at 02:26, Michael Kubacki
<mikuback@linux.microsoft.com> wrote:
>
> On 10/6/2023 8:18 PM, Michael Kubacki wrote:
> > On 10/6/2023 7:17 PM, Michael Kubacki wrote:
> >> https://edk2.groups.io/g/devel/message/109370
> >>
> > I am planning to quickly merge that series (with its R-b) when PR checks
> > are completed to unblock CI.
>
> Merged to master in commits 6439c73 and 82191f8.

Thanks for getting this fixed quickly.


> >
> >> On 10/6/2023 6:54 PM, Michael Kubacki wrote:
> >>> I think this is related to the fact that the latest VM images
> >>> switched over to Python 3.12 and the minor version is not fixed to 11.
> >>>
> >>>    C:\hostedtoolcache\windows\Python\3.12.0
> >>>
> >>> I can send a patch to fix the minor version to 3.11 and then the
> >>> transition to 3.12 can take place with more time to evaluate the
> >>> changes needed.
> >>>
> >>> Thanks,
> >>> Michael
> >>>
> >>> On 10/6/2023 6:50 PM, Ard Biesheuvel wrote:
> >>>> Could someone please explain what went wrong this time? Many of the
> >>>> tests are failing, and i don't see a 're-run failed tests' button.
> >>>>
> >>>> https://github.com/tianocore/edk2/pull/4893
> >>>
> >>>
> >>> 
> >>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109383): https://edk2.groups.io/g/devel/message/109383
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] another broken PR

[Laszlo Ersek]

On 10/7/23 13:33, Ard Biesheuvel wrote:
> On Sat, 7 Oct 2023 at 02:26, Michael Kubacki
> <mikuback@linux.microsoft.com> wrote:
>>
>> On 10/6/2023 8:18 PM, Michael Kubacki wrote:
>>> On 10/6/2023 7:17 PM, Michael Kubacki wrote:
>>>> https://edk2.groups.io/g/devel/message/109370
>>>>
>>> I am planning to quickly merge that series (with its R-b) when PR checks
>>> are completed to unblock CI.
>>
>> Merged to master in commits 6439c73 and 82191f8.
> 
> Thanks for getting this fixed quickly.

+1, thanks for that!

Out of curiosity, is there a ticket somewhere with details about the
python 3.12 incompatibilities in the scripts? (Asking "somewhere"
because I don't know if the issues are in tianocore/containers,
tianocore/edk2-pytool-extensions, tianocore/edk2-pytool-library, or
somewhere else.)

Thanks!
Laszlo

> 
> 
>>>
>>>> On 10/6/2023 6:54 PM, Michael Kubacki wrote:
>>>>> I think this is related to the fact that the latest VM images
>>>>> switched over to Python 3.12 and the minor version is not fixed to 11.
>>>>>
>>>>>    C:\hostedtoolcache\windows\Python\3.12.0
>>>>>
>>>>> I can send a patch to fix the minor version to 3.11 and then the
>>>>> transition to 3.12 can take place with more time to evaluate the
>>>>> changes needed.
>>>>>
>>>>> Thanks,
>>>>> Michael
>>>>>
>>>>> On 10/6/2023 6:50 PM, Ard Biesheuvel wrote:
>>>>>> Could someone please explain what went wrong this time? Many of the
>>>>>> tests are failing, and i don't see a 're-run failed tests' button.
>>>>>>
>>>>>> https://github.com/tianocore/edk2/pull/4893
>>>>>
>>>>>
>>>>>
>>>>>
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109387): https://edk2.groups.io/g/devel/message/109387
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-