From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.43229.1671707117853956235 for ; Thu, 22 Dec 2022 03:05:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XkwdaGMd; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E2F061A66 for ; Thu, 22 Dec 2022 11:05:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0EFCC433F2 for ; Thu, 22 Dec 2022 11:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671707116; bh=TwqdL2HfEqRCRjogKNCBE4fDXfvKZd4SrxjZQKuq8Fw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XkwdaGMdQRxAJrIh87DtVJT7zJuYpqM6Fv5Mt2L17wGHfR4OKUu43zBWPStI1RVLm MKbl6R2XqJXkAWJ3MyLqfEcbLAHYMz2geveYf6JTC5XCURdh9KB7jik4o4b7nuzH/3 qq2sgfI+6akURdmt+jBJph3GEJQSlobupT85OyyvbBClHUdAxU2dNbYqjga5KajpER HTBLmBWO+YKGD4ON98RCbqn85jVyT4xV1386EpKGOfcx/2s9+4VdzdpU7cyQP7SRbh TIefui9DtvBBmZywOs0tN4nhTNgs4+qNCtIXvqqYvZdQ8RTjdiGdUi3wW+gHieFpB/ +w3JnXFY1p9FA== Received: by mail-lf1-f42.google.com with SMTP id cf42so2242092lfb.1 for ; Thu, 22 Dec 2022 03:05:16 -0800 (PST) X-Gm-Message-State: AFqh2koOo48+BIfQ7D/gUB8fT2pzpHHuxqvLdmzjlIwWU02PXgQMum7C DwvptM+X9w6zJMLGjeDoar+buFFJCKXut8gsRUo= X-Google-Smtp-Source: AMrXdXti0qv+5za0p8MxfxD/uXNgRdzPK48+xrx2SJq9VhJRE28sa/sxgo8Rmw3yIs5rQDJhYZ0xjMKC6eYKt2nMF/s= X-Received: by 2002:ac2:5dfa:0:b0:4b7:3a0:45d2 with SMTP id z26-20020ac25dfa000000b004b703a045d2mr290899lfq.228.1671707114699; Thu, 22 Dec 2022 03:05:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 22 Dec 2022 12:05:03 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor To: devel@edk2.groups.io, sebastien.boeuf@intel.com Cc: "Yao, Jiewen" , "Xu, Min M" , "kraxel@redhat.com" Content-Type: text/plain; charset="UTF-8" This series has broken all platforms that incorporate OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf but do not provide a resolution for CcProbeLib Please provide a fix https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4748/console On Fri, 16 Dec 2022 at 09:46, Boeuf, Sebastien wrote: > > Thank you Jiewen :) > ________________________________ > From: Yao, Jiewen > Sent: Friday, December 16, 2022 4:03:00 AM > To: Boeuf, Sebastien ; devel@edk2.groups.io > Cc: Xu, Min M ; kraxel@redhat.com > Subject: RE: [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor > > Merged: https://github.com/tianocore/edk2/pull/3778 > > > -----Original Message----- > > From: Boeuf, Sebastien > > Sent: Thursday, December 15, 2022 11:10 PM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Xu, Min M ; > > kraxel@redhat.com; Boeuf, Sebastien > > Subject: [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor > > > > From: Sebastien Boeuf > > > > The IntelTdxX64 OVMF target wasn't working with Cloud Hypervisor on TDX > > platform. This was due to the way the OVMF code expects Cloud Hypervisor > > to rely on PVH to retrieve information like memory below 4GiB as well as > > the ACPI tables. > > > > This is why this series takes care of identifying when running on TDX in > > order to handle things differently. For the memory below 4GiB, it falls > > back onto the CMOS to retrieve the correct information, and for the ACPI > > tables, it relies on the HOB to obtain every table individually before > > to expose them to the guest OS. > > > > With these two use cases properly handled by this series, it is now > > possible to use the IntelTdxX64 target to build an OVMF binary that > > works both for QEMU and Cloud Hypervisor on a TDX platform. > > > > Sebastien Boeuf (3): > > OvmfPkg/PlatformInitLib: Differentiate TDX case for Cloud Hypervisor > > OvmfPkg/PlatformInitLib: Transfer GUID Extension HOB > > OvmfPkg/AcpiPlatformDxe: Differentiate TDX case for Cloud Hypervisor > > > > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 8 +- > > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 6 ++ > > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 3 + > > OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 87 +++++++++++++++++++++ > > OvmfPkg/Library/PlatformInitLib/IntelTdx.c | 5 ++ > > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 5 +- > > OvmfPkg/OvmfPkg.dec | 1 + > > 8 files changed, 114 insertions(+), 2 deletions(-) > > > > -- > > 2.34.1 > > --------------------------------------------------------------------- > Intel Corporation SAS (French simplified joint stock company) > Registered headquarters: "Les Montalets"- 2, rue de Paris, > 92196 Meudon Cedex, France > Registration Number: 302 456 199 R.C.S. NANTERRE > Capital: 5 208 026.16 Euros > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > >