From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web11.65042.1680510102192874051
 for <devel@edk2.groups.io>;
 Mon, 03 Apr 2023 01:21:42 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n4CLdrsQ;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 54E206160D
	for <devel@edk2.groups.io>; Mon,  3 Apr 2023 08:21:41 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60735C433A7
	for <devel@edk2.groups.io>; Mon,  3 Apr 2023 08:21:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1680510100;
	bh=5dBchqh/glcsTeX3aZmxy5zug6tNPP6G7I8KUTFa3X4=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=n4CLdrsQvEcuJ41atg7WfPw9+CZ/xUx4K5eM+mFl2TDRyUzvkHr6k3HmZYlthwegN
	 s/MCO1R2GlqYM24uDnGdA1UOt9YlkibyLHopz/G6hxj1AaAx93L4go7PVfWr+PkpIn
	 wIdTFEr5H7Hq+yqgmAGB3qB5V42FpfS1ppPnHMTuxYUtbtRy99pdZmQnm6o98kKYDe
	 cVobEN3zsJP0yyGgFUVPLyfOwCy8WVEA+QfoZlvJb/wygqdIEcbYpwscDa/W3AvtAh
	 BQEQKU5u16Qi9+rdCoBzlZ7eiT7nccxgu76qWUmkjx3pXEX4a4Ojh2J5mwUX8prB0/
	 Yhn6jXQNw+eXg==
Received: by mail-lf1-f54.google.com with SMTP id g19so23846213lfr.9
        for <devel@edk2.groups.io>; Mon, 03 Apr 2023 01:21:40 -0700 (PDT)
X-Gm-Message-State: AAQBX9c/ZyoT61FfLtWivg9bPvf47yX0NbopRkucMyZgk/qOONFaxQ/p
	F6e/XsY+nYABH5dD+4bOAj1tEawsYFVeB1bl/lc=
X-Google-Smtp-Source: AKy350ZJQDOWUkixLAnpd0XqKAky+ZmXTG/4uFG3RSiCRN6pu3vr/lkQ71C4+KD2yKV2NRVrBfNCm93Xe8PalgHiFo0=
X-Received: by 2002:ac2:52b8:0:b0:4e9:d81f:9a8a with SMTP id
 r24-20020ac252b8000000b004e9d81f9a8amr9704273lfm.9.1680510098350; Mon, 03 Apr
 2023 01:21:38 -0700 (PDT)
MIME-Version: 1.0
References: <MN6PR11MB8244CEF10A845A1EC2B8AFCF8C8F9@MN6PR11MB8244.namprd11.prod.outlook.com>
 <hhigti55nalqi2gzp6la23jdk5lfrji75iftprjbcy7zwfg775@yr6n5edvst5f> <CO1PR11MB49293D2949B04786EBEFA93CD28D9@CO1PR11MB4929.namprd11.prod.outlook.com>
In-Reply-To: <CO1PR11MB49293D2949B04786EBEFA93CD28D9@CO1PR11MB4929.namprd11.prod.outlook.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 3 Apr 2023 10:21:27 +0200
X-Gmail-Original-Message-ID: <CAMj1kXFs8_fzZz1F+uQjZviY21ZnG4wNeSD76bPe4+qsrH8giQ@mail.gmail.com>
Message-ID: <CAMj1kXFs8_fzZz1F+uQjZviY21ZnG4wNeSD76bPe4+qsrH8giQ@mail.gmail.com>
Subject: Re: PR fails due to OVMF time out
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, Laszlo Ersek <lersek@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, "Ni, Ray" <ray.ni@intel.com>, 
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

On Sun, 2 Apr 2023 at 20:23, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> Hi Gerd,
>
> I have investigated this failure with enabling -smp 4.  I think this is an
> important feature that should be on by default.
>

Agreed. And given your investigation below (thanks!), we should be
able to revert the revert as long as we add '-accel
tcg,thread-single', right?

It would be nice if we could also get some coverage for KVM, but for
the time being, this seems to be an improvement already (AFAIU, we
want -smp 4 primarily for the logic used in the code, while there is
very little code that would actually run concurrently, if any)

-- 
Ard.