From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.40588.1674115872690917555 for ; Thu, 19 Jan 2023 00:11:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WUnhxlPJ; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F11160B60 for ; Thu, 19 Jan 2023 08:11:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75E72C433F2 for ; Thu, 19 Jan 2023 08:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674115871; bh=l2xlHYx4jgai4pNfBz4fs9DWglZABEJfSnned8yO0QY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WUnhxlPJChKOE8OCZSI7D3s7mUqVBE9Au4cLbaF/3Dqdv0rJ4bM0tDJSxcGykOOS8 UWWu7cp+BDEudkvoPvVEACIyWOzIM/dw3h1xo0Gb+JZgP72r+hJihNRskcrmg9q6Ab LmOGYihDb6HXwDYiIn8eCBchn+ip505d8cm0QupMTTxNh8SPZ0wMhLUK6dADjUPhnS ttxDBEqC73bvmHGpemnUgUkmIvcv+st/EKvUn2foQQQiFZcI2EaTcLOzAITVbzf4Pi 5iPxwe3CVeT0MPoLIdIFBJk7S9LrT742VKAohsB6qrdDH08OnDhM01erkUoAh+5MW+ Be+eivTZad4Yg== Received: by mail-lj1-f169.google.com with SMTP id y18so1269839ljk.11 for ; Thu, 19 Jan 2023 00:11:11 -0800 (PST) X-Gm-Message-State: AFqh2kq1filC1vWOuufH7KuLxSRmNuemQD51PquJgd/s4+X4Mj7Hi9Fu LMF6Cycbc1HpvBybRvBCsaRIa+JSpWgamvdk/2M= X-Google-Smtp-Source: AMrXdXu3c8wEdQiRJHBVo2ICfbyiSbd/0poyowsBnKeEXUn7hGCSf4AmEr9GWsbUbW3Qp2dNhqISVzvAko+Cm80+fSk= X-Received: by 2002:a2e:a908:0:b0:283:33fa:ee22 with SMTP id j8-20020a2ea908000000b0028333faee22mr477269ljq.415.1674115869436; Thu, 19 Jan 2023 00:11:09 -0800 (PST) MIME-Version: 1.0 References: <20230119015108.1323-1-min.m.xu@intel.com> <20230119075532.himdt6ym6epczsyv@sirius.home.kraxel.org> In-Reply-To: <20230119075532.himdt6ym6epczsyv@sirius.home.kraxel.org> From: "Ard Biesheuvel" Date: Thu, 19 Jan 2023 09:10:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg To: Gerd Hoffmann Cc: devel@edk2.groups.io, min.m.xu@intel.com, Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Content-Type: text/plain; charset="UTF-8" On Thu, 19 Jan 2023 at 08:55, Gerd Hoffmann wrote: > > On Thu, Jan 19, 2023 at 09:51:06AM +0800, Min Xu wrote: > > Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the > > second input parameter in FfsFindSectionData. This change breaks the build > > of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData > > is renamed as FfsFindSectionDataWithHook. Then the original > > FfsFindSectionData is added back. > > Acked-by: Gerd Hoffmann > Thanks all I will go and push this.