From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9748BAC0E5A for ; Fri, 22 Dec 2023 09:47:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ecVeAwujjPupDJGTurGmxG82wEyKcRyM61AyWTHF0T0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1703238459; v=1; b=sFo+7kzbWmuKl7bKsZ/r8zpEKGN7LTCONedLtOOlmih4j/ZvqUGtBQGFoGAih59mqOSf5MBg DKOzsWJa2qQEyWivnhBlpO2cMIi+CDS5R7TMirzylExvKdo8nJlNYQ0Y9TCv5ABSKcjo9IFTRB7 sskN62afCQ9ORRowLa958z+I= X-Received: by 127.0.0.2 with SMTP id 93afYY7687511xmwQ4VazYU8; Fri, 22 Dec 2023 01:47:39 -0800 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web10.20450.1703238458256282228 for ; Fri, 22 Dec 2023 01:47:38 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8D142CE1B00 for ; Fri, 22 Dec 2023 09:47:34 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B843BC433C9 for ; Fri, 22 Dec 2023 09:47:32 +0000 (UTC) X-Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-50e616ef769so1638810e87.1 for ; Fri, 22 Dec 2023 01:47:32 -0800 (PST) X-Gm-Message-State: kuGRP9nMfiywClzLmcMbbTGax7686176AA= X-Google-Smtp-Source: AGHT+IHKxJSks8reCRnTd12rITpxV2IacX0VBLcWsYpvadtc0hLDaS5mLZtJGbspMa3M0cBtTdTxoA9YLZ/gTbnzh4c= X-Received: by 2002:a05:6512:505:b0:50e:298d:29cb with SMTP id o5-20020a056512050500b0050e298d29cbmr527664lfb.116.1703238450976; Fri, 22 Dec 2023 01:47:30 -0800 (PST) MIME-Version: 1.0 References: <20231212130932.2467028-1-lichao@loongson.cn> <17A017C201FEB90D.32321@groups.io> <9014a7b3-095c-42b1-a9ef-5a388818385d@loongson.cn> <0a00f876-0bc5-4cf7-9252-b21520463034@loongson.cn> <97c6da30-758d-48cd-a3c9-558262144f77@loongson.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 22 Dec 2023 10:47:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe To: "Ni, Ray" Cc: Chao Li , "devel@edk2.groups.io" , "Kumar, Rahul R" , Gerd Hoffmann , Leif Lindholm , Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sFo+7kzb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 22 Dec 2023 at 03:37, Ni, Ray wrote: > > Good to me. > > > > Thanks, > > Ray > > From: Chao Li > Sent: Friday, December 22, 2023 9:15 AM > To: devel@edk2.groups.io; ardb@kernel.org; Ni, Ray > Cc: Kumar, Rahul R ; Gerd Hoffmann ; Leif Lindholm ; Ard Biesheuvel ; Sami Mujawar > Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe > > > > > > > > Thanks, > Chao > > On 2023/12/21 21:59, Ard Biesheuvel wrote: > > On Thu, 21 Dec 2023 at 13:41, Chao Li wrote: > > > > ... > > A given platform will either be able to use port IO, or it will need > > to use MMIO translation. So a driver that can do both based on a PCD > > is not very useful, it makes more sense to have two different drivers, > > and the platform incorporates the one it can use. > > > > Ok, I get it, I think you are more inclined to move the ArmCpuIo2Dxe to a new place and rename it, maybe: CpuMmio2Dxe, while some platforms choose the different CpuIo2 drvier by themselves when building FW, right? > > OK. Note that there are 15 references to ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf in edk2-platforms, so if you move the existing driver, please - create the new one by making a copy - update all edk2 and edk2-platforms users to refer to the new version - delete the old version -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112843): https://edk2.groups.io/g/devel/message/112843 Mute This Topic: https://groups.io/mt/103261693/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-