From: "Ard Biesheuvel" <ardb@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-devel] [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console
Date: Thu, 7 Sep 2023 15:56:11 +0200 [thread overview]
Message-ID: <CAMj1kXFt-cxTecd0gKjXGhBKLGn1uG37ydyPWxqrrro0C2RyRg@mail.gmail.com> (raw)
In-Reply-To: <20230706123009.802243-1-kraxel@redhat.com>
On Thu, 6 Jul 2023 at 14:30, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Be consistent with pl011-based serial console setup.
>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
I'll queue this one up too
> ---
> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index b92a916f7eec..85c01351b09d 100644
> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -606,7 +606,7 @@ SetupVirtioSerial (
> 1
> };
>
> - STATIC CONST VENDOR_DEVICE_PATH TerminalNode = {
> + STATIC VENDOR_DEVICE_PATH TerminalNode = {
> {
> MESSAGING_DEVICE_PATH,
> MSG_VENDOR_DP,
> @@ -615,7 +615,7 @@ SetupVirtioSerial (
> (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)
> },
> },
> - DEVICE_PATH_MESSAGING_VT_UTF8
> + // copy from PcdTerminalTypeGuidBuffer
> };
>
> EFI_STATUS Status;
> @@ -634,6 +634,11 @@ SetupVirtioSerial (
> return;
> }
>
> + CopyGuid (
> + &TerminalNode.Guid,
> + PcdGetPtr (PcdTerminalTypeGuidBuffer)
> + );
> +
> DevicePath = AppendDevicePathNode (
> DevicePath,
> &SerialNode.Header
> --
> 2.41.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108392): https://edk2.groups.io/g/devel/message/108392
Mute This Topic: https://groups.io/mt/99984422/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-09-07 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 12:30 [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console Gerd Hoffmann
2023-07-06 14:31 ` Laszlo Ersek
2023-09-07 13:56 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXFt-cxTecd0gKjXGhBKLGn1uG37ydyPWxqrrro0C2RyRg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox