* [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console
@ 2023-07-06 12:30 Gerd Hoffmann
2023-07-06 14:31 ` Laszlo Ersek
2023-09-07 13:56 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 2 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2023-07-06 12:30 UTC (permalink / raw)
To: devel
Cc: Leif Lindholm, Ard Biesheuvel, Gerd Hoffmann, Sami Mujawar,
Laszlo Ersek
Be consistent with pl011-based serial console setup.
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
index b92a916f7eec..85c01351b09d 100644
--- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
+++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
@@ -606,7 +606,7 @@ SetupVirtioSerial (
1
};
- STATIC CONST VENDOR_DEVICE_PATH TerminalNode = {
+ STATIC VENDOR_DEVICE_PATH TerminalNode = {
{
MESSAGING_DEVICE_PATH,
MSG_VENDOR_DP,
@@ -615,7 +615,7 @@ SetupVirtioSerial (
(UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)
},
},
- DEVICE_PATH_MESSAGING_VT_UTF8
+ // copy from PcdTerminalTypeGuidBuffer
};
EFI_STATUS Status;
@@ -634,6 +634,11 @@ SetupVirtioSerial (
return;
}
+ CopyGuid (
+ &TerminalNode.Guid,
+ PcdGetPtr (PcdTerminalTypeGuidBuffer)
+ );
+
DevicePath = AppendDevicePathNode (
DevicePath,
&SerialNode.Header
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console
2023-07-06 12:30 [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console Gerd Hoffmann
@ 2023-07-06 14:31 ` Laszlo Ersek
2023-09-07 13:56 ` [edk2-devel] " Ard Biesheuvel
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2023-07-06 14:31 UTC (permalink / raw)
To: Gerd Hoffmann, devel; +Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar
On 7/6/23 14:30, Gerd Hoffmann wrote:
> Be consistent with pl011-based serial console setup.
>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index b92a916f7eec..85c01351b09d 100644
> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -606,7 +606,7 @@ SetupVirtioSerial (
> 1
> };
>
> - STATIC CONST VENDOR_DEVICE_PATH TerminalNode = {
> + STATIC VENDOR_DEVICE_PATH TerminalNode = {
> {
> MESSAGING_DEVICE_PATH,
> MSG_VENDOR_DP,
> @@ -615,7 +615,7 @@ SetupVirtioSerial (
> (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)
> },
> },
> - DEVICE_PATH_MESSAGING_VT_UTF8
> + // copy from PcdTerminalTypeGuidBuffer
> };
>
> EFI_STATUS Status;
> @@ -634,6 +634,11 @@ SetupVirtioSerial (
> return;
> }
>
> + CopyGuid (
> + &TerminalNode.Guid,
> + PcdGetPtr (PcdTerminalTypeGuidBuffer)
> + );
> +
> DevicePath = AppendDevicePathNode (
> DevicePath,
> &SerialNode.Header
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console
2023-07-06 12:30 [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console Gerd Hoffmann
2023-07-06 14:31 ` Laszlo Ersek
@ 2023-09-07 13:56 ` Ard Biesheuvel
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2023-09-07 13:56 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: devel, Leif Lindholm, Ard Biesheuvel, Sami Mujawar, Laszlo Ersek
On Thu, 6 Jul 2023 at 14:30, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Be consistent with pl011-based serial console setup.
>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
I'll queue this one up too
> ---
> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index b92a916f7eec..85c01351b09d 100644
> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -606,7 +606,7 @@ SetupVirtioSerial (
> 1
> };
>
> - STATIC CONST VENDOR_DEVICE_PATH TerminalNode = {
> + STATIC VENDOR_DEVICE_PATH TerminalNode = {
> {
> MESSAGING_DEVICE_PATH,
> MSG_VENDOR_DP,
> @@ -615,7 +615,7 @@ SetupVirtioSerial (
> (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8)
> },
> },
> - DEVICE_PATH_MESSAGING_VT_UTF8
> + // copy from PcdTerminalTypeGuidBuffer
> };
>
> EFI_STATUS Status;
> @@ -634,6 +634,11 @@ SetupVirtioSerial (
> return;
> }
>
> + CopyGuid (
> + &TerminalNode.Guid,
> + PcdGetPtr (PcdTerminalTypeGuidBuffer)
> + );
> +
> DevicePath = AppendDevicePathNode (
> DevicePath,
> &SerialNode.Header
> --
> 2.41.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108392): https://edk2.groups.io/g/devel/message/108392
Mute This Topic: https://groups.io/mt/99984422/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-07 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-06 12:30 [PATCH v3 1/1] ArmVirtPkg: use PcdTerminalTypeGuidBuffer for VirtioSerial console Gerd Hoffmann
2023-07-06 14:31 ` Laszlo Ersek
2023-09-07 13:56 ` [edk2-devel] " Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox