* [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
@ 2023-01-05 23:07 Moritz Fischer
2023-01-06 9:14 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 1 reply; 7+ messages in thread
From: Moritz Fischer @ 2023-01-05 23:07 UTC (permalink / raw)
To: devel; +Cc: Moritz Fischer
Linux' cpu DT bindings call out arm,armv8 while the code previously
used arm,arm-v8.
Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
Signed-off-by: Moritz Fischer <moritzf@google.com>
---
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
index 2c72bd0c58..dc6e7a4d15 100644
--- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
+++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
@@ -22,7 +22,7 @@
*/
STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = {
{ "arm,arm-v7" },
- { "arm,arm-v8" },
+ { "arm,armv8" },
{ "arm,cortex-a15" },
{ "arm,cortex-a7" },
{ "arm,cortex-a57" }
--
2.39.0.314.g84b9a713c41-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
2023-01-05 23:07 [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string Moritz Fischer
@ 2023-01-06 9:14 ` Ard Biesheuvel
2023-01-06 9:15 ` Ard Biesheuvel
0 siblings, 1 reply; 7+ messages in thread
From: Ard Biesheuvel @ 2023-01-06 9:14 UTC (permalink / raw)
To: devel, moritzf
On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io
<moritzf=google.com@groups.io> wrote:
>
> Linux' cpu DT bindings call out arm,armv8 while the code previously
> used arm,arm-v8.
>
> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
> Signed-off-by: Moritz Fischer <moritzf@google.com>
> ---
> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> index 2c72bd0c58..dc6e7a4d15 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> @@ -22,7 +22,7 @@
> */
> STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = {
> { "arm,arm-v7" },
> - { "arm,arm-v8" },
> + { "arm,armv8" },
Thanks for the patch
Should we keep both instead of removing the old one?
> { "arm,cortex-a15" },
> { "arm,cortex-a7" },
> { "arm,cortex-a57" }
> --
> 2.39.0.314.g84b9a713c41-goog
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
2023-01-06 9:14 ` [edk2-devel] " Ard Biesheuvel
@ 2023-01-06 9:15 ` Ard Biesheuvel
2023-01-06 9:55 ` Sami Mujawar
[not found] ` <1737AFAF4745C39B.7095@groups.io>
0 siblings, 2 replies; 7+ messages in thread
From: Ard Biesheuvel @ 2023-01-06 9:15 UTC (permalink / raw)
To: devel, moritzf, Sami Mujawar
(cc Sami)
On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io
> <moritzf=google.com@groups.io> wrote:
> >
> > Linux' cpu DT bindings call out arm,armv8 while the code previously
> > used arm,arm-v8.
> >
> > Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
> > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > ---
> > DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> > index 2c72bd0c58..dc6e7a4d15 100644
> > --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> > +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> > @@ -22,7 +22,7 @@
> > */
> > STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = {
> > { "arm,arm-v7" },
> > - { "arm,arm-v8" },
> > + { "arm,armv8" },
>
> Thanks for the patch
>
> Should we keep both instead of removing the old one?
>
> > { "arm,cortex-a15" },
> > { "arm,cortex-a7" },
> > { "arm,cortex-a57" }
> > --
> > 2.39.0.314.g84b9a713c41-goog
> >
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
2023-01-06 9:15 ` Ard Biesheuvel
@ 2023-01-06 9:55 ` Sami Mujawar
2023-01-08 4:07 ` Moritz Fischer
[not found] ` <1737AFAF4745C39B.7095@groups.io>
1 sibling, 1 reply; 7+ messages in thread
From: Sami Mujawar @ 2023-01-06 9:55 UTC (permalink / raw)
To: Ard Biesheuvel, devel, moritzf; +Cc: nd@arm.com
Hi Ard, Mortiz,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 06/01/2023 09:15 am, Ard Biesheuvel wrote:
> (cc Sami)
>
> On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel <ardb@kernel.org> wrote:
>> On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io
>> <moritzf=google.com@groups.io> wrote:
>>> Linux' cpu DT bindings call out arm,armv8 while the code previously
>>> used arm,arm-v8.
>>>
>>> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
>>> Signed-off-by: Moritz Fischer <moritzf@google.com>
>>> ---
>>> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
>>> index 2c72bd0c58..dc6e7a4d15 100644
>>> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
>>> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
>>> @@ -22,7 +22,7 @@
>>> */
>>> STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = {
>>> { "arm,arm-v7" },
>>> - { "arm,arm-v8" },
>>> + { "arm,armv8" },
>> Thanks for the patch
>>
>> Should we keep both instead of removing the old one?
[SAMI] I think we would need to keep both as the CPU nodes generated by
Kvmtool have compatible string as "arm,arm-v8", see
https://github.com/kvmtool/kvmtool/blob/master/arm/aarch64/arm-cpu.c#L31.
Mortiz: Is it possible to share some information about your use case,
please?
[/SAMI]
>>
>>> { "arm,cortex-a15" },
>>> { "arm,cortex-a7" },
>>> { "arm,cortex-a57" }
>>> --
>>> 2.39.0.314.g84b9a713c41-goog
>>>
>>>
>>>
>>>
>>>
>>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
[not found] ` <1737AFAF4745C39B.7095@groups.io>
@ 2023-01-06 10:27 ` Sami Mujawar
0 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2023-01-06 10:27 UTC (permalink / raw)
To: devel, Ard Biesheuvel, moritzf; +Cc: nd@arm.com
Hi Moritz,
Apologies for typing your name incorrectly in my previous email.
Regards,
Sami Mujawar
On 06/01/2023 09:55 am, Sami Mujawar via groups.io wrote:
> Hi Ard, Mortiz,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 06/01/2023 09:15 am, Ard Biesheuvel wrote:
>> (cc Sami)
>>
>> On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel <ardb@kernel.org> wrote:
>>> On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io
>>> <moritzf=google.com@groups.io> wrote:
>>>> Linux' cpu DT bindings call out arm,armv8 while the code previously
>>>> used arm,arm-v8.
>>>>
>>>> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC
>>>> parser")
>>>> Signed-off-by: Moritz Fischer <moritzf@google.com>
>>>> ---
>>>> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git
>>>> a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
>>>> b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
>>>> index 2c72bd0c58..dc6e7a4d15 100644
>>>> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
>>>> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
>>>> @@ -22,7 +22,7 @@
>>>> */
>>>> STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = {
>>>> { "arm,arm-v7" },
>>>> - { "arm,arm-v8" },
>>>> + { "arm,armv8" },
>>> Thanks for the patch
>>>
>>> Should we keep both instead of removing the old one?
>
> [SAMI] I think we would need to keep both as the CPU nodes generated
> by Kvmtool have compatible string as "arm,arm-v8", see
> https://github.com/kvmtool/kvmtool/blob/master/arm/aarch64/arm-cpu.c#L31.
>
> Mortiz: Is it possible to share some information about your use case,
> please?
>
> [/SAMI]
>
>>>
>>>> { "arm,cortex-a15" },
>>>> { "arm,cortex-a7" },
>>>> { "arm,cortex-a57" }
>>>> --
>>>> 2.39.0.314.g84b9a713c41-goog
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
2023-01-06 9:55 ` Sami Mujawar
@ 2023-01-08 4:07 ` Moritz Fischer
2023-01-09 9:11 ` Sami Mujawar
0 siblings, 1 reply; 7+ messages in thread
From: Moritz Fischer @ 2023-01-08 4:07 UTC (permalink / raw)
To: Sami Mujawar; +Cc: Ard Biesheuvel, devel, nd@arm.com
Sami,
On Fri, Jan 6, 2023 at 1:55 AM Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Ard, Mortiz,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 06/01/2023 09:15 am, Ard Biesheuvel wrote:
> > (cc Sami)
> >
> > On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel <ardb@kernel.org> wrote:
> >> On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io
> >> <moritzf=google.com@groups.io> wrote:
> >>> Linux' cpu DT bindings call out arm,armv8 while the code previously
> >>> used arm,arm-v8.
> >>>
> >>> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
> >>> Signed-off-by: Moritz Fischer <moritzf@google.com>
> >>> ---
> >>> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> >>> index 2c72bd0c58..dc6e7a4d15 100644
> >>> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> >>> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> >>> @@ -22,7 +22,7 @@
> >>> */
> >>> STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = {
> >>> { "arm,arm-v7" },
> >>> - { "arm,arm-v8" },
> >>> + { "arm,armv8" },
> >> Thanks for the patch
> >>
> >> Should we keep both instead of removing the old one?
I think adding arm,armv8 is better. I don't know why I didn't think
about this from the beginning.
I can resend a v2. Can't hurt to support both?
>
> [SAMI] I think we would need to keep both as the CPU nodes generated by
> Kvmtool have compatible string as "arm,arm-v8", see
> https://github.com/kvmtool/kvmtool/blob/master/arm/aarch64/arm-cpu.c#L31.
>
> Mortiz: Is it possible to share some information about your use case,
> please?
I have to deal with a DT binary that uses the other one :-)
>
> [/SAMI]
>
> >>
> >>> { "arm,cortex-a15" },
> >>> { "arm,cortex-a7" },
> >>> { "arm,cortex-a57" }
> >>> --
> >>> 2.39.0.314.g84b9a713c41-goog
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
Cheers,
Moritz
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
2023-01-08 4:07 ` Moritz Fischer
@ 2023-01-09 9:11 ` Sami Mujawar
0 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2023-01-09 9:11 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Ard Biesheuvel, devel@edk2.groups.io, nd
Hi Moritz,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 08/01/2023, 04:08, "Moritz Fischer" <moritzf@google.com> wrote:
Sami,
On Fri, Jan 6, 2023 at 1:55 AM Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Ard, Mortiz,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 06/01/2023 09:15 am, Ard Biesheuvel wrote:
> > (cc Sami)
> >
> > On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel <ardb@kernel.org> wrote:
> >> On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io
> >> <moritzf=google.com@groups.io> wrote:
> >>> Linux' cpu DT bindings call out arm,armv8 while the code previously
> >>> used arm,arm-v8.
> >>>
> >>> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
> >>> Signed-off-by: Moritz Fischer <moritzf@google.com>
> >>> ---
> >>> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> >>> index 2c72bd0c58..dc6e7a4d15 100644
> >>> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> >>> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> >>> @@ -22,7 +22,7 @@
> >>> */
> >>> STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = {
> >>> { "arm,arm-v7" },
> >>> - { "arm,arm-v8" },
> >>> + { "arm,armv8" },
> >> Thanks for the patch
> >>
> >> Should we keep both instead of removing the old one?
I think adding arm,armv8 is better. I don't know why I didn't think
about this from the beginning.
I can resend a v2. Can't hurt to support both?
[SAMI] Ye, please. We need the existing enry to support Kvmtool guest firmware.
>
> [SAMI] I think we would need to keep both as the CPU nodes generated by
> Kvmtool have compatible string as "arm,arm-v8", see
> https://github.com/kvmtool/kvmtool/blob/master/arm/aarch64/arm-cpu.c#L31.
>
> Mortiz: Is it possible to share some information about your use case,
> please?
I have to deal with a DT binary that uses the other one :-)
>
> [/SAMI]
>
> >>
> >>> { "arm,cortex-a15" },
> >>> { "arm,cortex-a7" },
> >>> { "arm,cortex-a57" }
> >>> --
> >>> 2.39.0.314.g84b9a713c41-goog
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
Cheers,
Moritz
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-01-09 9:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-05 23:07 [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string Moritz Fischer
2023-01-06 9:14 ` [edk2-devel] " Ard Biesheuvel
2023-01-06 9:15 ` Ard Biesheuvel
2023-01-06 9:55 ` Sami Mujawar
2023-01-08 4:07 ` Moritz Fischer
2023-01-09 9:11 ` Sami Mujawar
[not found] ` <1737AFAF4745C39B.7095@groups.io>
2023-01-06 10:27 ` Sami Mujawar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox