From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.10050.1672996519308619175 for ; Fri, 06 Jan 2023 01:15:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IwSNi/K3; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F146FB81BFD for ; Fri, 6 Jan 2023 09:15:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F47C433F0 for ; Fri, 6 Jan 2023 09:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672996515; bh=Zq6tOVf703DweTnoj/c13A8wAbAuXvx6EHQd5gMtFk4=; h=References:In-Reply-To:From:Date:Subject:To:From; b=IwSNi/K35WzUJvtOffxKLl88BJfljZIXlxZkNm9yff6JdzEapJ2WZGs8Q7Fa0BBoT ckpMmnijgh56wzNeHPUDRjs+Otcb/tjEpJgGOS5847hd9MCXhYHfaeTPXvCXtRjQUR gC0ik0ycppxgn/34o4EufsyjlBrqW962J88JeeaFC5y8W1vinp6A/3oMCgdIyX0+QE SUvgYra6CjJfBWOHuYeJWuwlvSw3zpQcc5k0Ga1uJhRkJUzfG8m4hgj6tUpU1i3hEa WfbvxGMhHDOcAmJgF4MoERB8o67ZH1jswPtqupRbJ+CO176bIxKZstxM/mRd3fl1Rd QaOSdtHNtMXXA== Received: by mail-lj1-f181.google.com with SMTP id p2so893524ljn.7 for ; Fri, 06 Jan 2023 01:15:15 -0800 (PST) X-Gm-Message-State: AFqh2kpsLcDRCOZuaQbR46kCuOUbgMHlvuSASUEUdypULxz1D3Yn0Lh9 1m8qODY8qj8MXBCMLAZ3USdV1cjbbiFCLv1oUuc= X-Google-Smtp-Source: AMrXdXvNkmOKCeoMy7pvT6Nn3cuRl29gE17SwEjwPFNWVjaQnxASzs2Ao2dtySythGWjnJwt9znrKp9aN8YLw12n6UA= X-Received: by 2002:a2e:a99b:0:b0:27f:b833:cf6d with SMTP id x27-20020a2ea99b000000b0027fb833cf6dmr3466216ljq.291.1672996513675; Fri, 06 Jan 2023 01:15:13 -0800 (PST) MIME-Version: 1.0 References: <20230105230725.2401243-1-moritzf@google.com> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 6 Jan 2023 10:15:02 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string To: devel@edk2.groups.io, moritzf@google.com, Sami Mujawar Content-Type: text/plain; charset="UTF-8" (cc Sami) On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel wrote: > > On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io > wrote: > > > > Linux' cpu DT bindings call out arm,armv8 while the code previously > > used arm,arm-v8. > > > > Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser") > > Signed-off-by: Moritz Fischer > > --- > > DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > > index 2c72bd0c58..dc6e7a4d15 100644 > > --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > > +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > > @@ -22,7 +22,7 @@ > > */ > > STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = { > > { "arm,arm-v7" }, > > - { "arm,arm-v8" }, > > + { "arm,armv8" }, > > Thanks for the patch > > Should we keep both instead of removing the old one? > > > { "arm,cortex-a15" }, > > { "arm,cortex-a7" }, > > { "arm,cortex-a57" } > > -- > > 2.39.0.314.g84b9a713c41-goog > > > > > > > > > > > >