From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web12.9442.1623329220343773444 for ; Thu, 10 Jun 2021 05:47:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IwPlBgUg; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 56EC3613FF for ; Thu, 10 Jun 2021 12:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623329219; bh=8m+MbZWuPmj8WcCnVru2hpLUJu0IY40FtoPYwIDyZhU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IwPlBgUgZg4chYVJV3QIn8ouFK5fWu8LeaUQMLTA/GrsDTiBuRl3+qc3IoNYYC4dT 1wQl8NEocgA1RQ0hKxQkGKsHsYaTsJX9HmKZGe6GbMeN2amiFIuPG8g/TYM4o+lWWY dMhRcToekabBe4Fml9jWDMIbTNAFQx1GW1kH5jeDuvArFZFzkk7xQh6XkzyA/wkKaV z/rLM7a8t8xm8Ghze3RgK5ZZax0vy4OmdIt8bHlZyLy4EqL1DUYHdT8DFlUpUH39aa W7TfGz9aC8XWeEypOZEwYJ0IUK+CPhvkUqytkGhIpm18tGGR1oTY1Q0ta0J4+Dtp8H sDzRgz+OlTUjw== Received: by mail-oo1-f52.google.com with SMTP id s20-20020a4ae9940000b02902072d5df239so6744041ood.2 for ; Thu, 10 Jun 2021 05:46:59 -0700 (PDT) X-Gm-Message-State: AOAM531r83t6a4+R2ZIzZBGRYj4pJoJgADXEBFy8fdC5Sfy/NyC3VN9d x66Mm0CQd0xcJg9Et51A+Z+7MZ8ol4aM3VN3Z4I= X-Google-Smtp-Source: ABdhPJzGwKwgUwmwjIwse54b2ClrnO9aHjQXaF6fgZLFLs5gv502c07tuQ9I6m59+TXHnIhaY+6dCOShXn7ShjnBMtA= X-Received: by 2002:a4a:e9fb:: with SMTP id w27mr2228254ooc.41.1623329218714; Thu, 10 Jun 2021 05:46:58 -0700 (PDT) MIME-Version: 1.0 References: <20210609121828.1884825-1-dovmurik@linux.ibm.com> <20210609121828.1884825-4-dovmurik@linux.ibm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 10 Jun 2021 14:46:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header To: Laszlo Ersek Cc: edk2-devel-groups-io , Dov Murik , Ard Biesheuvel , Jordan Justen , James Bottomley , Tobin Feldman-Fitzthum Content-Type: text/plain; charset="UTF-8" On Wed, 9 Jun 2021 at 16:39, Laszlo Ersek wrote: > > On 06/09/21 14:18, Dov Murik wrote: > > Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the > > ground to add a warning about the incompatibility with boot verification > > process. > > > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Cc: Jordan Justen > > Cc: James Bottomley > > Cc: Tobin Feldman-Fitzthum > > Signed-off-by: Dov Murik > > --- > > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > > index 1177582ab051..dc9018f4333b 100644 > > --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > > +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > > @@ -2,6 +2,9 @@ > > X86 specific implementation of QemuLoadImageLib library class interface > > with support for loading mixed mode images and non-EFI stub images > > > > + Note that this implementation reads the cmdline (and possibly kernel, setup > > + data, and initrd in the legacy boot mode) from fw_cfg directly. > > + > > Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> > Copyright (c) 2020, ARM Ltd. All rights reserved.
> > > > > > (drive-by comment, no capacity for more atm): > > please update the INF file's comment at the top similarly > +1