From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Chang, Abner" <Abner.Chang@amd.com>
Cc: "Pierre.Gondois@arm.com" <Pierre.Gondois@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH 08/24] EmbeddedPkg: Remove duplicated words
Date: Mon, 5 Sep 2022 15:54:21 +0200 [thread overview]
Message-ID: <CAMj1kXFuXvsWCGgC8C-HN+Pb6aDXwjy+VgTgrXcVggqufk6EEQ@mail.gmail.com> (raw)
In-Reply-To: <MN2PR12MB3966F84A74CC72231710D3FBEA739@MN2PR12MB3966.namprd12.prod.outlook.com>
On Wed, 24 Aug 2022 at 15:31, Chang, Abner <Abner.Chang@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Abner Chang <abner.chang@amd.com>
>
Merged as #3287
> > -----Original Message-----
> > From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> > Sent: Wednesday, August 24, 2022 12:00 AM
> > To: devel@edk2.groups.io
> > Cc: Pierre Gondois <pierre.gondois@arm.com>; Leif Lindholm
> > <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> > Chang, Abner <Abner.Chang@amd.com>
> > Subject: [PATCH 08/24] EmbeddedPkg: Remove duplicated words
> >
> > [CAUTION: External Email]
> >
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > In an effort to clean the documentation of the above package, remove
> > duplicated words.
> >
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > ---
> > EmbeddedPkg/GdbStub/SerialIo.c | 2 +-
> > EmbeddedPkg/Include/Library/GdbSerialLib.h | 2 +-
> > EmbeddedPkg/Include/Library/RealTimeClockLib.h | 2 +-
> > .../Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2 +-
> > EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c | 2 +-
> > EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 2 +-
> > .../Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 2 +-
> > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 2 +-
> > 8 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/EmbeddedPkg/GdbStub/SerialIo.c
> > b/EmbeddedPkg/GdbStub/SerialIo.c index 9970ab687e4b..98ea611e8b04
> > 100644
> > --- a/EmbeddedPkg/GdbStub/SerialIo.c
> > +++ b/EmbeddedPkg/GdbStub/SerialIo.c
> > @@ -283,7 +283,7 @@ GdbSerialReset (
> > data buts, and stop bits on a serial device.
> >
> > @param This Protocol instance pointer.
> > - @param BaudRate The requested baud rate. A BaudRate value of 0 will
> > use the the
> > + @param BaudRate The requested baud rate. A BaudRate value of 0
> > will use the
> > device's default interface speed.
> > @param ReceiveFifoDepth The requested depth of the FIFO on the
> > receive side of the
> > serial interface. A ReceiveFifoDepth value of 0 will use diff --git
> > a/EmbeddedPkg/Include/Library/GdbSerialLib.h
> > b/EmbeddedPkg/Include/Library/GdbSerialLib.h
> > index 4845d6018cfe..58c3a5643c92 100644
> > --- a/EmbeddedPkg/Include/Library/GdbSerialLib.h
> > +++ b/EmbeddedPkg/Include/Library/GdbSerialLib.h
> > @@ -15,7 +15,7 @@
> > data buts, and stop bits on a serial device. This call is optional as the serial
> > port will be set up with defaults base on PCD values.
> >
> > - @param BaudRate The requested baud rate. A BaudRate value of 0 will
> > use the the
> > + @param BaudRate The requested baud rate. A BaudRate value of 0
> > will use the
> > device's default interface speed.
> > @param Parity The type of parity to use on this serial device. A Parity
> > value of
> > DefaultParity will use the device's default parity value.
> > diff --git a/EmbeddedPkg/Include/Library/RealTimeClockLib.h
> > b/EmbeddedPkg/Include/Library/RealTimeClockLib.h
> > index 9cc26c40a89d..ff45e26d6cfc 100644
> > --- a/EmbeddedPkg/Include/Library/RealTimeClockLib.h
> > +++ b/EmbeddedPkg/Include/Library/RealTimeClockLib.h
> > @@ -39,7 +39,7 @@ LibGetTime (
> >
> > @retval EFI_SUCCESS The operation completed successfully.
> > @retval EFI_INVALID_PARAMETER A time field is out of range.
> > - @retval EFI_DEVICE_ERROR The time could not be set due due to
> > hardware error.
> > + @retval EFI_DEVICE_ERROR The time could not be set due to hardware
> > error.
> >
> > **/
> > EFI_STATUS
> > diff --git
> > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > index d53a5fe47f18..334eb77607dd 100644
> > ---
> > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > +++
> > b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > @@ -51,7 +51,7 @@ GdbSerialLibDebugPortConstructor (
> > data buts, and stop bits on a serial device. This call is optional as the serial
> > port will be set up with defaults base on PCD values.
> >
> > - @param BaudRate The requested baud rate. A BaudRate value of 0 will
> > use the the
> > + @param BaudRate The requested baud rate. A BaudRate value of 0
> > will use the
> > device's default interface speed.
> > @param Parity The type of parity to use on this serial device. A Parity
> > value of
> > DefaultParity will use the device's default parity value.
> > diff --git a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
> > b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
> > index 75e00773ec7d..dea05c344042 100644
> > --- a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
> > +++ b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
> > @@ -78,7 +78,7 @@ GdbSerialLibConstructor (
> > data buts, and stop bits on a serial device. This call is optional as the serial
> > port will be set up with defaults base on PCD values.
> >
> > - @param BaudRate The requested baud rate. A BaudRate value of 0 will
> > use the the
> > + @param BaudRate The requested baud rate. A BaudRate value of 0
> > will use the
> > device's default interface speed.
> > @param Parity The type of parity to use on this serial device. A Parity
> > value of
> > DefaultParity will use the device's default parity value.
> > diff --git
> > a/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c
> > b/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c
> > index 7e8aaf28f6c9..cb5025914e3f 100644
> > --- a/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c
> > +++ b/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c
> > @@ -48,7 +48,7 @@ LibGetTime (
> >
> > @retval EFI_SUCCESS The operation completed successfully.
> > @retval EFI_INVALID_PARAMETER A time field is out of range.
> > - @retval EFI_DEVICE_ERROR The time could not be set due due to
> > hardware error.
> > + @retval EFI_DEVICE_ERROR The time could not be set due to hardware
> > error.
> >
> > **/
> > EFI_STATUS
> > diff --git
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > index fe963a315ae7..685e590980ec 100644
> > ---
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > +++
> > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLi
> > +++ b.c
> > @@ -233,7 +233,7 @@ LibGetTime (
> >
> > @retval EFI_SUCCESS The operation completed successfully.
> > @retval EFI_INVALID_PARAMETER A time field is out of range.
> > - @retval EFI_DEVICE_ERROR The time could not be set due due to
> > hardware error.
> > + @retval EFI_DEVICE_ERROR The time could not be set due to hardware
> > error.
> >
> > **/
> > EFI_STATUS
> > diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> > b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> > index 308e8cfca4bb..7adb7324057e 100644
> > --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> > +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> > @@ -74,7 +74,7 @@ GetTime (
> >
> > @retval EFI_SUCCESS The operation completed successfully.
> > @retval EFI_INVALID_PARAMETER A time field is out of range.
> > - @retval EFI_DEVICE_ERROR The time could not be set due due to
> > hardware error.
> > + @retval EFI_DEVICE_ERROR The time could not be set due to hardware
> > error.
> >
> > **/
> > EFI_STATUS
> > --
> > 2.25.1
next prev parent reply other threads:[~2022-09-05 13:54 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:00 [PATCH 00/24] Remove duplicated words PierreGondois
2022-08-23 16:00 ` [PATCH 01/24] .pytool: " PierreGondois
2022-08-23 16:00 ` [PATCH 02/24] ArmPkg: " PierreGondois
2022-08-23 17:13 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:28 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 03/24] ArmPlatformPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:26 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 04/24] ArmVirtPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 05/24] BaseTools: " PierreGondois
2022-08-23 16:00 ` [PATCH 06/24] CryptoPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 07/24] DynamicTablesPkg: " PierreGondois
2022-08-23 17:09 ` Sami Mujawar
2022-08-23 16:00 ` [PATCH 08/24] EmbeddedPkg: " PierreGondois
2022-08-24 13:29 ` Leif Lindholm
2022-08-24 13:31 ` Chang, Abner
2022-09-05 13:54 ` Ard Biesheuvel [this message]
2022-08-23 16:00 ` [PATCH 09/24] EmulatorPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 10/24] FatPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 11/24] IntelFsp2WrapperPkg: " PierreGondois
2022-08-23 16:55 ` Chiu, Chasel
2022-09-01 23:18 ` [edk2-devel] " Nate DeSimone
2022-09-01 23:24 ` Nate DeSimone
2022-08-23 16:00 ` [PATCH 12/24] MdeModulePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 13/24] MdePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 14/24] NetworkPkg: " PierreGondois
2022-09-02 14:31 ` [edk2-devel] " Maciej Rabeda
2022-08-23 16:00 ` [PATCH 15/24] OvmfPkg: " PierreGondois
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 16/24] PcAtChipsetPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 17/24] RedfishPkg: " PierreGondois
2022-08-24 13:32 ` Chang, Abner
2022-08-23 16:00 ` [PATCH 18/24] SecurityPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 19/24] ShellPkg: " PierreGondois
2022-08-24 5:34 ` Gao, Zhichao
2022-08-23 16:00 ` [PATCH 20/24] SourceLevelDebugPkg: " PierreGondois
2022-08-24 0:50 ` Wu, Hao A
2022-08-24 1:06 ` [edk2-devel] " Ni, Ray
2022-08-23 16:00 ` [PATCH 21/24] StandaloneMmPkg: " PierreGondois
2022-08-23 17:11 ` Sami Mujawar
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 22/24] UefiCpuPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 23/24] UefiPayloadPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 24/24] UnitTestFrameworkPkg: " PierreGondois
2022-08-25 3:12 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXFuXvsWCGgC8C-HN+Pb6aDXwjy+VgTgrXcVggqufk6EEQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox