public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	 Oliver Steffen <osteffen@redhat.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	 Jordan Justen <jordan.l.justen@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	 Rebecca Cran <quic_rcran@quicinc.com>
Subject: Re: [PATCH 1/1] OvmfPkg/VirtioGpuDxe: replace struct copy with CopyMem call
Date: Mon, 30 May 2022 11:32:03 +0200	[thread overview]
Message-ID: <CAMj1kXFuwpouuu6cXnVOaSVL6E6q5t1sXE4WHCikx7GtwVuWZQ@mail.gmail.com> (raw)
In-Reply-To: <20220530092255.279983-1-kraxel@redhat.com>

Hi Gerd,

On Mon, 30 May 2022 at 11:23, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Buildfix for `-t CLANG38 -b NOOPT -p OvmfPkg/OvmfPkgX64.dsc`.
>
> Fixes: 5f6ecaa398ba ("OvmfPkg/VirtioGpuDxe: use GopQueryMode in GopSetMode")
> Reported-by: Rebecca Cran <quic_rcran@quicinc.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  OvmfPkg/VirtioGpuDxe/Gop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c
> index 70a81c10c8b5..18b29e5a23d2 100644
> --- a/OvmfPkg/VirtioGpuDxe/Gop.c
> +++ b/OvmfPkg/VirtioGpuDxe/Gop.c
> @@ -509,7 +509,7 @@ GopSetMode (
>    // Populate Mode and ModeInfo (mutable fields only).
>    //
>    VgpuGop->GopMode.Mode = ModeNumber;
> -  VgpuGop->GopModeInfo  = *GopModeInfo;
> +  CopyMem(&VgpuGop->GopModeInfo, GopModeInfo, sizeof(*GopModeInfo));

Mind if I change this to

CopyMem (&VgpuGop->GopModeInfo, GopModeInfo, sizeof VgpuGop->GopModeInfo);

?

>    FreePool (GopModeInfo);
>    return EFI_SUCCESS;
>
> --
> 2.35.3
>

  reply	other threads:[~2022-05-30  9:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-30  9:22 [PATCH 1/1] OvmfPkg/VirtioGpuDxe: replace struct copy with CopyMem call Gerd Hoffmann
2022-05-30  9:32 ` Ard Biesheuvel [this message]
2022-05-30 10:21   ` Gerd Hoffmann
2022-05-30 11:08     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXFuwpouuu6cXnVOaSVL6E6q5t1sXE4WHCikx7GtwVuWZQ@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox