Re: [edk2-devel] [edk2-non-osi][PATCH V2] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

["Ard Biesheuvel" <ardb@kernel.org>]

On Wed, 18 Jan 2023 at 02:19, Isaac Oram <isaac.w.oram@intel.com> wrote:
>
> Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
>

NAK

This version updates VERSION_STRING not INF_VERSION

INF_VERSION must be 1.29
VERSION_STRING can be anything you like


> -----Original Message-----
> From: Tommy Huang <tommy_huang@aspeedtech.com>
> Sent: Tuesday, January 17, 2023 4:39 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Ryan <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
> Subject: [edk2-non-osi][PATCH V2] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver
>
> 1. Add ASpeedAst2600GopDxe.inf.
> 2. Add ASpeedAst2600Gop file for AArch64.
> 3. Update the others Gop UEFI binaries into the recently version. The version will be v1.13.02.
> 4. Fix the VERSION_STRING into correct value.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> Cc: BMC-SW <BMC-SW@aspeedtech.com>
>
> Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
> ---
>  .../AArch64/ASpeedAst2500Gop.efi              | Bin 42880 -> 45056 bytes
>  .../AArch64/ASpeedAst2600Gop.efi              | Bin 0 -> 45056 bytes
>  .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf   |   4 ++--
>  .../ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf   |  22 ++++++++++++++++++
>  .../ASpeedGopBinPkg/X64/ASpeedAst2500Gop.efi  | Bin 36928 -> 33600 bytes
>  .../ASpeedGopBinPkg/X64/ASpeedAst2600Gop.efi  | Bin 32544 -> 29952 bytes
>  6 files changed, 24 insertions(+), 2 deletions(-)
>  create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2600Gop.efi
>  create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
>
...
> diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> index b563f76..d6a674c 100644
> --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> @@ -10,11 +10,11 @@
>  ##
>
>
>
>  [Defines]
>
> -  INF_VERSION                    = 0x0001001B
>
> +  INF_VERSION                    = 0x00011302
>    BASE_NAME                      = ASpeedAst2500GopDxe
>
>    FILE_GUID                      = 7F81D838-F91D-4C44-8552-8FB912122FDD
>
>    MODULE_TYPE                    = UEFI_DRIVER
>
> -  VERSION_STRING                 = 1.1
>
> +  VERSION_STRING                 = 1.29
>
>
>  [Binaries.AArch64]
>
>    PE32|AArch64/ASpeedAst2500Gop.efi|*
>
> diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> new file mode 100644
> index 0000000..a652ced
> --- /dev/null
> +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> @@ -0,0 +1,22 @@
> +## @file
> +#  Component description file for ASPEED Graphics Controller Driver.
> +#
> +#  Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2010 - 2023, ASPEED Technology Inc. All rights reserved.<BR>
> +#
> +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> +  INF_VERSION                    = 0x00011302
> +  BASE_NAME                      = ASpeedAst2600GopDxe
> +  FILE_GUID                      = 36f08597-2a8d-4824-9416-59c810b0d9f3
> +  MODULE_TYPE                    = UEFI_DRIVER
> +  VERSION_STRING                 = 1.29
> +
> +[Binaries.AArch64]
> +  PE32|AArch64/ASpeedAst2600Gop.efi|*
> +
> +[Binaries.X64]
> +  PE32|X64/ASpeedAst2600Gop.efi|*