From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.40657.1674114801413733070 for ; Wed, 18 Jan 2023 23:53:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HSPCz0Lx; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C4787B82117 for ; Thu, 19 Jan 2023 07:53:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73557C433EF for ; Thu, 19 Jan 2023 07:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674114797; bh=o0LGDzrSw/GbaUPXXPGhXJEmXtRWMFqVYjT+gfGLpwE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HSPCz0LxTgonWoVbcQCUEBKIkH0wmQvb1GMVjr7GNnbwzFrcw9bmKKWmNo39ipy6W D1j6phqMTpJFEome3kR0necMSNFvFk7vBd0pGS/KJhUV6t0Q9sp56fzuGQP2GWqukD lZyFKMf9kQxsYLkQWOJgDBK70kbEHAHR3774gU6OIhI3gU7K91tNycUioMuOE5ORA1 c2CYAOu6gZ7BLczDITXHxi/B4HHy1Cryrso5QR0EwsCxE93ZRpvN+2HtF4H7Uv1O9d 85mbRKHV1qvE9Raq+lCQylW3RsPZFq/EocCjBjDSHyUKWi/kCsSE1A3np6716kXTYx 85EYCXojt04RA== Received: by mail-lf1-f43.google.com with SMTP id b3so2057978lfv.2 for ; Wed, 18 Jan 2023 23:53:17 -0800 (PST) X-Gm-Message-State: AFqh2kqMWnZpYVjGauN5ioUCx2bCk4iYscX/j0wmsiQpSd4SWdvtnsxU YugQ1MUYmyy2Dn9EpAWHKt5pxix5hR2PI4IY+wI= X-Google-Smtp-Source: AMrXdXsjhb9037bWvZ3wAofl6hvj2uojooiDrgjWVqkcFOKZP0d09KgwE+IbdDA7Cp6HotQpsFOLfjEfHTHvkFKhbxM= X-Received: by 2002:ac2:4bd5:0:b0:4d5:76af:f890 with SMTP id o21-20020ac24bd5000000b004d576aff890mr558267lfq.228.1674114795424; Wed, 18 Jan 2023 23:53:15 -0800 (PST) MIME-Version: 1.0 References: <20230118003852.2777-1-tommy_huang@aspeedtech.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 19 Jan 2023 08:53:03 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V2] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver To: devel@edk2.groups.io, isaac.w.oram@intel.com Cc: Tommy Huang , "Desimone, Nathaniel L" , "quic_llindhol@quicinc.com" , "Kinney, Michael D" , "Chen, Ryan" , "BMC-SW@aspeedtech.com" Content-Type: text/plain; charset="UTF-8" On Wed, 18 Jan 2023 at 02:19, Isaac Oram wrote: > > Reviewed-by: Isaac Oram > NAK This version updates VERSION_STRING not INF_VERSION INF_VERSION must be 1.29 VERSION_STRING can be anything you like > -----Original Message----- > From: Tommy Huang > Sent: Tuesday, January 17, 2023 4:39 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Oram, Isaac W ; quic_llindhol@quicinc.com; Kinney, Michael D ; Chen, Ryan ; BMC-SW@aspeedtech.com > Subject: [edk2-non-osi][PATCH V2] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver > > 1. Add ASpeedAst2600GopDxe.inf. > 2. Add ASpeedAst2600Gop file for AArch64. > 3. Update the others Gop UEFI binaries into the recently version. The version will be v1.13.02. > 4. Fix the VERSION_STRING into correct value. > > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ryan Chen > Cc: BMC-SW > > Signed-off-by: Tommy Huang > --- > .../AArch64/ASpeedAst2500Gop.efi | Bin 42880 -> 45056 bytes > .../AArch64/ASpeedAst2600Gop.efi | Bin 0 -> 45056 bytes > .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++-- > .../ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 22 ++++++++++++++++++ > .../ASpeedGopBinPkg/X64/ASpeedAst2500Gop.efi | Bin 36928 -> 33600 bytes > .../ASpeedGopBinPkg/X64/ASpeedAst2600Gop.efi | Bin 32544 -> 29952 bytes > 6 files changed, 24 insertions(+), 2 deletions(-) > create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/AArch64/ASpeedAst2600Gop.efi > create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf > ... > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf > index b563f76..d6a674c 100644 > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf > @@ -10,11 +10,11 @@ > ## > > > > [Defines] > > - INF_VERSION = 0x0001001B > > + INF_VERSION = 0x00011302 > BASE_NAME = ASpeedAst2500GopDxe > > FILE_GUID = 7F81D838-F91D-4C44-8552-8FB912122FDD > > MODULE_TYPE = UEFI_DRIVER > > - VERSION_STRING = 1.1 > > + VERSION_STRING = 1.29 > > > [Binaries.AArch64] > > PE32|AArch64/ASpeedAst2500Gop.efi|* > > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf > new file mode 100644 > index 0000000..a652ced > --- /dev/null > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf > @@ -0,0 +1,22 @@ > +## @file > +# Component description file for ASPEED Graphics Controller Driver. > +# > +# Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.
> +# Copyright (c) 2010 - 2023, ASPEED Technology Inc. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION = 0x00011302 > + BASE_NAME = ASpeedAst2600GopDxe > + FILE_GUID = 36f08597-2a8d-4824-9416-59c810b0d9f3 > + MODULE_TYPE = UEFI_DRIVER > + VERSION_STRING = 1.29 > + > +[Binaries.AArch64] > + PE32|AArch64/ASpeedAst2600Gop.efi|* > + > +[Binaries.X64] > + PE32|X64/ASpeedAst2600Gop.efi|*