From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 973AD7803CF for ; Tue, 5 Sep 2023 07:20:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=E5foaPnZhc96gBcbkl8xYRculHtk3bIa5iqiSisBjFg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1693898443; v=1; b=awOOGo7T821SCPMQ0LitlVcfSnNUinNH+rtTarjeJY2m3MnTBGxOCsXAkr09x9YBcly+CAUI IHn0ROXQjUH3eLOzy9aB882Gu5AiYQca9JRyxieYPgX9gPw6RM51p6boHfEFMEnS/K6h/yJmhAM miAWKjtfnPDBQnyY182uKFvk= X-Received: by 127.0.0.2 with SMTP id CwhiYY7687511xQHDWrL072i; Tue, 05 Sep 2023 00:20:43 -0700 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.16101.1693898442251230310 for ; Tue, 05 Sep 2023 00:20:42 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5CFE1B810B3 for ; Tue, 5 Sep 2023 07:20:40 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 222F0C433C9 for ; Tue, 5 Sep 2023 07:20:39 +0000 (UTC) X-Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2bd6611873aso32470731fa.1 for ; Tue, 05 Sep 2023 00:20:39 -0700 (PDT) X-Gm-Message-State: hZpN0So9VjZkZ8w2ThHNEMiVx7686176AA= X-Google-Smtp-Source: AGHT+IHNMleQPMGqDQD5PkDSgOBLYAiHfcznMRBlIEj9xNqtcaRKZsOorHWLDp91oWcjPEhhyGp38Q2EZXO44T4Ryo4= X-Received: by 2002:ac2:44c9:0:b0:4f8:7781:9870 with SMTP id d9-20020ac244c9000000b004f877819870mr7869506lfm.60.1693898437022; Tue, 05 Sep 2023 00:20:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 5 Sep 2023 09:20:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] Revert "OvmfPkg: Update build.sh to allow building OVMF then running QEMU" To: devel@edk2.groups.io, mjsbeaton@gmail.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=awOOGo7T; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 24 Aug 2023 at 06:46, Mike Beaton wrote: > > This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46. > > Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528 > > Signed-off-by: Mike Beaton > --- > OvmfPkg/build.sh | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index b0334fb76e..91b1442ade 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -245,11 +245,6 @@ else > echo using prebuilt tools > fi > -# > -# Build the edk2 OvmfPkg > -# > -echo Running edk2 build for OvmfPkg$Processor > -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t > $TARGET_TOOLS -n $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE > if [[ "$RUN_QEMU" == "yes" ]]; then > if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then > @@ -265,3 +260,11 @@ if [[ "$RUN_QEMU" == "yes" ]]; then > $QEMU_COMMAND "$@" > exit $? > fi > + > +# > +# Build the edk2 OvmfPkg > +# > +echo Running edk2 build for OvmfPkg$Processor > +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t > $TARGET_TOOLS -n $THREADNUMBER > +exit $? > + > -- > 2.37.5 > Thanks for the patch, and apologies for the delay. Tianocore is terrible in this regard, and the holiday season doesn't make things any better. Nostra culpa. Your patch doesn't apply, though: please use git send-email to prepare your patches rather than pasting the diff into a gmail edit window. Also, your commit log does not contain any explanation why the revert is made: please add some prose that captures this for posterity. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108278): https://edk2.groups.io/g/devel/message/108278 Mute This Topic: https://groups.io/mt/100930099/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-