Re: [PATCH v2 00/11] ArmPkg: Arm GIC Library and Driver improvements

["Ard Biesheuvel" <ardb@kernel.org>]

On Wed, 24 May 2023 at 15:39, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Bugzilla: Bug 3399 (https://bugzilla.tianocore.org/show_bug.cgi?id=3399)
>
> This patch series address the issues reported in
> https://bugzilla.tianocore.org/show_bug.cgi?id=3399
> and also has general improvements and fixes for other
> issues in the Arm GIC Library and driver.
>
> This patch series is expected to be applied on top of
> the patch at:
>   ArmPkg: Fix GicV2 BaseAddress types
>   (https://edk2.groups.io/g/devel/message/104721)
>
> This v2 series address the feedback received for the
> v1 series and additionally updates the patch 6/11
> 'ArmPkg: Make variables used for GicInterrupt UINTN'
> to extend the changes to GicV3IrqInterruptHandler ().
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1751_arm_giclib_v2
>
> Sami Mujawar (11):
>   ArmPkg: Fix data type used for GicDistributorBase
>   ArmPkg: Fix data type used for GicInterruptInterfaceBase
>   ArmPkg: Fix ArmGicSendSgiTo() parameters
>   ArmPkg: Fix Non-Boolean comparison in ArmGicEnableDistributor
>   ArmPkg: Fix return type for ArmGicGetInterfaceIdentification
>   ArmPkg: Make variables used for GicInterrupt UINTN
>   ArmPkg: Typecast IntID to UINT32 in ArmGicV2EndOfInterrupt
>   ArmPkg: Remove unused function declarations
>   ArmPkg: Prevent SgiId from setting RES0 bits of GICD_SGIR
>   ArmPkg: Adjust variable type and cast for RegShift & RegOffset
>   ArmPkg: Fix ArmGicAcknowledgeInterrupt () for GICv3
>

Merged as #4465

Thanks!

>  ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c         | 18 +----
>  ArmPkg/Drivers/ArmGic/ArmGicLib.c               | 73 ++++++++++++--------
>  ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c         |  8 ++-
>  ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c       | 23 +++---
>  ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c       |  6 +-
>  ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c |  6 +-
>  ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c       |  8 +--
>  ArmPkg/Include/Library/ArmGicLib.h              | 40 +++++------
>  8 files changed, 94 insertions(+), 88 deletions(-)
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>