From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.37332.1685635796090976144 for ; Thu, 01 Jun 2023 09:09:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mb6pp7O9; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8052E64738 for ; Thu, 1 Jun 2023 16:09:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E89C2C433A1 for ; Thu, 1 Jun 2023 16:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685635794; bh=Bj8W4hExZ70XNdXr9vCUozw/U/UKebO8DdxWDIOy1ns=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mb6pp7O9y+iGUUP2rPl7sBOF1gIusRms9ob+LvxfS538YwqNKCvrqm1Dq2YQqP7rx SpToFU+yrR+l7rHUa2g/bEj6k7PXpXm+ujoxodjPWIdpNKrPx1pp+CUq+43CgvwyR4 9+Y1QcYuKONzZHJ0G7JFic4Fw3zzzD7l5PgEIOAtelHnn7NLas53YdwEvInoSaRSge iO9OxsYsuelILPL+YYVvjmQ/92fIFS8l5QUN3pPpAEm5JNG1XwzFGd+bMoDlPPm8xF sNewAQfFUcoRs19HWX5ivSZgWJRipUuQ6wJh+VJ+DOEUftcZ9Htrwkmw/2OFE59zje /ykFcoSdOArEg== Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2afb2874e83so15187271fa.0 for ; Thu, 01 Jun 2023 09:09:54 -0700 (PDT) X-Gm-Message-State: AC+VfDw15pv62EenlecoglI5/InUChByoMK/eU52b+f9ebRMU0mqwzu9 Cch4AmEBWHPPqFOg2fu3SCprVXE6xHA/SOe8FWM= X-Google-Smtp-Source: ACHHUZ4Yk0cCT89l55WtBM5VTfoD21BJFAcruIkXLk48Kl1/R6FJpUwL0rZCTQ1buLu4X/DBp6Nvv37Y0AqKNmfPTyc= X-Received: by 2002:a2e:94ce:0:b0:2ac:7d7e:a503 with SMTP id r14-20020a2e94ce000000b002ac7d7ea503mr4723043ljh.36.1685635792963; Thu, 01 Jun 2023 09:09:52 -0700 (PDT) MIME-Version: 1.0 References: <20230524133840.28612-1-sami.mujawar@arm.com> In-Reply-To: <20230524133840.28612-1-sami.mujawar@arm.com> From: "Ard Biesheuvel" Date: Thu, 1 Jun 2023 18:09:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/11] ArmPkg: Arm GIC Library and Driver improvements To: Sami Mujawar Cc: devel@edk2.groups.io, ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, neil.jones@blaize.com, pedro.falcato@gmail.com, pierre.gondois@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, Sibel.Allinson@arm.com, nd@arm.com Content-Type: text/plain; charset="UTF-8" On Wed, 24 May 2023 at 15:39, Sami Mujawar wrote: > > Bugzilla: Bug 3399 (https://bugzilla.tianocore.org/show_bug.cgi?id=3399) > > This patch series address the issues reported in > https://bugzilla.tianocore.org/show_bug.cgi?id=3399 > and also has general improvements and fixes for other > issues in the Arm GIC Library and driver. > > This patch series is expected to be applied on top of > the patch at: > ArmPkg: Fix GicV2 BaseAddress types > (https://edk2.groups.io/g/devel/message/104721) > > This v2 series address the feedback received for the > v1 series and additionally updates the patch 6/11 > 'ArmPkg: Make variables used for GicInterrupt UINTN' > to extend the changes to GicV3IrqInterruptHandler (). > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/1751_arm_giclib_v2 > > Sami Mujawar (11): > ArmPkg: Fix data type used for GicDistributorBase > ArmPkg: Fix data type used for GicInterruptInterfaceBase > ArmPkg: Fix ArmGicSendSgiTo() parameters > ArmPkg: Fix Non-Boolean comparison in ArmGicEnableDistributor > ArmPkg: Fix return type for ArmGicGetInterfaceIdentification > ArmPkg: Make variables used for GicInterrupt UINTN > ArmPkg: Typecast IntID to UINT32 in ArmGicV2EndOfInterrupt > ArmPkg: Remove unused function declarations > ArmPkg: Prevent SgiId from setting RES0 bits of GICD_SGIR > ArmPkg: Adjust variable type and cast for RegShift & RegOffset > ArmPkg: Fix ArmGicAcknowledgeInterrupt () for GICv3 > Merged as #4465 Thanks! > ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 18 +---- > ArmPkg/Drivers/ArmGic/ArmGicLib.c | 73 ++++++++++++-------- > ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c | 8 ++- > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 23 +++--- > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c | 6 +- > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c | 6 +- > ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 8 +-- > ArmPkg/Include/Library/ArmGicLib.h | 40 +++++------ > 8 files changed, 94 insertions(+), 88 deletions(-) > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >