From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.7449.1684931391395669557 for ; Wed, 24 May 2023 05:29:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gMA4coc9; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB49F63CBF for ; Wed, 24 May 2023 12:29:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EF02C4339C for ; Wed, 24 May 2023 12:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684931390; bh=83HpoKtc2ggm6a617IWy9R6L47gUT7L7GqsMlKZj2kc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gMA4coc9YilHHunmjGTyQ0cLaZeQW7HYFC+vTTzHXGNq7wplJqKW89XbuIoBnLI/s tz8ArTh3Ta84d976IUmmbPTPdKNMJaH49M06RdB46vITHAnQOtq138+yqIZPu1u8Jw ER5EqHeaimlt6LNQVXQtjK7T9DLskT6VMMZUzVJ3IRuu9uBif51V0vZ1+lxfCbtIwQ B4Yhn07E/MYnDi3d/1SixCuLkAZ1CeTEa1d81Km5/f06CThSqxPW69/BqN1ySjFqLW LP2fR23kTle0kLuXsiasC+oMCtlPtbTNuXF/FDgp3+1KZL1F2KqyphBIjo6/Kt6NZN 5El+dNh5BYz0Q== Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2af177f12a5so11060481fa.2 for ; Wed, 24 May 2023 05:29:50 -0700 (PDT) X-Gm-Message-State: AC+VfDxXpZ8xATDrN5/wthlp4a8GJF6JSNsMVXvryHK52lL6bunGBwix 71Ez94CkAktNYH6S/A4+rAhvKyLccSj8GXK9ujQ= X-Google-Smtp-Source: ACHHUZ7qIZUxcL1ecmUscRIbOe+etHtzA06FbnM2lHLavy8vMBWju1uY7x++0lHIwaCYKv/wccq7d2icb3/wB50yrNo= X-Received: by 2002:a2e:b301:0:b0:2a7:7100:ff5a with SMTP id o1-20020a2eb301000000b002a77100ff5amr7098423lja.6.1684931388155; Wed, 24 May 2023 05:29:48 -0700 (PDT) MIME-Version: 1.0 References: <20230524091117.302120-1-kraxel@redhat.com> <044df447-aacd-b4c7-7a58-301d2676e217@redhat.com> In-Reply-To: <044df447-aacd-b4c7-7a58-301d2676e217@redhat.com> From: "Ard Biesheuvel" Date: Wed, 24 May 2023 14:29:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: drop S3Verification() To: Laszlo Ersek Cc: Gerd Hoffmann , devel@edk2.groups.io, Rebecca Cran , Pawel Polawski , Oliver Steffen , Jordan Justen , Ard Biesheuvel , Ray Ni , Jiewen Yao Content-Type: text/plain; charset="UTF-8" On Wed, 24 May 2023 at 14:28, Laszlo Ersek wrote: > > On 5/24/23 11:11, Gerd Hoffmann wrote: > > Not needed any more, SMM + 64-bit PEI + S3 suspend works now. While > > being at it also remove it from Bhyve (where it is dead code). > > > > Fixed by commits: > > - 8bd2028f9ac3 ("MdeModulePkg: Supporting S3 in 64bit PEI") > > - 6acf72901a2e ("UefiCpuPkg: Supporting S3 in 64bit PEI") > > See also https://bugzilla.tianocore.org/show_bug.cgi?id=4195 > > > > Signed-off-by: Gerd Hoffmann > > Reviewed-by: Ard Biesheuvel > > Reviewed-by: Laszlo Ersek > > Reviewed-by: Ray Ni > > --- > > OvmfPkg/Bhyve/PlatformPei/Platform.c | 29 -------------------------- > > OvmfPkg/PlatformPei/Platform.c | 31 ---------------------------- > > 2 files changed, 60 deletions(-) > > I disagree with this (v2) update. Bhyve platform code and QEMU platform > code should not be fused into a common patch, if there's a way to avoid > that. The reviewers for these C files are also different. If we want to > modify Bhyve as a courtesy, we can certainly propose a *separate* patch > for that. > > If others approve this patch, I can't block it from going in; since I've > been CC'd (and I thought I'd comment this time), this is my view on it. > Thanks Laszlo. I'll split them out when applying.