From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F2561AC1A01 for ; Tue, 28 Nov 2023 17:36:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aGC9pqLVmIV+rGKIMBdGpGVQs/InTvcDRLS+HRy+d6w=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1701192959; v=1; b=wuxcj+dBFCnqzox11X8DxTwXeQPejWnBdWZnw9+Ekx3fyHX7470THX3dRpZWZGtIJeKHT7CK 1PB0ZuCv88qRtMIFSjEHvsqSw25A6JQCb9V8ALYp2TUaV+ZRJtzGrvgGN1hA0aZrNAt2NVoq+kU 5R+M1gdZQ7P4RjPSIhX4kfEU= X-Received: by 127.0.0.2 with SMTP id k4PuYY7687511xiLEk6a8FRi; Tue, 28 Nov 2023 09:35:59 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.39517.1701192958688303456 for ; Tue, 28 Nov 2023 09:35:58 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0E25261842 for ; Tue, 28 Nov 2023 17:35:58 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B718CC433CB for ; Tue, 28 Nov 2023 17:35:57 +0000 (UTC) X-Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2c9b8363683so9111671fa.3 for ; Tue, 28 Nov 2023 09:35:57 -0800 (PST) X-Gm-Message-State: X8GiIMWzrluH3mLk3LfZItaUx7686176AA= X-Google-Smtp-Source: AGHT+IFkCw+uxvlC7MJrcTuQjJPOpfEPEuXee2Fn4BmBU1etS+PPeEMOiCDcY+OlfgTnTlpjaf7z5KGxsSBf3PSTsqo= X-Received: by 2002:a2e:9d4b:0:b0:2c5:56b:cbd1 with SMTP id y11-20020a2e9d4b000000b002c5056bcbd1mr9728757ljj.10.1701192955865; Tue, 28 Nov 2023 09:35:55 -0800 (PST) MIME-Version: 1.0 References: <20231128001500.1107-1-mikuback@linux.microsoft.com> <2d1b5213-faed-48fe-ab0a-3d08cd43675d@linux.microsoft.com> In-Reply-To: <2d1b5213-faed-48fe-ab0a-3d08cd43675d@linux.microsoft.com> From: "Ard Biesheuvel" Date: Tue, 28 Nov 2023 18:35:44 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 0/2] ArmPkg/CpuDxe: Use upper and lower attributes To: Michael Kubacki Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wuxcj+dB; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 28 Nov 2023 at 18:15, Michael Kubacki wrote: > > On 11/28/2023 4:51 AM, Ard Biesheuvel wrote: > > On Tue, 28 Nov 2023 at 01:15, wrote: > >> > >> From: Michael Kubacki > >> > >> This series contains two changes: > >> > >> 1. To fix a compiler warning with the current state of code. > >> 2. To update the code to pass the integer width needed for a > >> comparison to set EFI_MEMORY_XP in the GCD attribute returned > >> for a given page attribute. > >> > >> Cc: Leif Lindholm > >> Cc: Ard Biesheuvel > >> Cc: Sami Mujawar > >> > >> Michael Kubacki (2): > >> ArmPkg/Drivers/CpuDxe: Explicitly cast table entry > >> ArmPkg/Drivers/CpuDxe: Use lower and upper attributes > >> > > > > Thanks for the fixes. This code is in a rather poor state, unfortunately. > > > > I don't quite get the motivation for fixing this using two different > > patches: the implicit UINT32 cast obviously loses some attributes (the > > ones in the 12 upper bits, notably UXN and PXN), so making it explicit > > removes the warning but preserves the bug. (If GCC had better > > diagnostics, we'd spotted this problem years ago) > > > > Maybe it is sufficient to simply squash the two patches together? > > > I wanted to leave that open to discussion and maintainer discretion. I > think a squash is fine and sent a v2 with it done. > Thanks. I'll go and merge that. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111818): https://edk2.groups.io/g/devel/message/111818 Mute This Topic: https://groups.io/mt/102841999/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-