Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 25 Jul 2024 at 23:23, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Thu, 25 Jul 2024 at 22:21, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > Hi,
> >
> > On 7/25/24 06:38, Leif Lindholm wrote:
> > > On Thu, Jul 25, 2024 at 12:43:30 +0200, Ard Biesheuvel wrote:
> > >> From: Ard Biesheuvel <ardb@kernel.org>
> > >>
> > >> Drop the now unused EfiResetSystemLib implementation, which has been
> > >> superseded by the generic one from EDK2.
> > >>
> > >> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > >> ---
> > >>   Platform/RaspberryPi/RaspberryPi.dec                                   |   1 -
> > >>   Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf |   1 -
> > >>   Platform/RaspberryPi/Library/ResetLib/ResetLib.inf                     |  45 ------
> > >>   Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.c   |  11 --
> > >>   Platform/RaspberryPi/Library/ResetLib/ResetLib.c                       | 151 --------------------
> > >>   5 files changed, 209 deletions(-)
> > >>
> > >> diff --git a/Platform/RaspberryPi/RaspberryPi.dec b/Platform/RaspberryPi/RaspberryPi.dec
> > >> index 6bd16a5ae9fd..a5fa1fb00c48 100644
> > >> --- a/Platform/RaspberryPi/RaspberryPi.dec
> > >> +++ b/Platform/RaspberryPi/RaspberryPi.dec
> > >> @@ -24,7 +24,6 @@ [Protocols]
> > >>
> > >>   [Guids]
> > >>     gRaspberryPiTokenSpaceGuid = {0xCD7CC258, 0x31DB, 0x11E6, {0x9F, 0xD3, 0x63, 0xB0, 0xB8, 0xEE, 0xD6, 0xB5}}
> > >> -  gRaspberryPiEventResetGuid = {0xCD7CC258, 0x31DB, 0x11E6, {0x9F, 0xD3, 0x63, 0xB4, 0xB4, 0xE4, 0xD4, 0xB4}}
> > >>     gConfigDxeFormSetGuid = {0xCD7CC258, 0x31DB, 0x22E6, {0x9F, 0x22, 0x63, 0xB0, 0xB8, 0xEE, 0xD6, 0xB5}}
> > >
> > > *loud sigh at looking those "GUIDs"*
> > > But that's not this set's fault.
> >
> > The first couple are DCE time/mac UUIDs with the MAC address fuzzed, no?
> > Initially I assumed this coudn't be the case because I would have
> > expected the timestamp (2016-06-13 21:57:59, which looks almost
> > reasonable) to vary, but i'm guessing they were generated, and then
> > someone didn't want their mac in the pubic so they fuzzed it a couple
> > times rather than generating completely new IDs. Some of the others
> > though, maybe a BE/LE UUID/GUID manual conversion (or not) problem...
> >
>
> It looks to me like "hey I need a new GUIO so I'll just grab this one
> and stick some 2s or some 4s in random places"
>
> > Anyway, I will spin it up in a day or two on real hardware, but right
> > now its all torn down in boxes because i've moved.
> >
>
> Thanks. I'll do the same myself on Sunday or Monday - am travelling at
> the moment.

I ran into some issues with dispatch order - the added depexes prevent
the varblockservicedxe from being dispatched before the
VariableRuntimeDxe, which results in a crash.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120058): https://edk2.groups.io/g/devel/message/120058
Mute This Topic: https://groups.io/mt/107540912/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-