From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0E93B740035 for ; Sun, 28 Jul 2024 19:36:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5YhpERgLhUWcX6lQSGmyl88EVl0WlH94pP1kWV7TD6Y=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1722195377; v=1; b=JirqbjxvezcPyAbrzDYsDVx3oPBKQR1WYouHu6h+5X5y1zZlImz2KDv2jYxB4lb+drunQwvc mUsYebJWVjOJ3rW8JQgaAlwlpr8Q99xAX1kaHEziGhEp9nJVIMUh5SVejOgVy7CJTUGz6j5UczC jR9PE4Uob9EQ38d1Jnla8NGCf50w6iCKDOhSS4P8LxWHe6wtvma7seLU9bVQLft5akVMPflRezN hkJ7rQy8HJNUE46/XavuZbCEoUf/4UlbsAK4ixtvqtCZ/Ou+NeQTz3wyuz6EtBHz15wRmOWmFIl soZTYUt6/9WsIRjSsSpkdZ94lHBY12Wyytr67oBD5f2rg== X-Received: by 127.0.0.2 with SMTP id 1x7DYY7687511x3xuMJS4Son; Sun, 28 Jul 2024 12:36:15 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web10.40646.1722195373687256143 for ; Sun, 28 Jul 2024 12:36:14 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D0BD8CE049A for ; Sun, 28 Jul 2024 19:36:10 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18562C4AF0A for ; Sun, 28 Jul 2024 19:36:10 +0000 (UTC) X-Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2ef2fccca2cso34446071fa.1 for ; Sun, 28 Jul 2024 12:36:10 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVcDoho2fAwCOWMjs1glY+betpPJ/UtEQWPlGFmUKCwSRS48VdvCangdigpJXMxSApToFTBgsctbb3kqdGVFbVyAa7fQQ== X-Gm-Message-State: qWJ40jazT9KihayJB6JfrDPQx7686176AA= X-Google-Smtp-Source: AGHT+IGxjEY3PFYu/z17Ddud9+6AbLsYq95F/zMaweUFgVJMdBZU5KZr++EuSxjbsfce/8Su0+bBFT0cUMoVytBkZec= X-Received: by 2002:a05:6512:32ca:b0:52e:fd57:fd0e with SMTP id 2adb3069b0e04-5309b270b70mr3693920e87.17.1722195368378; Sun, 28 Jul 2024 12:36:08 -0700 (PDT) MIME-Version: 1.0 References: <20240725104332.1675625-1-ardb+git@google.com> <20240725104332.1675625-6-ardb+git@google.com> <7d3a04a4-f33a-4095-8390-bc77229caf5e@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Sun, 28 Jul 2024 21:35:56 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib To: Jeremy Linton Cc: Leif Lindholm , Ard Biesheuvel , devel@edk2.groups.io Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 28 Jul 2024 12:36:14 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Jirqbjxv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 25 Jul 2024 at 23:23, Ard Biesheuvel wrote: > > On Thu, 25 Jul 2024 at 22:21, Jeremy Linton wrote: > > > > Hi, > > > > On 7/25/24 06:38, Leif Lindholm wrote: > > > On Thu, Jul 25, 2024 at 12:43:30 +0200, Ard Biesheuvel wrote: > > >> From: Ard Biesheuvel > > >> > > >> Drop the now unused EfiResetSystemLib implementation, which has been > > >> superseded by the generic one from EDK2. > > >> > > >> Signed-off-by: Ard Biesheuvel > > >> --- > > >> Platform/RaspberryPi/RaspberryPi.dec | 1 - > > >> Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf | 1 - > > >> Platform/RaspberryPi/Library/ResetLib/ResetLib.inf | 45 ------ > > >> Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.c | 11 -- > > >> Platform/RaspberryPi/Library/ResetLib/ResetLib.c | 151 -------------------- > > >> 5 files changed, 209 deletions(-) > > >> > > >> diff --git a/Platform/RaspberryPi/RaspberryPi.dec b/Platform/RaspberryPi/RaspberryPi.dec > > >> index 6bd16a5ae9fd..a5fa1fb00c48 100644 > > >> --- a/Platform/RaspberryPi/RaspberryPi.dec > > >> +++ b/Platform/RaspberryPi/RaspberryPi.dec > > >> @@ -24,7 +24,6 @@ [Protocols] > > >> > > >> [Guids] > > >> gRaspberryPiTokenSpaceGuid = {0xCD7CC258, 0x31DB, 0x11E6, {0x9F, 0xD3, 0x63, 0xB0, 0xB8, 0xEE, 0xD6, 0xB5}} > > >> - gRaspberryPiEventResetGuid = {0xCD7CC258, 0x31DB, 0x11E6, {0x9F, 0xD3, 0x63, 0xB4, 0xB4, 0xE4, 0xD4, 0xB4}} > > >> gConfigDxeFormSetGuid = {0xCD7CC258, 0x31DB, 0x22E6, {0x9F, 0x22, 0x63, 0xB0, 0xB8, 0xEE, 0xD6, 0xB5}} > > > > > > *loud sigh at looking those "GUIDs"* > > > But that's not this set's fault. > > > > The first couple are DCE time/mac UUIDs with the MAC address fuzzed, no? > > Initially I assumed this coudn't be the case because I would have > > expected the timestamp (2016-06-13 21:57:59, which looks almost > > reasonable) to vary, but i'm guessing they were generated, and then > > someone didn't want their mac in the pubic so they fuzzed it a couple > > times rather than generating completely new IDs. Some of the others > > though, maybe a BE/LE UUID/GUID manual conversion (or not) problem... > > > > It looks to me like "hey I need a new GUIO so I'll just grab this one > and stick some 2s or some 4s in random places" > > > Anyway, I will spin it up in a day or two on real hardware, but right > > now its all torn down in boxes because i've moved. > > > > Thanks. I'll do the same myself on Sunday or Monday - am travelling at > the moment. I ran into some issues with dispatch order - the added depexes prevent the varblockservicedxe from being dispatched before the VariableRuntimeDxe, which results in a crash. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120058): https://edk2.groups.io/g/devel/message/120058 Mute This Topic: https://groups.io/mt/107540912/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-