Re: [edk2-devel] [PATCH 1/1] OvmfPkg: fix BuildResourceDescriptorHob call in PlatformAddHobCB()

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 26 Jan 2023 at 02:48, Yao, Jiewen <jiewen.yao@intel.com> wrote:
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>

Merged as #3947, thanks

> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> > Hoffmann
> > Sent: Thursday, January 26, 2023 1:11 AM
> > To: devel@edk2.groups.io
> > Cc: Pawel Polawski <ppolawsk@redhat.com>; Tom Lendacky
> > <thomas.lendacky@amd.com>; Yao, Jiewen <jiewen.yao@intel.com>; Oliver
> > Steffen <osteffen@redhat.com>; Gerd Hoffmann <kraxel@redhat.com>; Ard
> > Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan L
> > <jordan.l.justen@intel.com>
> > Subject: [edk2-devel] [PATCH 1/1] OvmfPkg: fix BuildResourceDescriptorHob call
> > in PlatformAddHobCB()
> >
> > BuildResourceDescriptorHob() expects the third parameter be the Length,
> > not the End address.
> >
> > Fixes: 328076cfdf45 ("OvmfPkg/PlatformInitLib: Add PlatformAddHobCB")
> > Reported-by: Tom Lendacky <thomas.lendacky@amd.com>
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  OvmfPkg/Library/PlatformInitLib/MemDetect.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> > b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> > index 5aeeeff89f57..38cece9173e8 100644
> > --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> > +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> > @@ -200,7 +200,7 @@ PlatformAddHobCB (
> >
> >        break;
> >      case EfiAcpiAddressRangeReserved:
> > -      BuildResourceDescriptorHob (EFI_RESOURCE_MEMORY_RESERVED, 0, Base,
> > End);
> > +      BuildResourceDescriptorHob (EFI_RESOURCE_MEMORY_RESERVED, 0,
> > Base, End - Base);
> >        DEBUG ((DEBUG_INFO, "%a: Reserved [0x%Lx, 0x%Lx)\n", __FUNCTION__,
> > Base, End));
> >        break;
> >      default:
> > --
> > 2.39.1
> >
> >
> >
> >
> >
>
>
>
> 
>
>