From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web12.5867.1637759044424911410 for ; Wed, 24 Nov 2021 05:04:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hFHkLC55; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id B32D063217 for ; Wed, 24 Nov 2021 13:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637759043; bh=Y1Zy30aIi8RWAUqOeUNk9ETueXKgMJ2CWw59Oe92IPE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hFHkLC55Cpc3xB7Jg87woB3elipUCViVUXkN0B0mXt11pCZ4cyLownbiWSUiTlKhJ 09tyoduo53n0GgnkjHi5OvSgZJjuFjxIslD6VeKI8JDOc54UWhsg+T0Eum0g1i9ZtB ankN8wiz/RVTkfJknMkZ5cQ68iCJyjLm8rnLwVbxxLSHh9nCssUiVX0RCy41QDQYjt Nr7BPMUOiZGFgZHZWLIZ18QD3B7Gy5NYb0vUZMB/giZvoGS41X2nFZrOMI2wk2TAik H1tk35B3eR3elIb1a2FZ47EukC60R8Vdxkh2Vh2dIEAatUh2oAPFXxzudj1ql5FChP K0jbAmJbLS17g== Received: by mail-oo1-f49.google.com with SMTP id v30-20020a4a315e000000b002c52d555875so875227oog.12 for ; Wed, 24 Nov 2021 05:04:03 -0800 (PST) X-Gm-Message-State: AOAM531KDQdkTA8htQSC/5fseoNf1TwnpseP/W5JHKdPy6H8G9dY+t5l 1MewxSv11vuTHyh1dXHfi8iDJUekSr7SUAwD4po= X-Google-Smtp-Source: ABdhPJxhMBuZ+8AeuSxGSDfT8bOmTSqVulEEJVDRR2Gb+tcLbejESFM/ZrLK81/lX7FBA3qNOhNffSrOW49JYIOd1bk= X-Received: by 2002:a4a:5a43:: with SMTP id v64mr8714340ooa.26.1637759043016; Wed, 24 Nov 2021 05:04:03 -0800 (PST) MIME-Version: 1.0 References: <20211116113301.31088-1-sami.mujawar@arm.com> <20211116113301.31088-3-sami.mujawar@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 24 Nov 2021 14:03:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/8] ArmPkg: PCD to select conduit for monitor calls To: Leif Lindholm Cc: Sami Mujawar , Ard Biesheuvel , edk2-devel-groups-io , Rebecca Cran , Gerd Hoffmann , Michael Kinney , "Liming Gao (Byosoft address)" , Zhiguang Liu , Jiewen Yao , Jian J Wang , Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd Content-Type: text/plain; charset="UTF-8" On Wed, 24 Nov 2021 at 13:07, Leif Lindholm wrote: > > Ard - how does this interact with e.g. ArmVirtPsciResetSystemLib, > which reads its conduit out of the DT passed to it by QEMU? > As long as ArmCallSmc() and ArmCallHvc() continue to exist and behave as before, I don't think those libraries are affected. > > On Tue, Nov 16, 2021 at 11:32:54 +0000, Sami Mujawar wrote: > > Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) > > > > Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for > > monitor calls. PcdMonitorConduitHvc is defined as FALSE by default, > > meaning the SMC conduit is enabled as default. > > > > Adding PcdMonitorConduitHvc allows selection of HVC conduit to be used > > by virtual firmware implementations. > > > > Signed-off-by: Sami Mujawar > > --- > > > > Notes: > > v2: > > - No code change since v1. Re-sending with V2 series. [SAMI] > > > > ArmPkg/ArmPkg.dec | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > > index 9da1bbc9f2166dc8ae93f96a34d3165fffed34dc..9a53888ae52f00eec50e631cf1bfcacecf8bba87 100644 > > --- a/ArmPkg/ArmPkg.dec > > +++ b/ArmPkg/ArmPkg.dec > > @@ -132,6 +132,11 @@ [PcdsFeatureFlag.common] > > # Define if the GICv3 controller should use the GICv2 legacy > > gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042 > > > > + ## Define the conduit to use for monitor calls. > > + # Default PcdMonitorConduitHvc = FALSE, conduit = SMC > > + # If PcdMonitorConduitHvc = TRUE, conduit = HVC > > + gArmTokenSpaceGuid.PcdMonitorConduitHvc|FALSE|BOOLEAN|0x00000047 > > + > > [PcdsFeatureFlag.ARM] > > # Whether to map normal memory as non-shareable. FALSE is the safe choice, but > > # TRUE may be appropriate to fix performance problems if you don't care about > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >